Fails to connect to IPv6 addresses

[vpzomtrrfrt]

import { createProxyServer } from "http-proxy-3";

createProxyServer({target: "http://[2a01:4f9:3071:2c0f:1:1000:0:2]/"}).listen(8000);

Running this and attempting to connect to the proxy triggers a crash:

/home/colin/tmp/pt/node_modules/http-proxy-3/dist/lib/http-proxy/index.js:127
                throw err;
                ^

Error: getaddrinfo ENOTFOUND [2a01:4f9:3071:2c0f:1:1000:0:2]
    at GetAddrInfoReqWrap.onlookupall [as oncomplete] (node:dns:120:26) {
  errno: -3008,
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: '[2a01:4f9:3071:2c0f:1:1000:0:2]'
}

Node.js v22.13.1

[vpzomtrrfrt]

Seems like it's trying to parse the address as a hostname. This happens to work for IPv4, but not for v6 because of the brackets

Not sure if there's a "proper" way to handle it, but this patch seems to work:

diff --git a/lib/http-proxy/common.ts b/lib/http-proxy/common.ts
index 0d073ac..519daf0 100644
--- a/lib/http-proxy/common.ts
+++ b/lib/http-proxy/common.ts
@@ -64,8 +64,6 @@ export function setupOutgoing(
   );

   for (const e of [
-    "host",
-    "hostname",
     "socketPath",
     "pfx",
     "key",
@@ -79,6 +77,14 @@ export function setupOutgoing(
     outgoing[e] = target[e];
   }

+  let hostname = ("hostname" in target && typeof target.hostname !== "undefined") ? target.hostname : target.host;
+  if (hostname.startsWith("[") && hostname.endsWith("]")) {
+    // Looks like an IPv6 literal, strip the brackets
+
+    hostname = hostname.substring(1, hostname.length - 1);
+  }
+  outgoing.host = hostname;
+
   outgoing.method = options.method || req.method;
   outgoing.headers = { ...req.headers };
   if (req.headers?.[":authority"]) {