From e48ba1cc7d20e713a7cdb78181d5a306c400612f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Simka?= Date: Mon, 6 Jul 2015 12:26:25 +0200 Subject: [PATCH 1/2] Fix ignoring additional options passed to Sauce Connect --- gems/sauce-connect/lib/sauce/connect.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gems/sauce-connect/lib/sauce/connect.rb b/gems/sauce-connect/lib/sauce/connect.rb index e1b350c..7ef6791 100644 --- a/gems/sauce-connect/lib/sauce/connect.rb +++ b/gems/sauce-connect/lib/sauce/connect.rb @@ -70,7 +70,7 @@ def connect formatted_cli_options = array_of_formatted_cli_options_from_hash(cli_options) command_args = ['-u', @config.username, '-k', @config.access_key] - command_args << formatted_cli_options + command_args += formatted_cli_options command = "exec #{find_sauce_connect} #{command_args.join(' ')} 2>&1" @@ -192,7 +192,7 @@ def self.ensure_connected(*args) def array_of_formatted_cli_options_from_hash(hash) hash.collect do |key, value| opt_name = key.to_s.gsub("_", "-") - return "--#{opt_name} #{value}" + "--#{opt_name} #{value}" end end From 631e36f2bb8e05ddc880879804516ab237e02008 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Simka?= Date: Mon, 6 Jul 2015 13:08:56 +0200 Subject: [PATCH 2/2] Some basic options escaping --- gems/sauce-connect/lib/sauce/connect.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gems/sauce-connect/lib/sauce/connect.rb b/gems/sauce-connect/lib/sauce/connect.rb index 7ef6791..0f8a2f3 100644 --- a/gems/sauce-connect/lib/sauce/connect.rb +++ b/gems/sauce-connect/lib/sauce/connect.rb @@ -192,7 +192,7 @@ def self.ensure_connected(*args) def array_of_formatted_cli_options_from_hash(hash) hash.collect do |key, value| opt_name = key.to_s.gsub("_", "-") - "--#{opt_name} #{value}" + "--#{opt_name} '#{value}'" end end