Saving changes to address book results in ISI

[eldeestephens]

Any attempt to save any changes to the address book results in a fatal ISI. This behavior is observed in all AOS4 builds on my X5000 running AOS4.1 FE update 1. To reproduce:

1. Bring up address book window either via button in main window or via menu
2. Click on save button after making change of any variety

... and that's it. instant ISI. I am also attaching a GR crashlog to help with debug. This bug still exists in version 0.45.

Crashlog_SimpleMail_2018-06-06_18-45-45.txt

Note: this issue was copied over from https://sourceforge.net/p/simplemail/bugs/182/

[ktadd]

This bug also occurs on my X1000 and is what prevents me from updating SimpleMail from v.42 to v.45. Versions newer than .42 all have this issue. I know several other people who will not upgrade from v.42 due to this issue. It's a critical issue.

[wawatok]

confirmed on my aros compile. trying to look into it.

[wawatok]

seems to happen in addressbook_clear() called from void addressbookwnd_store(void) in addressbookwnd.c (ln 1304). because this function has been called once before from line 495 of the same file with no problem i dont think this is the problem in function implementation in platform agnostic code but some problem in mui interface.

[ktadd]

Hmm...I've had it crash when you click Ok on the dialog when you add a email address. Here is the stack trace.

Crash log for task "SimpleMail_v45"
Generated by GrimReaper 53.19
Crash occured in module at address 0x00000000
Type of crash: ISI (Instruction Storage Interrupt) exception
Alert number: 0x80000003

Stack trace:
0x00000000 symbol not available
module SimpleMail_v45 at 0x7F82D908 (section 5 @ 0x28E4)
LIBS:muimaster.library:NotifyDispatcher()+0x118 (section 1 @ 0x67418)
native kernel module intuition.library.kmod+0x00021448
native kernel module intuition.library.kmod+0x000215ec
native kernel module intuition.library.kmod+0x0000a2ac
LIBS:muimaster.library:ApplicationDispatcher()+0xfe0 (section 1 @ 0x2DF58)
native kernel module intuition.library.kmod+0x00021448
native kernel module intuition.library.kmod+0x000215ec
native kernel module intuition.library.kmod+0x0000a3f4
LIBS:muimaster.library:m_Application_NewInput()+0xb90 (section 1 @ 0x28BDC)
LIBS:muimaster.library:ApplicationDispatcher()+0xd34 (section 1 @ 0x2DCAC)
native kernel module intuition.library.kmod+0x00021448
native kernel module intuition.library.kmod+0x000215ec
native kernel module intuition.library.kmod+0x0000a3f4
native kernel module intuition.library.kmod+0x0000a034
module SimpleMail_v45 at 0x7F8B3D38 (section 5 @ 0x88D14)
module SimpleMail_v45 at 0x7F8B4CEC (section 5 @ 0x89CC8)
module SimpleMail_v45 at 0x7F86EEE0 (section 5 @ 0x43EBC)
module SimpleMail_v45 at 0x7F8E33F4 (section 5 @ 0xB83D0)
SimpleMail_v45:_start()+0x8c (section 1 @ 0xB8620)
native kernel module dos.library.kmod+0x000255c8
native kernel module kernel+0x000420ac
native kernel module kernel+0x000420f4

[ktadd]

One other observation. If I open the address book and just click on "Save" once it doesn't crash. If I click on "Save" a second time it crashes. I can even click on "Save", close the address book, then open it up again and click on Save and it crashes. Something in the Save code path maybe is trashing something.