Skip to content

πŸ›‘οΈ Sentinel: Add explicit timeouts to fetch requests#105

Closed
schmug wants to merge 1 commit into
mainfrom
sentinel-fetch-timeouts-14529616724112407526
Closed

πŸ›‘οΈ Sentinel: Add explicit timeouts to fetch requests#105
schmug wants to merge 1 commit into
mainfrom
sentinel-fetch-timeouts-14529616724112407526

Conversation

@schmug
Copy link
Copy Markdown
Owner

@schmug schmug commented May 9, 2026

πŸ›‘οΈ Sentinel: [MEDIUM] Add timeout configurations to global API fetch calls

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Global fetch calls across components and API libraries lacked explicit timeouts, leading to potential DoS risks or application hangs from indefinitely delayed responses.
🎯 Impact: If an internal API endpoint (like /api/blog.json) or an external API (like api.github.com) hangs and fails to respond, the application promise will block indefinitely, causing hanging UI states or failed background fetches.
πŸ”§ Fix: Implemented defense-in-depth by adding a 10s timeout (signal: AbortSignal.timeout(10000)) to all global fetch operations to prevent blocking threads.
βœ… Verification: Run pnpm test and pnpm lint to ensure stability. No functional changes occurred; application fails securely if a timeout happens.


PR created automatically by Jules for task 14529616724112407526 started by @schmug

…calls

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Global fetch calls lacked explicit timeouts, posing a potential DoS/hang risk.
🎯 Impact: An unresponsive local internal endpoint or external API (e.g., GitHub) could cause components or SSG builds to block/hang indefinitely.
πŸ”§ Fix: Added `signal: AbortSignal.timeout(10000)` to `fetch` calls across components and API libraries.
βœ… Verification: `pnpm test` and `pnpm lint` passed.

Co-authored-by: schmug <38227427+schmug@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@schmug
Copy link
Copy Markdown
Owner Author

schmug commented May 16, 2026

Superseded by #127 (merged to main), which consolidated the best of the duplicate Bolt/Sentinel/Palette scheduled-agent PRs into one reviewed change. Closing as duplicate.

@schmug schmug closed this May 16, 2026
@google-labs-jules
Copy link
Copy Markdown
Contributor

Superseded by #127 (merged to main), which consolidated the best of the duplicate Bolt/Sentinel/Palette scheduled-agent PRs into one reviewed change. Closing as duplicate.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant