π¨ Palette: Add accessible clear buttons to search inputs#124
Conversation
- Added 'X' clear buttons to search inputs in Launcher, ProjectsApp, and BlogApp. - Ensured keyboard accessibility and focus management by restoring focus to the input upon clearing. - Added explicit `type="button"` and `aria-label="Clear search"` attributes. - Utilized existing CSS design tokens for focus-visible states. Co-authored-by: schmug <38227427+schmug@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Superseded by #127 (merged to main), which consolidated the best of the duplicate Bolt/Sentinel/Palette scheduled-agent PRs into one reviewed change. Closing as duplicate. |
π‘ What: Added an accessible 'clear' (
X) button to the search and filter inputs across the application (Launcher, ProjectsApp, and BlogApp).π― Why: When users are typing a long search query and want to start over, it's cumbersome to manually highlight and delete the text. Providing a clear button improves efficiency. Managing focus to return to the input upon clearing ensures continuous, accessible keyboard interaction.
πΈ Before/After:
The clear button appears only when there is input text. It uses the
lucide-reactXicon and aligns neatly inside the input container.βΏ Accessibility:
aria-label="Clear search"for screen readers.focus-visiblering styling.type="button"to ensure it doesn't accidentally trigger a form submission.PR created automatically by Jules for task 1057004159306697568 started by @schmug