Skip to content

ci: split deploy-pages workflow into build and deploy jobs #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henryiii merged 3 commits into from
May 20, 2026
+19 −7
Merged

ci: split deploy-pages workflow into build and deploy jobs #378

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fd38b2
ci: split deploy-pages workflow into build and deploy jobs
henryiii May 20, 2026
1f0f94f
ci: run build on PRs, only deploy on push to main
henryiii May 20, 2026
ebf1b60
ci: add explanatory comments for deploy job permissions
henryiii May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions .github/workflows/deploy-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: Deploy Webapp to GitHub Pages
on:
push:
branches: [main]
pull_request:
workflow_dispatch:

permissions: {}
Expand All @@ -12,12 +13,10 @@ concurrency:
cancel-in-progress: true

jobs:
build-and-deploy:
name: Build and Deploy
build:
name: Build
runs-on: ubuntu-latest
permissions:
pages: write # needed for pages
id-token: write # needed for pages
contents: read
steps:
- name: Checkout
Expand All @@ -36,13 +35,26 @@ jobs:
- name: Build webapp
run: bun run build-html

- name: Configure Pages
uses: actions/configure-pages@v6

- name: Upload artifact for Pages
uses: actions/upload-pages-artifact@v5
with:
path: out

deploy:
name: Deploy
needs: build
if: github.event_name == 'push'
runs-on: ubuntu-latest
permissions:
pages: write # needed for pages
id-token: write # needed for pages
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
steps:
- name: Configure Pages
uses: actions/configure-pages@v6

- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v5
Loading