Skip to content

Commit 0c68574

Browse files
committed
Make primary constructor enclosing ranges contain their anchor
1 parent db73793 commit 0c68574

5 files changed

Lines changed: 9 additions & 5 deletions

File tree

scip-kotlin-analysis/src/main/kotlin/org/scip_code/scip_java/kotlin_analysis/KotlinAnalysisIndexer.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,11 @@ class KotlinAnalysisIndexer(
270270
emitDefinition(
271271
symbol = cache.symbolForDeclaration(primaryConstructor),
272272
range = range,
273-
enclosing = primaryConstructor.textRange,
273+
// Span from the class identifier (the definition anchor) through the
274+
// parameter list, so the enclosing range contains its own anchor —
275+
// scip-kotlinc used the parameter list alone, which did not.
276+
enclosing =
277+
TextRange(range.startOffset, primaryConstructor.textRange.endOffset),
274278
displayName = displayName,
275279
signatureText = signatures.constructorSignature(primaryConstructor),
276280
documentation = docComment(primaryConstructor),

scip-snapshots/expected/kotlin/common/scip-snapshots/cases/kotlin/common/src/main/kotlin/snapshots/Annotations.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
// ^^^^^ reference scip-java maven . . kotlin/annotation/AnnotationTarget#CLASS.
99
// ^^^^^^^^^^^^^^^^ reference scip-java maven . . kotlin/annotation/AnnotationTarget#
1010
// ^^^^^^^^ reference scip-java maven . . kotlin/annotation/AnnotationTarget#FUNCTION.
11-
// ⌄ enclosing_range_start scip-java maven . . snapshots/Tagged#`<init>`().
11+
// ⌄ enclosing_range_start scip-java maven . . snapshots/Tagged#`<init>`().
1212
// ⌄ enclosing_range_start scip-java maven . . snapshots/Tagged#`<init>`().(tag)
1313
// ⌄ enclosing_range_start scip-java maven . . snapshots/Tagged#tag.
1414
// ⌄ enclosing_range_start scip-java maven . . snapshots/Tagged#getTag().

scip-snapshots/expected/kotlin/common/scip-snapshots/cases/kotlin/common/src/main/kotlin/snapshots/Destructuring.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// ^^^^^^^^^ reference scip-java maven . . snapshots/
33

44
//⌄ enclosing_range_start scip-java maven . . snapshots/Point#
5-
// ⌄ enclosing_range_start scip-java maven . . snapshots/Point#`<init>`().
5+
// ⌄ enclosing_range_start scip-java maven . . snapshots/Point#`<init>`().
66
// ⌄ enclosing_range_start scip-java maven . . snapshots/Point#copy().
77
// ⌄ enclosing_range_start scip-java maven . . snapshots/Point#`<init>`().(x)
88
// ⌄ enclosing_range_start scip-java maven . . snapshots/Point#x.

scip-snapshots/expected/kotlin/common/scip-snapshots/cases/kotlin/common/src/main/kotlin/snapshots/Enums.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//⌄ enclosing_range_start scip-java maven . . snapshots/Suit#valueOf().(value)
88
//⌄ enclosing_range_start scip-java maven . . snapshots/Suit#entries.
99
//⌄ enclosing_range_start scip-java maven . . snapshots/Suit#getEntries().
10-
// ⌄ enclosing_range_start scip-java maven . . snapshots/Suit#`<init>`().
10+
// ⌄ enclosing_range_start scip-java maven . . snapshots/Suit#`<init>`().
1111
// ⌄ enclosing_range_start scip-java maven . . snapshots/Suit#`<init>`().(symbol)
1212
// ⌄ enclosing_range_start scip-java maven . . snapshots/Suit#symbol.
1313
// ⌄ enclosing_range_start scip-java maven . . snapshots/Suit#getSymbol().

scip-snapshots/expected/kotlin/common/scip-snapshots/cases/kotlin/common/src/main/kotlin/snapshots/Generics.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
// ^^^^^^^^^ reference scip-java maven . . snapshots/
33

44
//⌄ enclosing_range_start scip-java maven . . snapshots/Container#
5+
// ⌄ enclosing_range_start scip-java maven . . snapshots/Container#`<init>`().
56
// ⌄ enclosing_range_start scip-java maven . . snapshots/Container#[T]
6-
// ⌄ enclosing_range_start scip-java maven . . snapshots/Container#`<init>`().
77
// ⌄ enclosing_range_start scip-java maven . . snapshots/Container#`<init>`().(items)
88
// ⌄ enclosing_range_start scip-java maven . . snapshots/Container#items.
99
// ⌄ enclosing_range_start scip-java maven . . snapshots/Container#getItems().

0 commit comments

Comments
 (0)