Colocate aggregator parser tests as Java/JUnit in scip-aggregator

Rewrite SymbolDescriptorSuite and JdkPackageSuite as JUnit 5 tests next to the code under test; wire jupiter-interface (test scope) into the scip project.

Author: jupblb

build.sbt

@@ -164,7 +164,13 @@ lazy val scip = project
     moduleName := "scip-aggregator",
     javaOnlySettings,
     libraryDependencies ++=
-      Seq("org.scip-code" % "scip-java-bindings" % V.scipBindings),
+      Seq(
+        "org.scip-code" % "scip-java-bindings" % V.scipBindings,
+        // JUnit 5 for the colocated Java unit tests (test scope only, so it is
+        // excluded from the published POM and keeps this a Java-only module).
+        "com.github.sbt.junit" % "jupiter-interface" %
+          JupiterKeys.jupiterVersion.value % Test
+      ),
     (Compile / PB.targets) :=
       Seq(PB.gens.java(V.protobuf) -> (Compile / sourceManaged).value),
     Compile / PB.protocOptions := Seq("--experimental_allow_proto3_optional")

scip-aggregator/src/test/java/com/sourcegraph/scip_aggregator/JdkPackageTest.java

@@ -0,0 +1,22 @@
+package com.sourcegraph.scip_aggregator;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import org.junit.jupiter.api.Test;
+
+/**
+ * Colocated unit test for {@link JdkPackage#parse}. Migrated from the former Scala JdkPackageSuite
+ * in tests/unit.
+ */
+class JdkPackageTest {
+
+  @Test
+  void keepsMajorVersionJdk11() {
+    assertEquals("11", JdkPackage.parse("11.0.9").version);
+  }
+
+  @Test
+  void keepsMajorVersionJdk17() {
+    assertEquals("17", JdkPackage.parse("17.0.5").version);
+  }
+}

scip-aggregator/src/test/java/com/sourcegraph/scip_aggregator/SymbolDescriptorTest.java

@@ -0,0 +1,66 @@
+package com.sourcegraph.scip_aggregator;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import com.sourcegraph.scip.ScipSymbols.Descriptor.Kind;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Colocated unit test for {@link SymbolDescriptor#parseFromSymbol}. Migrated from the former Scala
+ * SymbolDescriptorSuite in tests/unit; the expected (kind, name, owner) triples follow the SCIP
+ * symbol grammar.
+ */
+class SymbolDescriptorTest {
+
+  private static void check(String symbol, Kind kind, String name, String owner) {
+    SymbolDescriptor obtained = SymbolDescriptor.parseFromSymbol(symbol);
+    assertEquals(name, obtained.descriptor.name, symbol);
+    assertEquals(owner, obtained.owner, symbol);
+    assertEquals(kind, obtained.descriptor.kind, symbol);
+  }
+
+  @Test
+  void topLevelType() {
+    check("Test#", Kind.Type, "Test", "_root_/");
+  }
+
+  @Test
+  void typeInPackage() {
+    check("sample/Test#", Kind.Type, "Test", "sample/");
+  }
+
+  @Test
+  void method() {
+    check("sample/Test#m1().", Kind.Method, "m1", "sample/Test#");
+  }
+
+  @Test
+  void parameter() {
+    check("sample/Test#m1().(t1)", Kind.Parameter, "t1", "sample/Test#m1().");
+  }
+
+  @Test
+  void typeParameter() {
+    check("sample/Test#m1().[T1]", Kind.TypeParameter, "T1", "sample/Test#m1().");
+  }
+
+  @Test
+  void term() {
+    check("sample/Test#field.", Kind.Term, "field", "sample/Test#");
+  }
+
+  @Test
+  void constructor() {
+    check("sample/Test#`<init>`().", Kind.Method, "<init>", "sample/Test#");
+  }
+
+  @Test
+  void innerType() {
+    check("sample/Test#Inner#", Kind.Type, "Inner", "sample/Test#");
+  }
+
+  @Test
+  void packageDescriptor() {
+    check("sample/", Kind.Package, "sample", "_root_/");
+  }
+}