From 9554fd9db53d795416dee19468feb7af1321c4df Mon Sep 17 00:00:00 2001 From: Kaloyan Manolov Date: Tue, 26 May 2026 17:30:59 +0300 Subject: [PATCH 1/2] chore: minor update on agents file; symlink claude.md to agents.md --- AGENTS.md | 7 +++++++ CLAUDE.md | 1 + 2 files changed, 8 insertions(+) create mode 120000 CLAUDE.md diff --git a/AGENTS.md b/AGENTS.md index 47bea65c2eb..c85490b837b 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -60,6 +60,13 @@ npm test --workspace=packages/scratch-vm Each package defines its own `test` and `build` scripts; see "Packages at a glance" for specifics. +**After all code changes are complete**, run the tests and linter in the affected packages before moving on: + +```sh +npm test --workspace=packages/ +npm run lint --workspace=packages/ +``` + **Commit messages are enforced.** Husky + commitlint validate every commit against the [Conventional Commits](https://www.conventionalcommits.org/) format. A commit that doesn't conform will be rejected by the pre-commit hook. diff --git a/CLAUDE.md b/CLAUDE.md new file mode 120000 index 00000000000..47dc3e3d863 --- /dev/null +++ b/CLAUDE.md @@ -0,0 +1 @@ +AGENTS.md \ No newline at end of file From 9e79ac192b2cf4d3174ee2bafc493cb6b33674a5 Mon Sep 17 00:00:00 2001 From: Kaloyan Manolov Date: Tue, 26 May 2026 17:41:04 +0300 Subject: [PATCH 2/2] chore: improve agents.md formatting, remove duplication --- AGENTS.md | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index c85490b837b..ec32a4fcab2 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -15,9 +15,9 @@ Use these defaults unless the user asks otherwise: 2. Do not preserve backward compatibility when it isn't required. When all callers are internal to a package, rename or restructure freely. All packages in this repo are published to npm and consumed externally, so treat each package's public exports as a contract and preserve compatibility unless explicitly told otherwise. -3. Write comments that explain the current code, not its history. Do not reference prior implementations, - intermediate states, or what the code "used to do." If an approach seems counterintuitive, explain why it is - correct now — not why it changed. +3. Write comments that explain the current code, not its history or the work that produced it. Do not reference + prior implementations, intermediate states, what the code "used to do," or the task plan, ticket, or + instructions that prompted the change. If an approach seems counterintuitive, explain why it is correct now. 4. Prefer fixing root causes over adding surface-level workarounds or assertions. 5. When fixing a bug, start by adding one or more failing tests that reproduce it, then implement the fix. Iterate until all tests pass, including but not limited to the new tests. Use the test framework already in use in that @@ -60,9 +60,10 @@ npm test --workspace=packages/scratch-vm Each package defines its own `test` and `build` scripts; see "Packages at a glance" for specifics. -**After all code changes are complete**, run the tests and linter in the affected packages before moving on: +**After all code changes are complete**, run the build, tests, and linter in the affected packages and verify they complete with no errors before moving on: ```sh +npm run build --workspace=packages/ npm test --workspace=packages/ npm run lint --workspace=packages/ ``` @@ -154,6 +155,3 @@ Review all changes and confirm: (commands, repo structure, conventions, etc.). The "Packages at a glance" table is particularly prone to going stale when a package migrates its tooling. - **Commit format**: Commit message follows Conventional Commits — the husky hook will reject it otherwise. -- **Build passes**: `npm run build` (or `npm run build` in the affected package) completes successfully. -- **Tests pass**: `npm test` (or `npm test` in the affected package) completes with no failures. -- **No lint errors**: `npm run test:lint` (or `npm run lint`) passes in the affected package.