From 03daa960119ace541dbc027bb0c396328ed959d1 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 16 Mar 2026 17:56:16 +0000 Subject: [PATCH 1/4] [pre-commit.ci] pre-commit autoupdate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit updates: - [github.com/biomejs/pre-commit: v2.4.6 → v2.4.7](https://github.com/biomejs/pre-commit/compare/v2.4.6...v2.4.7) - [github.com/tox-dev/pyproject-fmt: v2.16.2 → v2.18.1](https://github.com/tox-dev/pyproject-fmt/compare/v2.16.2...v2.18.1) - [github.com/astral-sh/ruff-pre-commit: v0.15.5 → v0.15.6](https://github.com/astral-sh/ruff-pre-commit/compare/v0.15.5...v0.15.6) --- .pre-commit-config.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 0f31714a..39651bce 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,17 +1,17 @@ repos: # Hooks that are run everywhere - repo: https://github.com/biomejs/pre-commit - rev: v2.4.6 + rev: v2.4.7 hooks: - id: biome-format # Hooks that are run for scripts - repo: https://github.com/tox-dev/pyproject-fmt - rev: v2.16.2 + rev: v2.18.1 hooks: - id: pyproject-fmt files: ^scripts/pyproject\.toml$ - repo: https://github.com/astral-sh/ruff-pre-commit - rev: v0.15.5 + rev: v0.15.6 hooks: - id: ruff-check args: [--fix, --exit-non-zero-on-fix] From 581ae49b181749cf015d218b284847b82606a7f8 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 16 Mar 2026 17:56:32 +0000 Subject: [PATCH 2/4] Apply automatic changes --- {{cookiecutter.project_name}}/.pre-commit-config.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/{{cookiecutter.project_name}}/.pre-commit-config.yaml b/{{cookiecutter.project_name}}/.pre-commit-config.yaml index e5325f76..cac19ee3 100644 --- a/{{cookiecutter.project_name}}/.pre-commit-config.yaml +++ b/{{cookiecutter.project_name}}/.pre-commit-config.yaml @@ -7,16 +7,16 @@ default_stages: minimum_pre_commit_version: 2.16.0 repos: - repo: https://github.com/biomejs/pre-commit - rev: v2.4.6 + rev: v2.4.7 hooks: - id: biome-format exclude: ^\.cruft\.json$ # inconsistent indentation with cruft - file never to be modified manually. - repo: https://github.com/tox-dev/pyproject-fmt - rev: v2.16.2 + rev: v2.19.0 hooks: - id: pyproject-fmt - repo: https://github.com/astral-sh/ruff-pre-commit - rev: v0.15.5 + rev: v0.15.6 hooks: - id: ruff-check types_or: [python, pyi, jupyter] From 62442229e991c3d16f483bcf44b3e9228522fefb Mon Sep 17 00:00:00 2001 From: "Philipp A." Date: Wed, 18 Mar 2026 10:28:10 +0100 Subject: [PATCH 3/4] hm --- .pre-commit-config.yaml | 2 +- scripts/src/scverse_template_scripts/cruft_prs.py | 7 +++---- scripts/tests/test_cruft.py | 4 +++- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 39651bce..8044d3d4 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -6,7 +6,7 @@ repos: - id: biome-format # Hooks that are run for scripts - repo: https://github.com/tox-dev/pyproject-fmt - rev: v2.18.1 + rev: v2.19.0 hooks: - id: pyproject-fmt files: ^scripts/pyproject\.toml$ diff --git a/scripts/src/scverse_template_scripts/cruft_prs.py b/scripts/src/scverse_template_scripts/cruft_prs.py index 5950e421..18448e34 100644 --- a/scripts/src/scverse_template_scripts/cruft_prs.py +++ b/scripts/src/scverse_template_scripts/cruft_prs.py @@ -10,7 +10,7 @@ import os import sys from collections.abc import Iterable -from dataclasses import KW_ONLY, InitVar, dataclass, field +from dataclasses import KW_ONLY, dataclass, field from glob import glob from pathlib import Path from subprocess import run @@ -76,7 +76,6 @@ class GitHubConnection: """API connection to a GitHub user (e.g. scverse-bot)""" - _login: InitVar[str] token: str | None = field(repr=False, default=None) _: KW_ONLY email: str | None = field(default=None) @@ -85,9 +84,9 @@ class GitHubConnection: user: NamedUser = field(init=False) sig: Actor = field(init=False) - def __post_init__(self, _login: str) -> None: + def __post_init__(self) -> None: self.gh = Github(auth=Auth.Token(self.token) if self.token else None) - self.user = cast("NamedUser", self.gh.get_user(_login)) + self.user = cast("NamedUser", self.gh.get_user()) if self.email is None: self.email = self.user.email self.sig = Actor(self.login, self.email) diff --git a/scripts/tests/test_cruft.py b/scripts/tests/test_cruft.py index e76f84ec..bccbff18 100644 --- a/scripts/tests/test_cruft.py +++ b/scripts/tests/test_cruft.py @@ -29,7 +29,9 @@ def bot_con() -> GitHubConnection: """Connect to the scverse-bot github account. Make sure to use only a readonly-token to not destroy anything.""" token = os.environ["SCVERSE_BOT_READONLY_GITHUB_TOKEN"] - return GitHubConnection("scverse-bot", token, email="108668866+scverse-bot@users.noreply.github.com") + con = GitHubConnection(token, email="108668866+scverse-bot@users.noreply.github.com") + assert con.login == "scverse-bot" + return con @pytest.fixture From 47c45131bc1ee12aba137fa05f17d38db65baf7f Mon Sep 17 00:00:00 2001 From: "Philipp A." Date: Wed, 18 Mar 2026 10:45:19 +0100 Subject: [PATCH 4/4] hmm --- scripts/src/scverse_template_scripts/cruft_prs.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/src/scverse_template_scripts/cruft_prs.py b/scripts/src/scverse_template_scripts/cruft_prs.py index 18448e34..91345f3b 100644 --- a/scripts/src/scverse_template_scripts/cruft_prs.py +++ b/scripts/src/scverse_template_scripts/cruft_prs.py @@ -85,6 +85,7 @@ class GitHubConnection: sig: Actor = field(init=False) def __post_init__(self) -> None: + assert self.token.startswith("github_pat_") self.gh = Github(auth=Auth.Token(self.token) if self.token else None) self.user = cast("NamedUser", self.gh.get_user()) if self.email is None: