From 114beea74c04113e4b3528f1f6c00d15b3ce1ba7 Mon Sep 17 00:00:00 2001 From: Ashwin Kunder Date: Thu, 9 Feb 2017 12:46:50 -0800 Subject: [PATCH 1/3] fix for chrome - passive false --- Sortable.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Sortable.js b/Sortable.js index 2cab904bf..4fad11021 100644 --- a/Sortable.js +++ b/Sortable.js @@ -621,14 +621,14 @@ if (useFallback) { if (useFallback === 'touch') { // Bind touch events - _on(document, 'touchmove', this._onTouchMove); + _on(document, 'touchmove', this._onTouchMove, {passive: false}); _on(document, 'touchend', this._onDrop); _on(document, 'touchcancel', this._onDrop); - _on(document, 'pointermove', this._onTouchMove); + _on(document, 'pointermove', this._onTouchMove), {passive: false}; _on(document, 'pointerup', this._onDrop); } else { // Old brwoser - _on(document, 'mousemove', this._onTouchMove); + _on(document, 'mousemove', this._onTouchMove), {passive: false}; _on(document, 'mouseup', this._onDrop); } @@ -1111,7 +1111,10 @@ function _on(el, event, fn) { - el.addEventListener(event, fn, false); + if (typeof(options)==='undefined'){ + options = false + } + el.addEventListener(event, fn, options); } From 3ba9e373c463e76ed3c339ae068ac3c99ece62ff Mon Sep 17 00:00:00 2001 From: Ashwin Kunder Date: Thu, 9 Feb 2017 23:14:31 -0800 Subject: [PATCH 2/3] modify package.json --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 384160999..117b4827d 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { - "name": "sortablejs", + "name": "@st-operations/sortablejs", "exportName": "Sortable", - "version": "1.5.0-rc1", + "version": "1.1.0", "devDependencies": { "grunt": "*", "grunt-version": "*", From 96bb0076664e5ea89e8723d0993306ce9d889900 Mon Sep 17 00:00:00 2001 From: Ashwin Kunder Date: Fri, 10 Feb 2017 11:28:15 -0800 Subject: [PATCH 3/3] fixed typo and npm version --- Sortable.js | 6 +++--- package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Sortable.js b/Sortable.js index 4fad11021..4466155ec 100644 --- a/Sortable.js +++ b/Sortable.js @@ -624,11 +624,11 @@ _on(document, 'touchmove', this._onTouchMove, {passive: false}); _on(document, 'touchend', this._onDrop); _on(document, 'touchcancel', this._onDrop); - _on(document, 'pointermove', this._onTouchMove), {passive: false}; + _on(document, 'pointermove', this._onTouchMove, {passive: false}); _on(document, 'pointerup', this._onDrop); } else { // Old brwoser - _on(document, 'mousemove', this._onTouchMove), {passive: false}; + _on(document, 'mousemove', this._onTouchMove, {passive: false}); _on(document, 'mouseup', this._onDrop); } @@ -1110,7 +1110,7 @@ } - function _on(el, event, fn) { + function _on(el, event, fn, options) { if (typeof(options)==='undefined'){ options = false } diff --git a/package.json b/package.json index 117b4827d..77524e490 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@st-operations/sortablejs", "exportName": "Sortable", - "version": "1.1.0", + "version": "1.5.0-rc1-st1", "devDependencies": { "grunt": "*", "grunt-version": "*",