From bb1f6d3104b0654f3a339a6f92cec412fb830710 Mon Sep 17 00:00:00 2001
From: shawju <88799854+shawju@users.noreply.github.com>
Date: Thu, 16 Sep 2021 14:43:25 -0400
Subject: [PATCH 1/5] Improve CI

Improve the CI
---
 .github/workflows/node.js.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
index e463051..075f891 100644
--- a/.github/workflows/node.js.yml
+++ b/.github/workflows/node.js.yml
@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x]
+        node-version: [12.x, 14.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     steps:

From eb8013936dcc6ffbab429d2abe65636a34bb0734 Mon Sep 17 00:00:00 2001
From: shawju <88799854+shawju@users.noreply.github.com>
Date: Thu, 16 Sep 2021 15:27:47 -0400
Subject: [PATCH 2/5] Update .github/workflows/node.js.yml

Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com>
---
 .github/workflows/node.js.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
index 075f891..6cad902 100644
--- a/.github/workflows/node.js.yml
+++ b/.github/workflows/node.js.yml
@@ -16,6 +16,7 @@ jobs:
 
     strategy:
       matrix:
+        os: [ubuntu-latest, windows-2016]
         node-version: [12.x, 14.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 

From 387f8d6f1968e7bcb3c08a82f3fc3c4ccef34fad Mon Sep 17 00:00:00 2001
From: shawju <88799854+shawju@users.noreply.github.com>
Date: Thu, 16 Sep 2021 15:57:04 -0400
Subject: [PATCH 3/5] Update workflow

Separate build and test jobs
---
 .github/workflows/node.js.yml | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
index 6cad902..d7e9777 100644
--- a/.github/workflows/node.js.yml
+++ b/.github/workflows/node.js.yml
@@ -11,22 +11,29 @@ on:
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
-
+    steps:
+      - uses: actions/checkout@v2
+      - name: npm install and build webpack
+        run: |
+          npm install
+          npm run build
+          
+  test:
+    runs-on: ubuntu-latest
     strategy:
       matrix:
         os: [ubuntu-latest, windows-2016]
         node-version: [12.x, 14.x]
-        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
-
     steps:
     - uses: actions/checkout@v2
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v2
+      uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node-version }}
-        cache: 'npm'
-    - run: npm ci
-    - run: npm run build --if-present
-    - run: npm test
+    - name: npm install, and test
+      run: |
+        npm install
+        npm test
+      env:
+        CI: true

From 6a9c974c354d6ed44b24b896642bca425e896229 Mon Sep 17 00:00:00 2001
From: shawju <88799854+shawju@users.noreply.github.com>
Date: Thu, 16 Sep 2021 17:15:04 -0400
Subject: [PATCH 4/5] Update .github/workflows/node.js.yml

Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com>
---
 .github/workflows/node.js.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
index d7e9777..daf3f8a 100644
--- a/.github/workflows/node.js.yml
+++ b/.github/workflows/node.js.yml
@@ -20,7 +20,10 @@ jobs:
           npm run build
           
   test:
-    runs-on: ubuntu-latest
+      - uses: actions/upload-artifact@master
+        with:
+          name: webpack artifacts
+          path: public/
     strategy:
       matrix:
         os: [ubuntu-latest, windows-2016]

From beb0fb09100b87cfbf4234e1e938112ec5896b57 Mon Sep 17 00:00:00 2001
From: shawju <88799854+shawju@users.noreply.github.com>
Date: Thu, 16 Sep 2021 17:16:16 -0400
Subject: [PATCH 5/5] Update .github/workflows/node.js.yml

Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com>
---
 .github/workflows/node.js.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
index daf3f8a..00b8fb9 100644
--- a/.github/workflows/node.js.yml
+++ b/.github/workflows/node.js.yml
@@ -22,7 +22,7 @@ jobs:
   test:
       - uses: actions/upload-artifact@master
         with:
-          name: webpack artifacts
+    needs: build
           path: public/
     strategy:
       matrix: