[Feature]: Increase speed tool to above 2x

[matbgn]

Search existing issues

• I have searched the existing issues

Is your feature request related to a problem?

Some part of code review need to be speed up far more than 2x to not be boring, but trim is not applicable here.

Describe the solution you'd like

Maybe 4x would do the job, but why not letting an input field above 2x.

Describe alternatives you've considered

Trim is not applicable in this usecase.

Additional context

No response

[raymondjacobson]

Please add this! iMove supports a custom input field here. I often have needs to go to > 20x.

[1shanpanta]

Hey! I've submitted a PR for this: #291

Added 3x, 4x, 5x speed presets plus a custom playback speed input field where you can type any integer value. Max is capped at 16x since the video preview playhead stalls above that due to browser decoder limitations.

The custom input sits below the preset buttons -- shows -- when a preset is active, and you can type any value when you need something specific. Happy to adjust based on feedback!

[matbgn]

Very nice! Thank you, @1shanpanta

@siddharthvaddem when do you plan to pipeline a release for us to test?

[siddharthvaddem]

I'm not sure if I want to rush a release yet since there's been a ton of changes that I want to carefully test before making a release. You are welcome to pull from main and test for any regressions.

[matbgn]

Agree this is not fully production ready as is.

npm run build:linux

> openscreen@1.3.0 build:linux
> tsc && vite build && electron-builder --linux AppImage deb

src/contexts/I18nContext.tsx:43:53 - error TS2677: A type predicate's type must be assignable to its parameter's type.
  Type 'string | undefined' is not assignable to type 'string'.
    Type 'undefined' is not assignable to type 'string'.

43 function isSupportedLocale(value: string): value is Locale {
                                                       ~~~~~~

src/contexts/I18nContext.tsx:63:45 - error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  Type 'undefined' is not assignable to type 'string'.

63    localStorage.setItem(LOCALE_STORAGE_KEY, newLocale);
                                               ~~~~~~~~~

src/contexts/I18nContext.tsx:67:3 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.

67   document.documentElement.lang = newLocale;
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/contexts/I18nContext.tsx:69:35 - error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  Type 'undefined' is not assignable to type 'string'.

69   window.electronAPI?.setLocale?.(newLocale);
                                     ~~~~~~~~~

src/contexts/I18nContext.tsx:73:3 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.

73   document.documentElement.lang = locale;
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/i18n/loader.ts:37:18 - error TS2538: Type 'undefined' cannot be used as an index type.

37  return messages[locale]?.[namespace] ?? {};
                    ~~~~~~

src/i18n/loader.ts:41:2 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.

41  return getMessageValue(messages[locale]?.common, "locale.name") ?? locale;
    ~~~~~~

src/i18n/loader.ts:41:34 - error TS2538: Type 'undefined' cannot be used as an index type.

41  return getMessageValue(messages[locale]?.common, "locale.name") ?? locale;
                                    ~~~~~~

src/i18n/loader.ts:45:2 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.

45  return getMessageValue(messages[locale]?.common, "locale.short") ?? locale;
    ~~~~~~

src/i18n/loader.ts:45:34 - error TS2538: Type 'undefined' cannot be used as an index type.

45  return getMessageValue(messages[locale]?.common, "locale.short") ?? locale;
                                    ~~~~~~

src/i18n/loader.ts:55:28 - error TS2538: Type 'undefined' cannot be used as an index type.

55   getMessageValue(messages[locale]?.[namespace], key) ??
                              ~~~~~~


Found 11 errors in 2 files.

Errors  Files
     5  src/contexts/I18nContext.tsx:43
     6  src/i18n/loader.ts:37

Simply fixed with:

I will test local build for a moment and report if any relevant stuff is noticed.

[matbgn]

Just finished a middle to high project. Everything works fine in the tools I would say, including the speed code, thanks again!

Just one problem with the recorded screen on Linux the record is now flickering, I could not bissect from where it comes and decide not to spend more time on this and just recorded the source from another tool and used OpenScreen for anotation only.

But other than the above fix, everything worked fine for me on Ubuntu 24.04

[siddharthvaddem]

@matbgn thanks for letting me know. will take a closer look at it