From d39a792e149a3b0aa6f363ff020d5de77d451161 Mon Sep 17 00:00:00 2001 From: Karan Mistry Date: Fri, 20 Mar 2026 16:37:19 +0530 Subject: [PATCH 1/2] fixup(element): correct typos in comments and strings across multiple files --- projects/element-ng/datepicker/date-time-helper.ts | 2 +- .../formly/fields/text/si-formly-text-display.component.ts | 2 +- .../element-ng/list-details/si-list-details.component.ts | 2 +- .../system-banner/system-banner.component.spec.ts | 2 +- .../si-tabset/si-tabset-legacy.component.spec.ts | 2 +- projects/element-ng/tabs/si-tabset.component.spec.ts | 2 +- projects/element-ng/theme/si-theme-store.spec.ts | 2 +- projects/element-ng/theme/si-theme.service.spec.ts | 2 +- .../element-ng/threshold/si-threshold.component.spec.ts | 6 +++--- src/app/examples/si-about/si-about-text-api.ts | 2 +- src/app/examples/si-tour/si-tour.ts | 2 +- 11 files changed, 13 insertions(+), 13 deletions(-) diff --git a/projects/element-ng/datepicker/date-time-helper.ts b/projects/element-ng/datepicker/date-time-helper.ts index eb5c1387d..d7a9815c3 100644 --- a/projects/element-ng/datepicker/date-time-helper.ts +++ b/projects/element-ng/datepicker/date-time-helper.ts @@ -86,7 +86,7 @@ export const getDayStrings = ( ): string[] => { const dateFormatter = new Intl.DateTimeFormat(locale, { weekday: format, timeZone: 'utc' }); const days = []; - // Get local specific day strings from sunday (0) .. saturady (6) + // Get local specific day strings from sunday (0) .. saturday (6) for (let index = 1; index <= 7; index++) { const day = new Date(Date.UTC(2023, 0, index)); days.push(dateFormatter.format(day)); diff --git a/projects/element-ng/formly/fields/text/si-formly-text-display.component.ts b/projects/element-ng/formly/fields/text/si-formly-text-display.component.ts index 91ca004d8..cdb3c8718 100644 --- a/projects/element-ng/formly/fields/text/si-formly-text-display.component.ts +++ b/projects/element-ng/formly/fields/text/si-formly-text-display.component.ts @@ -22,7 +22,7 @@ export class SiFormlyTextDisplayComponent extends FieldType { let sourceModel = this.model; if (Array.isArray(this.model)) { - // The model is the arry itself when using this field as item into an array type... + // The model is the array itself when using this field as item into an array type... sourceModel = this.formControl.value; } if (this.props.key.indexOf('.') === -1) { diff --git a/projects/element-ng/list-details/si-list-details.component.ts b/projects/element-ng/list-details/si-list-details.component.ts index c15255251..43a3dd919 100644 --- a/projects/element-ng/list-details/si-list-details.component.ts +++ b/projects/element-ng/list-details/si-list-details.component.ts @@ -194,7 +194,7 @@ export class SiListDetailsComponent implements OnInit, OnChanges, OnDestroy { } } - // Transfer focus onto child panes if they would be inaccesible. + // Transfer focus onto child panes if they would be inaccessible. private transferFocus(): void { // Check if dimensions have even been evaluated. diff --git a/projects/element-ng/system-banner/system-banner.component.spec.ts b/projects/element-ng/system-banner/system-banner.component.spec.ts index 26ec6be89..c7c9eb720 100644 --- a/projects/element-ng/system-banner/system-banner.component.spec.ts +++ b/projects/element-ng/system-banner/system-banner.component.spec.ts @@ -21,7 +21,7 @@ describe('SiSystemBannerComponent', () => { expect(component).toBeTruthy(); }); - it('should display meesage', () => { + it('should display message', () => { expect(fixture.nativeElement.textContent.trim()).toBe('Test'); }); diff --git a/projects/element-ng/tabs-legacy/si-tabset/si-tabset-legacy.component.spec.ts b/projects/element-ng/tabs-legacy/si-tabset/si-tabset-legacy.component.spec.ts index ab0bcc533..136a1795e 100644 --- a/projects/element-ng/tabs-legacy/si-tabset/si-tabset-legacy.component.spec.ts +++ b/projects/element-ng/tabs-legacy/si-tabset/si-tabset-legacy.component.spec.ts @@ -47,7 +47,7 @@ class TestComponent { readonly tabSet = viewChild.required(SiTabsetLegacyComponent); - closeTriggered(tab: { heading: string; hidde?: boolean }): void { + closeTriggered(tab: { heading: string; hide?: boolean }): void { this.tabsObject = this.tabsObject.filter(t => t !== tab); } } diff --git a/projects/element-ng/tabs/si-tabset.component.spec.ts b/projects/element-ng/tabs/si-tabset.component.spec.ts index f70730510..0a96c1ed0 100644 --- a/projects/element-ng/tabs/si-tabset.component.spec.ts +++ b/projects/element-ng/tabs/si-tabset.component.spec.ts @@ -307,7 +307,7 @@ describe('SiTabset', () => { expect(await (await tabsetHarness.getTabItemButtonAt(1)).isFocused()).toBe(true); }); - it('should bring tab into visibile area if not visible on selection from menu', async () => { + it('should bring tab into visible area if not visible on selection from menu', async () => { testComponent.tabs = ['1', '2', '3', '4', '5']; testComponent.wrapperWidth.set(200); detectSizeChange(); diff --git a/projects/element-ng/theme/si-theme-store.spec.ts b/projects/element-ng/theme/si-theme-store.spec.ts index f9d858413..4077e04ca 100644 --- a/projects/element-ng/theme/si-theme-store.spec.ts +++ b/projects/element-ng/theme/si-theme-store.spec.ts @@ -93,7 +93,7 @@ describe('SiDefaultThemeStore', () => { expect(storage2.activeTheme).toBe('test'); }); - it('should deactive existing theme', async () => { + it('should deactivate existing theme', async () => { const storage: ThemeStorage = { activeTheme: 'test', themes: { 'test': { name: 'test', schemes: {} } } diff --git a/projects/element-ng/theme/si-theme.service.spec.ts b/projects/element-ng/theme/si-theme.service.spec.ts index bbc331971..16c06b007 100644 --- a/projects/element-ng/theme/si-theme.service.spec.ts +++ b/projects/element-ng/theme/si-theme.service.spec.ts @@ -200,7 +200,7 @@ describe('SiThemeService', () => { } }); - it('setActiveTheme with element should call deactive theme on storage', async () => { + it('setActiveTheme with element should call deactivate theme on storage', async () => { store.deactivateTheme.and.callFake(() => of(true)); setupTestBed(false, store); const result = await firstValueFrom(service.setActiveTheme(ELEMENT_THEME_NAME)); diff --git a/projects/element-ng/threshold/si-threshold.component.spec.ts b/projects/element-ng/threshold/si-threshold.component.spec.ts index 7f5bf81d3..579723418 100644 --- a/projects/element-ng/threshold/si-threshold.component.spec.ts +++ b/projects/element-ng/threshold/si-threshold.component.spec.ts @@ -86,7 +86,7 @@ describe('SiThresholdComponent', () => { let element: HTMLInputElement; let loader: HarnessLoader; - const getThreshodColors = (): string[] => { + const getThresholdColors = (): string[] => { const calculatedColors: string[] = []; element.querySelectorAll('.ths-option .line').forEach(item => { calculatedColors.push(item.classList.value.replace('line', '').trim()); @@ -176,7 +176,7 @@ describe('SiThresholdComponent', () => { it('should calculate color of steps', () => { fixture.detectChanges(); - const calculatedColors: string[] = getThreshodColors(); + const calculatedColors: string[] = getThresholdColors(); expect(calculatedColors).toEqual([ 'status-danger', 'status-warning', @@ -194,7 +194,7 @@ describe('SiThresholdComponent', () => { ).getHarness(SiSelectHarness); await selectHarness.clickItemsByText('Good'); - const calculatedColors: string[] = getThreshodColors(); + const calculatedColors: string[] = getThresholdColors(); expect(calculatedColors).toEqual([ 'status-danger', 'status-success', diff --git a/src/app/examples/si-about/si-about-text-api.ts b/src/app/examples/si-about/si-about-text-api.ts index e7933786b..20825378c 100644 --- a/src/app/examples/si-about/si-about-text-api.ts +++ b/src/app/examples/si-about/si-about-text-api.ts @@ -12,7 +12,7 @@ import { SiAboutComponent } from '@siemens/element-ng/about'; changeDetection: ChangeDetectionStrategy.OnPush }) export class SampleComponent { - licenseIntro = `Provide a disclaimer here about the thrid-party software + licenseIntro = `Provide a disclaimer here about the third-party software licenses provided in the component list below. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy diff --git a/src/app/examples/si-tour/si-tour.ts b/src/app/examples/si-tour/si-tour.ts index 45cd8faab..88bbc6136 100644 --- a/src/app/examples/si-tour/si-tour.ts +++ b/src/app/examples/si-tour/si-tour.ts @@ -78,7 +78,7 @@ export class SampleComponent implements AfterViewInit, OnDestroy { { name: 'Operations', iconClass: 'element-plant', - href: './oprtations-app', + href: './operations-app', active: true }, { name: 'App Portal', iconClass: 'element-security', href: './app-portal' }, From 1180d2c8b3e9344552feeb6cbc9b6828a6f3113c Mon Sep 17 00:00:00 2001 From: Karan Mistry Date: Fri, 20 Mar 2026 18:08:54 +0530 Subject: [PATCH 2/2] fix(snapshots): correct typos in YAML and update image sizes in snapshot files --- ...si-about-text-api-element-examples-chromium-dark-linux.png | 4 ++-- ...i-about-text-api-element-examples-chromium-light-linux.png | 4 ++-- .../static.spec.ts-snapshots/si-about--si-about-text-api.yaml | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api-element-examples-chromium-dark-linux.png b/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api-element-examples-chromium-dark-linux.png index eb3376b49..1fc5f0467 100644 --- a/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api-element-examples-chromium-dark-linux.png +++ b/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api-element-examples-chromium-dark-linux.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:6a8e0878f2e29e90ad6ac601d9f07672e55505d92e4617e5944541d11721f18d -size 78252 +oid sha256:c7e92e3eb352511fa784c42d828559742ea70dfb50340d27905beddf333c8b5b +size 78320 diff --git a/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api-element-examples-chromium-light-linux.png b/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api-element-examples-chromium-light-linux.png index 095f71c73..29c4fe8dd 100644 --- a/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api-element-examples-chromium-light-linux.png +++ b/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api-element-examples-chromium-light-linux.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:5f1e30acf89aebbe009780949855d7770e1f0c35b5d73e3fcbf5b7d63874bea9 -size 72957 +oid sha256:c72e9b284c0b3d7530998f3c443b2f210d9fb3c2eadcf7b9448b342441f4353c +size 73006 diff --git a/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api.yaml b/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api.yaml index 8335d0935..c933f3f25 100644 --- a/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api.yaml +++ b/playwright/snapshots/static.spec.ts-snapshots/si-about--si-about-text-api.yaml @@ -17,7 +17,7 @@ - /url: http://www.examples.org - link "More information about stuff": - /url: http://www.examples.org -- text: License Provide a disclaimer here about the thrid-party software licenses provided in the component list below. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. +- text: License Provide a disclaimer here about the third-party software licenses provided in the component list below. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. - button "OS" - region "OS" - button "Application"