From 1919eb6f8400bbe7e6d3ad66e9af7bdc4e10166c Mon Sep 17 00:00:00 2001 From: Omar Ibrahim Date: Fri, 26 Jun 2026 20:40:02 +0400 Subject: [PATCH] Enable key transparency for all users --- .../AdvancedPrivacySettingsFragment.kt | 43 +++++++++---------- .../securesms/jobs/CheckKeyTransparencyJob.kt | 6 +-- .../verify/VerifyDisplayScreenState.kt | 5 +-- 3 files changed, 23 insertions(+), 31 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/privacy/advanced/AdvancedPrivacySettingsFragment.kt b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/privacy/advanced/AdvancedPrivacySettingsFragment.kt index 19bb01f62c6..e6b45f50de0 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/privacy/advanced/AdvancedPrivacySettingsFragment.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/privacy/advanced/AdvancedPrivacySettingsFragment.kt @@ -45,7 +45,6 @@ import org.signal.core.ui.compose.Texts import org.thoughtcrime.securesms.R import org.thoughtcrime.securesms.compose.rememberStatusBarColorNestedScrollModifier import org.thoughtcrime.securesms.util.CommunicationActions -import org.thoughtcrime.securesms.util.RemoteConfig import org.thoughtcrime.securesms.util.viewModel /** @@ -301,31 +300,29 @@ private fun AdvancedPrivacySettingsScreen( ) } - if (RemoteConfig.internalUser) { - item { - Dividers.Default() - } + item { + Dividers.Default() + } - item { - val label = buildAnnotatedString { - append(stringResource(R.string.preferences_automatic_key_verification_body)) - append(" ") - withLink( - LinkAnnotation.Clickable("learn-more", linkInteractionListener = { - callbacks.onAutomaticVerificationLearnMoreClick() - }) - ) { - append(stringResource(R.string.LearnMoreTextView_learn_more)) - } + item { + val label = buildAnnotatedString { + append(stringResource(R.string.preferences_automatic_key_verification_body)) + append(" ") + withLink( + LinkAnnotation.Clickable("learn-more", linkInteractionListener = { + callbacks.onAutomaticVerificationLearnMoreClick() + }) + ) { + append(stringResource(R.string.LearnMoreTextView_learn_more)) } - - Rows.ToggleRow( - checked = state.allowAutomaticKeyVerification, - text = AnnotatedString(stringResource(R.string.preferences_automatic_key_verification)), - label = label, - onCheckChanged = callbacks::onAllowAutomaticVerificationChanged - ) } + + Rows.ToggleRow( + checked = state.allowAutomaticKeyVerification, + text = AnnotatedString(stringResource(R.string.preferences_automatic_key_verification)), + label = label, + onCheckChanged = callbacks::onAllowAutomaticVerificationChanged + ) } } } diff --git a/app/src/main/java/org/thoughtcrime/securesms/jobs/CheckKeyTransparencyJob.kt b/app/src/main/java/org/thoughtcrime/securesms/jobs/CheckKeyTransparencyJob.kt index 44240fc6a0c..fa6187ff030 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/jobs/CheckKeyTransparencyJob.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/jobs/CheckKeyTransparencyJob.kt @@ -17,7 +17,6 @@ import org.thoughtcrime.securesms.keyvalue.PhoneNumberPrivacyValues.PhoneNumberD import org.thoughtcrime.securesms.keyvalue.SignalStore import org.thoughtcrime.securesms.net.SignalNetwork import org.thoughtcrime.securesms.recipients.Recipient -import org.thoughtcrime.securesms.util.RemoteConfig import org.thoughtcrime.securesms.util.TextSecurePreferences import org.whispersystems.signalservice.api.crypto.UnidentifiedAccess import kotlin.random.Random @@ -87,10 +86,7 @@ class CheckKeyTransparencyJob private constructor( } private fun canRunJob(): Boolean { - return if (!RemoteConfig.internalUser) { - Log.i(TAG, "Remote config is not on. Exiting.") - false - } else if (!SignalStore.account.isRegistered) { + return if (!SignalStore.account.isRegistered) { Log.i(TAG, "Account not registered. Exiting.") false } else if (TextSecurePreferences.isUnauthorizedReceived(AppDependencies.application)) { diff --git a/app/src/main/java/org/thoughtcrime/securesms/verify/VerifyDisplayScreenState.kt b/app/src/main/java/org/thoughtcrime/securesms/verify/VerifyDisplayScreenState.kt index 1b709a78551..cce024ba3ce 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/verify/VerifyDisplayScreenState.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/verify/VerifyDisplayScreenState.kt @@ -7,12 +7,11 @@ package org.thoughtcrime.securesms.verify import org.thoughtcrime.securesms.keyvalue.SignalStore import org.thoughtcrime.securesms.recipients.Recipient -import org.thoughtcrime.securesms.util.RemoteConfig data class VerifyDisplayScreenState( val isSafetyNumberVerified: Boolean, - val isAutomaticVerificationVisible: Boolean = RemoteConfig.internalUser && SignalStore.settings.automaticVerificationEnabled, - val shouldDisplayVerifyAutomaticallyEducationSheet: Boolean = RemoteConfig.internalUser && SignalStore.settings.automaticVerificationEnabled && !SignalStore.uiHints.hasSeenVerifyAutomaticallySheet(), + val isAutomaticVerificationVisible: Boolean = SignalStore.settings.automaticVerificationEnabled, + val shouldDisplayVerifyAutomaticallyEducationSheet: Boolean = SignalStore.settings.automaticVerificationEnabled && !SignalStore.uiHints.hasSeenVerifyAutomaticallySheet(), val recipient: Recipient? = null, val fingerprintHolder: FingerprintHolder = FingerprintHolder.Uninitialised, val automaticVerificationStatus: AutomaticVerificationStatus = AutomaticVerificationStatus.NONE,