Context
Comment reviewer flagged a couple of minor WHAT-vs-WHY comment smells in the ZoneOn rewrite from #50. Non-blocking but worth a quick cleanup pass.
Items
plugin.py (inside actionControlSprinkler's ZoneOn branch):
- Drop the
# Validate against the device's configured zones. comment above the bounds check — the if + error message already say that.
- Drop
# 1-based on zone_index = action.zoneIndex — 1-based is the Indigo SDK convention for sprinkler zone indices and is already implicit in the subsequent [zone_index - 1] accesses.
api_client.py (start_watering docstring):
- Already mentions
duration is in minutes — keep. No change needed, flagged only for completeness.
Scope
Trivial. Two-line delete, no behaviour change. Follow-up from #50 review.
Context
Comment reviewer flagged a couple of minor WHAT-vs-WHY comment smells in the ZoneOn rewrite from #50. Non-blocking but worth a quick cleanup pass.
Items
plugin.py (inside
actionControlSprinkler's ZoneOn branch):# Validate against the device's configured zones.comment above the bounds check — theif+ error message already say that.# 1-basedonzone_index = action.zoneIndex— 1-based is the Indigo SDK convention for sprinkler zone indices and is already implicit in the subsequent[zone_index - 1]accesses.api_client.py (
start_wateringdocstring):durationis in minutes — keep. No change needed, flagged only for completeness.Scope
Trivial. Two-line delete, no behaviour change. Follow-up from #50 review.