Skip to content

Commit cdc7e6e

Browse files
committed
ci: fix build-args references
1 parent 2f7f49c commit cdc7e6e

4 files changed

Lines changed: 13 additions & 6 deletions

File tree

.github/workflows/container-validation.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@ jobs:
2929
context_path: "simplerisk-minimal/"
3030
dockerfile_path: "simplerisk-minimal/Dockerfile"
3131
image_tag: "simplerisk/simplerisk-minimal:testing"
32-
build_args: "version=8.1"
32+
build_args: "php_version=8.1"
3333

3434
simplerisk-minimal-php83:
3535
name: 'Verify simplerisk/simplerisk image based on PHP 8.3 with Apache'
3636
uses: ./.github/workflows/verify-image_rw.yml
3737
with:
3838
context_path: "simplerisk-minimal/"
39-
dockerfile_path: "simplerisk-minimal/php83/Dockerfile"
39+
dockerfile_path: "simplerisk-minimal/Dockerfile"
4040
image_tag: "simplerisk/simplerisk-minimal:testing"
41-
build_args: "version=8.3"
41+
build_args: "php_version=8.3"

.github/workflows/push-to-dockerhub.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,21 @@ jobs:
3939
uses: ./.github/workflows/push-to-dockerhub_rw.yml
4040
with:
4141
context_path: "simplerisk-minimal"
42-
dockerfile_path: "simplerisk-minimal/php81/Dockerfile"
42+
dockerfile_path: "simplerisk-minimal/Dockerfile"
4343
image_name: "simplerisk/simplerisk-minimal"
4444
version: "20250411-001"
4545
os_version: "php81"
46+
build_args: "php_version=8.1"
4647
secrets: inherit
4748
simplerisk-minimal-php83:
4849
name: 'Push simplerisk/simplerisk-minimal image based on PHP 8.3 with Apache'
4950
uses: ./.github/workflows/push-to-dockerhub_rw.yml
5051
with:
5152
context_path: "simplerisk-minimal"
52-
dockerfile_path: "simplerisk-minimal/php83/Dockerfile"
53+
dockerfile_path: "simplerisk-minimal/Dockerfile"
5354
image_name: "simplerisk/simplerisk-minimal"
5455
version: "20250411-001"
5556
os_version: "php83"
5657
main_image: true
58+
build_args: "php_version=8.3"
5759
secrets: inherit

.github/workflows/push-to-dockerhub_rw.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ on:
2727
description: Is this the latest image?
2828
default: false
2929
type: boolean
30+
build_args:
31+
description: Arguments to use on image at runtime
32+
type: string
3033
secrets:
3134
DOCKER_USERNAME:
3235
required: true
@@ -60,6 +63,7 @@ jobs:
6063
context: ${{ inputs.context_path }}
6164
file: ${{ inputs.dockerfile_path }}
6265
push: ${{ github.event_name != 'pull_request' }}
66+
build-args: ${{ inputs.build_args || '' }}
6367
tags: |
6468
${{ inputs.image_name }}
6569
${{ inputs.image_name }}:${{ inputs.version }}
@@ -72,6 +76,7 @@ jobs:
7276
context: ${{ inputs.context_path }}
7377
file: ${{ inputs.dockerfile_path }}
7478
push: ${{ github.event_name != 'pull_request' }}
79+
build-args: ${{ inputs.build_args || '' }}
7580
tags: |
7681
${{ inputs.image_name }}:${{ inputs.version }}-${{ inputs.os_version }}
7782
labels: ${{ steps.meta.outputs.labels }}

.github/workflows/verify-image_rw.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
context: ${{ inputs.context_path }}
2828
file: ${{ inputs.dockerfile_path }}
2929
tags: ${{ inputs.image_tag }}
30-
build_args: ${{ inputs.build_args || '' }}
30+
build-args: ${{ inputs.build_args || '' }}
3131
- name: Run linter with Dockle
3232
uses: erzz/dockle-action@v1
3333
with:

0 commit comments

Comments
 (0)