improvement(api): consolidate public v2 route handling #25434
TheodoreSpeaksci.yml
on: pull_request
Detect Version
Migrate Dev DB
/
Apply Database Migrations
Detect Desktop Changes
Matrix: Build AMD64
Matrix: Build ARM64 (GHCR Only)
Test and Build
/
Lint and Test
3m 53s
Test and Build
/
Build App
2m 22s
Check Docs Changes
Matrix: Build Dev ECR
Deploy Trigger.dev (Dev)
0s
Matrix: Create GHCR Manifests
Process Docs
/
Process Documentation Embeddings
Prune Desktop Prereleases
Desktop Release
/
Build, Sign, Notarize
Annotations
11 errors and 6 warnings
|
lib/billing/storage/tracking.test.ts > workspace storage counter mutations > rejects destination quota before mutating any ledger:
apps/sim/lib/billing/storage/tracking.test.ts#L537
AssertionError: expected [Function] to throw error including 'Storage limit exceeded' but got '[vitest] No "StorageLimitExceededErro…'
- Expected
+ Received
- Storage limit exceeded
+ [vitest] No "StorageLimitExceededError" export is defined on the "@/lib/billing/storage/limits" mock. Did you forget to return it from "vi.mock"?
+ If you need to partially mock a module, you can use "importOriginal" helper inside:
+
❯ lib/billing/storage/tracking.test.ts:537:5
|
|
lib/billing/storage/tracking.test.ts > workspace storage counter mutations > serializes quota admission on the locked payer ledger:
apps/sim/lib/billing/storage/tracking.test.ts#L209
AssertionError: expected [Function] to throw error including 'Storage limit exceeded' but got '[vitest] No "StorageLimitExceededErro…'
- Expected
+ Received
- Storage limit exceeded
+ [vitest] No "StorageLimitExceededError" export is defined on the "@/lib/billing/storage/limits" mock. Did you forget to return it from "vi.mock"?
+ If you need to partially mock a module, you can use "importOriginal" helper inside:
+
❯ lib/billing/storage/tracking.test.ts:209:5
|
|
lib/folders/paths.test.ts > canonical folder paths > keeps public folder mutations path-only and rejects the virtual root:
apps/sim/lib/folders/paths.test.ts#L122
AssertionError: expected true to be false // Object.is equality
- Expected
+ Received
- false
+ true
❯ lib/folders/paths.test.ts:122:7
|
|
hooks/queries/tables.test.ts:
apps/sim/lib/api/contracts/v1/tables/index.ts#L46
Error: [vitest] No "tableRowsQueryBaseSchema" export is defined on the "@/lib/api/contracts/tables" mock. Did you forget to return it from "vi.mock"?
If you need to partially mock a module, you can use "importOriginal" helper inside:
vi.mock(import("@/lib/api/contracts/tables"), async (importOriginal) => {
const actual = await importOriginal()
return {
...actual,
// your mocked methods
}
})
❯ lib/api/contracts/v1/tables/index.ts:46:39
❯ lib/api/contracts/v2/tables.ts:35:1
|
|
tools/index.test.ts > executeTool Function > does not charge private provenance against the functional response limit:
apps/sim/tools/index.test.ts#L1688
AssertionError: expected false to be true // Object.is equality
- Expected
+ Received
- true
+ false
❯ tools/index.test.ts:1688:28
|
|
tools/index.test.ts > executeTool Function > contains incomplete workflow provenance within that tool call:
apps/sim/tools/index.test.ts#L1634
AssertionError: expected { success: false, …(3) } to match object { success: false, output: {}, …(1) }
(4 matching properties omitted from actual)
- Expected
+ Received
{
- "error": "Internal tool response metadata could not be verified",
+ "error": "\"child-workflow\" failed: Child workflow child-workflow returned empty data",
"output": {},
"success": false,
}
❯ tools/index.test.ts:1634:20
|
|
tools/index.test.ts > executeTool Function > drops a legacy workflow response without poisoning later provenance:
apps/sim/tools/index.test.ts#L1587
AssertionError: expected { success: false, …(3) } to match object { success: true, …(1) }
(11 matching properties omitted from actual)
- Expected
+ Received
{
"output": {
- "value": "later call succeeded",
+ "error": {
+ "blockId": undefined,
+ "blockName": undefined,
+ "blockType": undefined,
+ "code": "EXECUTION_FAILED",
+ "message": "\"child-workflow\" failed: Child workflow child-workflow returned empty data",
},
- "success": true,
+ },
+ "success": false,
}
❯ tools/index.test.ts:1587:25
|
|
tools/index.test.ts > executeTool Function > filters cross-scope workflow provenance to literals present in the unchanged result:
apps/sim/tools/index.test.ts#L1498
AssertionError: expected { success: false, …(3) } to deeply equal { success: true, duration: 17, …(6) }
- Expected
+ Received
@@ -1,19 +1,17 @@
{
- "childWorkflowId": "child-workflow",
- "childWorkflowName": "Child Workflow",
- "duration": 17,
- "error": undefined,
+ "error": "\"child-workflow\" failed: Child workflow child-workflow returned empty data",
"output": {
- "answer": "The child returned crossed-secret verbatim",
- "publicValue": "unchanged",
+ "error": {
+ "blockId": undefined,
+ "blockName": undefined,
+ "blockType": undefined,
+ "code": "EXECUTION_FAILED",
+ "message": "\"child-workflow\" failed: Child workflow child-workflow returned empty data",
},
- "result": {
- "answer": "The child returned crossed-secret verbatim",
- "publicValue": "unchanged",
},
- "success": true,
+ "success": false,
"timing": {
"duration": 0,
"endTime": "2026-08-07T06:00:43.983Z",
"startTime": "2026-08-07T06:00:43.983Z",
},
❯ tools/index.test.ts:1498:20
|
|
tools/index.test.ts > executeTool Function > attaches exact workflow input provenance through the central internal transport:
apps/sim/tools/index.test.ts#L1424
SyntaxError: "undefined" is not valid JSON
❯ tools/index.test.ts:1424:23
|
|
Test and Build / Lint and Test
sim#test: command (/home/runner/_work/sim/sim/apps/sim) /home/runner/.bun/bin/bun run test exited (1)
|
|
Test and Build / Lint and Test
Process completed with exit code 1.
|
|
Test and Build / Lint and Test
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Lint and Test
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Lint and Test
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Lint and Test
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Lint and Test
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Lint and Test
Found 2 failed/cancelled steps in previous workflow steps
|