Skip to content

Commit 1bce1a4

Browse files
waleedlatif1waleedlatif1
committed
fix(docs): read trigger outputs from the registry too
Closes the gap left by the config fix: extractTriggerOutputs still parsed source, so triggers whose outputs come from a builder call lost their tables. jira_webhook had no output section at all. The registry was not a drop-in, which is why the naive swap deleted 10,298 lines earlier. The two sides encode nesting differently. A TriggerOutput marks a group by OMITTING type and holding children as sibling keys: issue: { id: { type: 'number' }, title: { type: 'string' } } while the renderer walks the JSON-Schema-ish shape the parser used to synthesize: issue: { type: 'object', properties: { id: …, title: … } } formatOutputStructure only descends into .properties, so handing it the raw registry value collapsed every nested group to one untyped row and dropped its children. normalizeTriggerOutputs converts between the two, preserving leaves that already declare properties/items and merging the 13 hybrid nodes that carry both a type and inline children. Measured across all 368 triggers before changing anything: 155 identical, 213 divergent, and the divergence was purely the nesting encoding — no node has a non-string type, and a group never carries its own string description, so leaf-vs-group classification is unambiguous. That is what makes a nested property literally named 'description' (42 of them) survive. Deletes the static path: extractTriggerOutputs, resolveTriggerBuilderFunction, resolveTriggerOutputsConstant, readTriggerSiblingModules, getWebhookProviderConstants, plus resolveConstStringValue and matchQuotedProperty which the config fix had already stranded. 20 output sections recovered (linear 79->93, tiktok 6->11, jira 44->45) and 1698 rows. Verified independently: zero sections lost across all 289 generated files, no file lost rows, output deterministic across regeneration. The 96 deletions are all corrections, not losses. 70 are confluence fields the parser flattened out of `comment: { ...buildContentEntityFields(), parent: {…} }` and rendered as top-level trigger outputs; they reappear nested under their parent in the same hunk. 8 are greenhouse key ordering, 6 are intercom descriptions the parser had dropped, 1 is a vercel row moving position. Generator: 4069 -> 3903 lines.
1 parent 3520afe commit 1bce1a4

17 files changed

Lines changed: 1377 additions & 316 deletions

‎apps/docs/content/docs/en/integrations/calcom.mdx‎

Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -808,6 +808,17 @@ Trigger workflow when a booking is cancelled in Cal.com
808808
| ↳ `status` | string | Booking status |
809809
| ↳ `location` | string | Meeting location or URL |
810810
| ↳ `cancellationReason` | string | Reason for cancellation |
811+
| ↳ `organizer` | object | Organizer details |
812+
| ↳ `id` | number | Organizer user ID |
813+
| ↳ `name` | string | Organizer name |
814+
| ↳ `email` | string | Organizer email |
815+
| ↳ `username` | string | Organizer username |
816+
| ↳ `timeZone` | string | Organizer timezone |
817+
| ↳ `attendees` | array | List of attendees |
818+
| ↳ `name` | string | Attendee name |
819+
| ↳ `email` | string | Attendee email |
820+
| ↳ `timeZone` | string | Attendee timezone |
821+
| ↳ `language` | string | Attendee language preference |
811822
| ↳ `responses` | json | Booking form responses |
812823
| ↳ `metadata` | json | Custom metadata attached to the booking |
813824

@@ -840,6 +851,17 @@ Trigger workflow when a new booking is created in Cal.com
840851
| ↳ `bookingId` | number | Numeric booking ID |
841852
| ↳ `status` | string | Booking status |
842853
| ↳ `location` | string | Meeting location or URL |
854+
| ↳ `organizer` | object | Organizer details |
855+
| ↳ `id` | number | Organizer user ID |
856+
| ↳ `name` | string | Organizer name |
857+
| ↳ `email` | string | Organizer email |
858+
| ↳ `username` | string | Organizer username |
859+
| ↳ `timeZone` | string | Organizer timezone |
860+
| ↳ `attendees` | array | List of attendees |
861+
| ↳ `name` | string | Attendee name |
862+
| ↳ `email` | string | Attendee email |
863+
| ↳ `timeZone` | string | Attendee timezone |
864+
| ↳ `language` | string | Attendee language preference |
843865
| ↳ `responses` | json | Booking form responses \(dynamic - fields depend on your event type configuration\) |
844866
| ↳ `metadata` | json | Custom metadata attached to the booking \(dynamic - user-defined key-value pairs\) |
845867
| ↳ `videoCallData` | json | Video call details \(structure varies by provider\) |
@@ -878,6 +900,17 @@ Trigger workflow when payment is completed for a paid booking
878900
| ↳ `amount` | number | Payment amount |
879901
| ↳ `currency` | string | Payment currency |
880902
| ↳ `success` | boolean | Whether payment succeeded |
903+
| ↳ `organizer` | object | Organizer details |
904+
| ↳ `id` | number | Organizer user ID |
905+
| ↳ `name` | string | Organizer name |
906+
| ↳ `email` | string | Organizer email |
907+
| ↳ `username` | string | Organizer username |
908+
| ↳ `timeZone` | string | Organizer timezone |
909+
| ↳ `attendees` | array | List of attendees |
910+
| ↳ `name` | string | Attendee name |
911+
| ↳ `email` | string | Attendee email |
912+
| ↳ `timeZone` | string | Attendee timezone |
913+
| ↳ `language` | string | Attendee language preference |
881914
| ↳ `metadata` | json | Custom metadata attached to the booking |
882915

883916

@@ -909,6 +942,17 @@ Trigger workflow when a booking request is rejected by the host
909942
| ↳ `bookingId` | number | Numeric booking ID |
910943
| ↳ `status` | string | Booking status \(rejected\) |
911944
| ↳ `rejectionReason` | string | Reason for rejection provided by host |
945+
| ↳ `organizer` | object | Organizer details |
946+
| ↳ `id` | number | Organizer user ID |
947+
| ↳ `name` | string | Organizer name |
948+
| ↳ `email` | string | Organizer email |
949+
| ↳ `username` | string | Organizer username |
950+
| ↳ `timeZone` | string | Organizer timezone |
951+
| ↳ `attendees` | array | List of attendees |
952+
| ↳ `name` | string | Attendee name |
953+
| ↳ `email` | string | Attendee email |
954+
| ↳ `timeZone` | string | Attendee timezone |
955+
| ↳ `language` | string | Attendee language preference |
912956
| ↳ `metadata` | json | Custom metadata attached to the booking |
913957

914958

@@ -940,6 +984,17 @@ Trigger workflow when a booking request is submitted (pending confirmation)
940984
| ↳ `bookingId` | number | Numeric booking ID |
941985
| ↳ `status` | string | Booking status \(pending\) |
942986
| ↳ `location` | string | Meeting location or URL |
987+
| ↳ `organizer` | object | Organizer details |
988+
| ↳ `id` | number | Organizer user ID |
989+
| ↳ `name` | string | Organizer name |
990+
| ↳ `email` | string | Organizer email |
991+
| ↳ `username` | string | Organizer username |
992+
| ↳ `timeZone` | string | Organizer timezone |
993+
| ↳ `attendees` | array | List of attendees |
994+
| ↳ `name` | string | Attendee name |
995+
| ↳ `email` | string | Attendee email |
996+
| ↳ `timeZone` | string | Attendee timezone |
997+
| ↳ `language` | string | Attendee language preference |
943998
| ↳ `responses` | json | Booking form responses |
944999
| ↳ `metadata` | json | Custom metadata attached to the booking |
9451000

@@ -976,6 +1031,17 @@ Trigger workflow when a booking is rescheduled in Cal.com
9761031
| ↳ `rescheduleUid` | string | Previous booking UID |
9771032
| ↳ `rescheduleStartTime` | string | Original start time \(ISO 8601\) |
9781033
| ↳ `rescheduleEndTime` | string | Original end time \(ISO 8601\) |
1034+
| ↳ `organizer` | object | Organizer details |
1035+
| ↳ `id` | number | Organizer user ID |
1036+
| ↳ `name` | string | Organizer name |
1037+
| ↳ `email` | string | Organizer email |
1038+
| ↳ `username` | string | Organizer username |
1039+
| ↳ `timeZone` | string | Organizer timezone |
1040+
| ↳ `attendees` | array | List of attendees |
1041+
| ↳ `name` | string | Attendee name |
1042+
| ↳ `email` | string | Attendee email |
1043+
| ↳ `timeZone` | string | Attendee timezone |
1044+
| ↳ `language` | string | Attendee language preference |
9791045
| ↳ `responses` | json | Booking form responses |
9801046
| ↳ `metadata` | json | Custom metadata attached to the booking |
9811047

@@ -1006,6 +1072,17 @@ Trigger workflow when a Cal.com meeting ends
10061072
| ↳ `uid` | string | Unique booking identifier |
10071073
| ↳ `bookingId` | number | Numeric booking ID |
10081074
| ↳ `duration` | number | Actual meeting duration in minutes |
1075+
| ↳ `organizer` | object | Organizer details |
1076+
| ↳ `id` | number | Organizer user ID |
1077+
| ↳ `name` | string | Organizer name |
1078+
| ↳ `email` | string | Organizer email |
1079+
| ↳ `username` | string | Organizer username |
1080+
| ↳ `timeZone` | string | Organizer timezone |
1081+
| ↳ `attendees` | array | List of attendees |
1082+
| ↳ `name` | string | Attendee name |
1083+
| ↳ `email` | string | Attendee email |
1084+
| ↳ `timeZone` | string | Attendee timezone |
1085+
| ↳ `language` | string | Attendee language preference |
10091086
| ↳ `videoCallData` | json | Video call details |
10101087

10111088

@@ -1036,6 +1113,17 @@ Trigger workflow when a meeting recording is ready for download
10361113
| ↳ `bookingId` | number | Numeric booking ID |
10371114
| ↳ `recordingUrl` | string | URL to download the recording |
10381115
| ↳ `transcription` | string | Meeting transcription text \(if available\) |
1116+
| ↳ `organizer` | object | Organizer details |
1117+
| ↳ `id` | number | Organizer user ID |
1118+
| ↳ `name` | string | Organizer name |
1119+
| ↳ `email` | string | Organizer email |
1120+
| ↳ `username` | string | Organizer username |
1121+
| ↳ `timeZone` | string | Organizer timezone |
1122+
| ↳ `attendees` | array | List of attendees |
1123+
| ↳ `name` | string | Attendee name |
1124+
| ↳ `email` | string | Attendee email |
1125+
| ↳ `timeZone` | string | Attendee timezone |
1126+
| ↳ `language` | string | Attendee language preference |
10391127

10401128

10411129
---

‎apps/docs/content/docs/en/integrations/calendly.mdx‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,14 @@ Trigger workflow when someone cancels a scheduled event on Calendly
324324
| ↳ `status` | string | Invitee status \(active or canceled\) |
325325
| ↳ `timezone` | string | Invitee timezone |
326326
| ↳ `event` | string | Scheduled event URI |
327+
| ↳ `questions_and_answers` | array | Questions and answers from the booking form |
328+
| ↳ `tracking` | object | tracking output from the tool |
329+
| ↳ `utm_campaign` | string | UTM campaign parameter |
330+
| ↳ `utm_source` | string | UTM source parameter |
331+
| ↳ `utm_medium` | string | UTM medium parameter |
332+
| ↳ `utm_content` | string | UTM content parameter |
333+
| ↳ `utm_term` | string | UTM term parameter |
334+
| ↳ `salesforce_uuid` | string | Salesforce UUID |
327335
| ↳ `text_reminder_number` | string | Phone number for text reminders |
328336
| ↳ `rescheduled` | boolean | Whether this invitee rescheduled |
329337
| ↳ `old_invitee` | string | URI of the old invitee \(if rescheduled\) |
@@ -379,6 +387,14 @@ Trigger workflow when someone schedules a new event on Calendly
379387
| ↳ `status` | string | Invitee status \(active or canceled\) |
380388
| ↳ `timezone` | string | Invitee timezone |
381389
| ↳ `event` | string | Scheduled event URI |
390+
| ↳ `questions_and_answers` | array | Questions and answers from the booking form |
391+
| ↳ `tracking` | object | tracking output from the tool |
392+
| ↳ `utm_campaign` | string | UTM campaign parameter |
393+
| ↳ `utm_source` | string | UTM source parameter |
394+
| ↳ `utm_medium` | string | UTM medium parameter |
395+
| ↳ `utm_content` | string | UTM content parameter |
396+
| ↳ `utm_term` | string | UTM term parameter |
397+
| ↳ `salesforce_uuid` | string | Salesforce UUID |
382398
| ↳ `text_reminder_number` | string | Phone number for text reminders |
383399
| ↳ `rescheduled` | boolean | Whether this invitee rescheduled |
384400
| ↳ `old_invitee` | string | URI of the old invitee \(if rescheduled\) |
@@ -433,6 +449,14 @@ Trigger workflow when someone submits a Calendly routing form
433449
| ↳ `email` | string | Submitter email address |
434450
| ↳ `name` | string | Submitter full name |
435451
| ↳ `submitter_type` | string | Type of submitter |
452+
| ↳ `questions_and_answers` | array | Questions and answers from the booking form |
453+
| ↳ `tracking` | object | tracking output from the tool |
454+
| ↳ `utm_campaign` | string | UTM campaign parameter |
455+
| ↳ `utm_source` | string | UTM source parameter |
456+
| ↳ `utm_medium` | string | UTM medium parameter |
457+
| ↳ `utm_content` | string | UTM content parameter |
458+
| ↳ `utm_term` | string | UTM term parameter |
459+
| ↳ `salesforce_uuid` | string | Salesforce UUID |
436460
| ↳ `result` | object | Routing result details |
437461
| ↳ `type` | string | Result type \(event_type, custom_message, or external_url\) |
438462
| ↳ `value` | string | Result value \(event type URI, message, or URL\) |

0 commit comments

Comments
 (0)