fix(files): address review — reserve on stale memo, clear dims on content swap

- onLoad guards on the memoized storedDimensions the render uses (not a fresh
  cache read), so a sibling's non-reactive backfill can't leave a view unreserved.
- updateWorkspaceFileContent clears width/height when it swaps bytes, so stale
  dimensions can't be reserved for new content (and the null re-enables backfill).
- Keep optimistically-cached dimensions when the PATCH fails (correct measurement;
  a 403/transient error shouldn't wipe sibling reservations).
- Test imports the sibling via the absolute @/ path.

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/image.tsx

@@ -134,10 +134,11 @@ function ResizableImageView({ node, updateAttributes, selected, editor }: ReactN
         setFailed(false)
         const { naturalWidth, naturalHeight } = event.currentTarget
         if (naturalWidth <= 0 || naturalHeight <= 0) return
-        // Already reserved from stored metadata (possibly just backfilled by a sibling view) — done.
-        if (source.getImageDimensions?.(attrs.src)) return
-        // Hold the box for this first-ever view, and persist so later views reserve before load. The
-        // report is idempotent and de-duped downstream (stored-check + server `width IS NULL`).
+        // Guard on the memoized `storedDimensions` the render actually uses — NOT a fresh cache read: the
+        // memo is non-reactive, so a fresh read could see a sibling's backfill the render hasn't picked up
+        // and skip measuring, leaving THIS view unreserved. When the render isn't reserving yet, hold the
+        // box locally and persist (the report is idempotent, de-duped downstream).
+        if (storedDimensions) return
         setMeasuredDimensions({ width: naturalWidth, height: naturalHeight })
         source.reportImageDimensions?.(attrs.src, { width: naturalWidth, height: naturalHeight })
       }}

apps/sim/hooks/queries/utils/find-workspace-file-by-src.test.ts

@@ -3,7 +3,7 @@
  */
 import { describe, expect, it } from 'vitest'
 import type { WorkspaceFileRecord } from '@/lib/uploads/contexts/workspace'
-import { findWorkspaceFileBySrc } from './find-workspace-file-by-src'
+import { findWorkspaceFileBySrc } from '@/hooks/queries/utils/find-workspace-file-by-src'
 
 function record(over: Partial<WorkspaceFileRecord>): WorkspaceFileRecord {
   return { id: 'wf_x', key: 'workspace/ws1/x.png', ...over } as WorkspaceFileRecord

apps/sim/hooks/queries/workspace-files.ts

@@ -151,17 +151,18 @@ export function useWorkspaceImageDimensionsAdapter(workspaceId: string): ImageDi
         const record = findRecord(src)
         // Skip when the file isn't ours to key (external/unlisted) or its dimensions are already stored.
         if (!record || (record.width != null && record.height != null)) return
-        const patch = (width: number | null, height: number | null) =>
-          queryClient.setQueryData<WorkspaceFileRecord[]>(listKey, (previous) =>
-            previous?.map((entry) => (entry.id === record.id ? { ...entry, width, height } : entry))
-          )
-        // Optimistically populate the cache so this and sibling views reserve space immediately and a
-        // concurrent measurement of the same file short-circuits above.
-        patch(dimensions.width, dimensions.height)
+        // Populate the cache so this and sibling views reserve space immediately and a concurrent
+        // measurement of the same file short-circuits above. Kept even if the PATCH fails (a 403 for a
+        // read-only member, or a transient error): the measurement is the real image size, correct
+        // regardless of whether the write landed, so siblings should still reserve from it — a later list
+        // refetch reconciles with the server.
+        queryClient.setQueryData<WorkspaceFileRecord[]>(listKey, (previous) =>
+          previous?.map((entry) => (entry.id === record.id ? { ...entry, ...dimensions } : entry))
+        )
         void requestJson(updateWorkspaceFileDimensionsContract, {
           params: { id: workspaceId, fileId: record.id },
           body: dimensions,
-        }).catch(() => patch(null, null))
+        }).catch(() => {})
       },
     }
   }, [queryClient, workspaceId])

apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts

@@ -1312,6 +1312,11 @@ export async function updateWorkspaceFileContent(
             key: uploadResult.key,
             size: content.length,
             contentType: nextContentType,
+            // Content is being replaced, so any stored intrinsic dimensions no longer describe it. Clear
+            // them (they re-backfill on next view via the `width IS NULL` path) so the editor never
+            // reserves a stale aspect ratio for the new bytes.
+            width: null,
+            height: null,
             updatedAt: now,
             contentUpdatedAt,
           })