chore(folders): drop the dead workflow-folder write helpers

createFolderRecord, updateFolderRecord and deleteFolderRecord in
lib/workflows/utils.ts had no production callers — the only references
were mock entries in @sim/testing that no test consumed. They were a
second, less safe implementation of folder writes (no lock check, no
audit) shadowing the real one in orchestration/folder-lifecycle.ts.

Removing them leaves folder-lifecycle.ts as the single orchestration
chokepoint and cuts the live workflow_folder write sites from 15 to 11.

Author: waleedlatif1

apps/sim/lib/workflows/utils.ts

@@ -3,7 +3,7 @@ import { workflowFolder, workflow as workflowTable } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { authorizeWorkflowByWorkspacePermission } from '@sim/platform-authz/workflow'
 import { generateId } from '@sim/utils/id'
-import { and, asc, eq, inArray, isNull, max, min, sql } from 'drizzle-orm'
+import { and, asc, eq, inArray, isNull, min, sql } from 'drizzle-orm'
 import { NextResponse } from 'next/server'
 import { getSession } from '@/lib/auth'
 import { ensureWorkflowAliasBacking } from '@/lib/copilot/vfs/workflow-alias-backing'
@@ -493,45 +493,6 @@ export interface CreateFolderInput {
   parentId?: string | null
 }
 
-export async function createFolderRecord(params: CreateFolderInput) {
-  const { userId, workspaceId, name, parentId = null } = params
-
-  const [maxResult] = await db
-    .select({ maxOrder: max(workflowFolder.sortOrder) })
-    .from(workflowFolder)
-    .where(
-      and(
-        eq(workflowFolder.workspaceId, workspaceId),
-        parentId ? eq(workflowFolder.parentId, parentId) : isNull(workflowFolder.parentId)
-      )
-    )
-  const sortOrder = (maxResult?.maxOrder ?? 0) + 1
-
-  const folderId = generateId()
-  await db.insert(workflowFolder).values({
-    id: folderId,
-    userId,
-    workspaceId,
-    parentId,
-    name,
-    sortOrder,
-    createdAt: new Date(),
-    updatedAt: new Date(),
-  })
-
-  return { folderId, name, workspaceId, parentId }
-}
-
-export async function updateFolderRecord(
-  folderId: string,
-  updates: { name?: string; parentId?: string | null }
-) {
-  const setData: Record<string, unknown> = { updatedAt: new Date() }
-  if (updates.name !== undefined) setData.name = updates.name
-  if (updates.parentId !== undefined) setData.parentId = updates.parentId
-  await db.update(workflowFolder).set(setData).where(eq(workflowFolder.id, folderId))
-}
-
 export async function verifyFolderWorkspace(
   folderId: string,
   workspaceId: string
@@ -544,34 +505,6 @@ export async function verifyFolderWorkspace(
   return Boolean(row)
 }
 
-export async function deleteFolderRecord(folderId: string): Promise<boolean> {
-  const [folder] = await db
-    .select({ parentId: workflowFolder.parentId })
-    .from(workflowFolder)
-    .where(eq(workflowFolder.id, folderId))
-    .limit(1)
-
-  if (!folder) return false
-
-  await db
-    .update(workflowTable)
-    .set({ folderId: folder.parentId, updatedAt: new Date() })
-    .where(eq(workflowTable.folderId, folderId))
-
-  await db
-    .update(workflowFolder)
-    .set({ parentId: folder.parentId, updatedAt: new Date() })
-    .where(eq(workflowFolder.parentId, folderId))
-
-  await db.delete(workflowFolder).where(eq(workflowFolder.id, folderId))
-
-  return true
-}
-
-/**
- * Checks whether setting `parentId` as the parent of `folderId` would
- * create a circular reference in the folder tree.
- */
 export async function checkForCircularReference(
   folderId: string,
   parentId: string

packages/testing/src/mocks/workflows-utils.mock.ts

@@ -24,9 +24,6 @@ export const workflowsUtilsMockFns = {
   mockUpdateWorkflowRecord: vi.fn(),
   mockDeleteWorkflowRecord: vi.fn(),
   mockSetWorkflowVariables: vi.fn(),
-  mockCreateFolderRecord: vi.fn(),
-  mockUpdateFolderRecord: vi.fn(),
-  mockDeleteFolderRecord: vi.fn(),
   mockCheckForCircularReference: vi.fn(),
   mockListFolders: vi.fn(),
 }
@@ -61,9 +58,6 @@ export const workflowsUtilsMock = {
   updateWorkflowRecord: workflowsUtilsMockFns.mockUpdateWorkflowRecord,
   deleteWorkflowRecord: workflowsUtilsMockFns.mockDeleteWorkflowRecord,
   setWorkflowVariables: workflowsUtilsMockFns.mockSetWorkflowVariables,
-  createFolderRecord: workflowsUtilsMockFns.mockCreateFolderRecord,
-  updateFolderRecord: workflowsUtilsMockFns.mockUpdateFolderRecord,
-  deleteFolderRecord: workflowsUtilsMockFns.mockDeleteFolderRecord,
   checkForCircularReference: workflowsUtilsMockFns.mockCheckForCircularReference,
   listFolders: workflowsUtilsMockFns.mockListFolders,
 }