Commit 37519d4
committed
refactor(resources): take the last cross-tree edges out of the canonical units
`components/resources/**` no longer imports from `app/workspace/[workspaceId]/**`
at all. Three edges remained after the table migration, all in the file view's
collaboration layer, and both targets were already shared across trees rather
than route-specific:
- `presence-avatars` -> `components/presence/`. Its own doc said "shared by
workflow and files"; it had five consumers across three trees and imports
nothing workspace-specific.
- `untitled-title` -> `lib/uploads/utils/`. Pure string helpers over a file name,
imported by the files page and the markdown editor.
Both are pure `git mv` — the diff is three renames with zero content change, and
every consumer moved to the new specifier.
R3b drops 41 -> 38. The remainder is not this branch's: it is `ee/**` and
`components/settings/**` importing the shared settings chrome that lives under
`app/workspace/[workspaceId]/settings/components`. 30 of those predate this
branch and 8 arrived with the staging merge. Relocating that chrome is a real
change to a dozen EE surfaces and belongs in its own PR — but no canonical
resource view depends on it any more, which was the point of the rule.1 parent f89a6f5 commit 37519d4
11 files changed
Lines changed: 13 additions & 12 deletions
File tree
- apps/sim
- app/workspace/[workspaceId]
- files
- tables/[tableId]
- hooks
- w/components/sidebar/components/workflow-list/components/workflow-item/avatars
- components
- presence
- resources/file-view/components/rich-markdown-editor
- collaboration
- lib/uploads/utils
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
53 | 59 | | |
54 | 60 | | |
55 | 61 | | |
| |||
94 | 100 | | |
95 | 101 | | |
96 | 102 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
36 | | - | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
0 commit comments