fix(quickbooks): correct document schemas and upload bytes

Author: Bill Leoutsakos

apps/sim/app/api/tools/quickbooks/add-attachment/route.ts

@@ -120,7 +120,16 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
       )
       formData.append(
         'file_content_01',
-        new Blob([new Uint8Array(downloaded.buffer)], { type: mimeType }),
+        new Blob(
+          [
+            new Uint8Array(
+              downloaded.buffer.buffer as ArrayBuffer,
+              downloaded.buffer.byteOffset,
+              downloaded.buffer.byteLength
+            ),
+          ],
+          { type: mimeType }
+        ),
         resolvedName
       )
       request.signal.throwIfAborted()

apps/sim/app/api/tools/quickbooks/documents.test.ts

@@ -269,6 +269,34 @@ describe('QuickBooks document API routes', () => {
     expect(mockFetch).toHaveBeenCalledTimes(1)
   })
 
+  it('uploads only the visible bytes from a sliced storage buffer', async () => {
+    const backing = Buffer.from('before-visible-after')
+    const visible = backing.subarray('before-'.length, 'before-visible'.length)
+    mockDownloadServableFileFromStorage.mockResolvedValueOnce({
+      buffer: visible,
+      contentType: 'application/pdf',
+    })
+    mockFetch.mockResolvedValueOnce(
+      Response.json({ AttachableResponse: [{ Attachable: { Id: '11' } }] })
+    )
+
+    const response = await addAttachment(
+      createMockRequest('POST', {
+        ...auth,
+        attachmentKind: 'file',
+        targetType: 'bill',
+        targetId: '88',
+        file: attachmentFile,
+      })
+    )
+
+    expect(response.status).toBe(200)
+    expect(mockFetch).toHaveBeenCalledTimes(1)
+    const formData = mockFetch.mock.calls[0][1].body as FormData
+    const filePart = formData.get('file_content_01') as Blob
+    expect(Buffer.from(await filePart.arrayBuffer()).toString()).toBe('visible')
+  })
+
   it('rejects an unauthorized workspace file before storage or Intuit access', async () => {
     mockAssertToolFileAccess.mockResolvedValueOnce(
       Response.json({ success: false, error: 'Forbidden' }, { status: 403 })

apps/sim/tools/quickbooks/documents.test.ts

@@ -18,6 +18,7 @@ import type {
   QuickBooksEmailTransactionParams,
   QuickBooksReadAttachmentsParams,
 } from '@/tools/quickbooks/types'
+import { QUICKBOOKS_EMAILABLE_TRANSACTION_PROPERTIES } from '@/tools/quickbooks/types'
 
 const auth = { accessToken: 'access-token', realmId: '123456789' }
 
@@ -88,6 +89,31 @@ describe('QuickBooks document tools', () => {
       },
     })
   })
+
+  it('advertises one optional sales and purchasing transaction output superset', () => {
+    const record = quickbooksEmailTransactionTool.outputs?.record
+    expect(record?.properties).toBe(QUICKBOOKS_EMAILABLE_TRANSACTION_PROPERTIES)
+    expect(record?.properties).toMatchObject({
+      CustomerRef: { optional: true },
+      ExpirationDate: { optional: true },
+      VendorRef: { optional: true },
+      APAccountRef: { optional: true },
+      POStatus: { optional: true },
+      LinkedTxn: { optional: true },
+    })
+    expect(record?.properties?.Line).toMatchObject({
+      optional: true,
+      items: {
+        properties: {
+          SalesItemLineDetail: { optional: true },
+          AccountBasedExpenseLineDetail: { optional: true },
+          ItemBasedExpenseLineDetail: { optional: true },
+        },
+      },
+    })
+    expect(record?.properties?.Id.optional).not.toBe(true)
+    expect(record?.properties?.CustomerRef.optional).toBe(true)
+  })
 })
 
 describe('QuickBooks attachment metadata reads', () => {

apps/sim/tools/quickbooks/email_transaction.ts

@@ -13,7 +13,7 @@ import type {
   QuickBooksEmailTransactionResponse,
   QuickBooksTransaction,
 } from '@/tools/quickbooks/types'
-import { QUICKBOOKS_SALES_TRANSACTION_PROPERTIES } from '@/tools/quickbooks/types'
+import { QUICKBOOKS_EMAILABLE_TRANSACTION_PROPERTIES } from '@/tools/quickbooks/types'
 import { parseQuickBooksJson, requiredQuickBooksString } from '@/tools/quickbooks/utils'
 import type { ToolConfig } from '@/tools/types'
 
@@ -123,7 +123,7 @@ export const quickbooksEmailTransactionTool: ToolConfig<
       type: 'json',
       description: 'Native QuickBooks transaction returned after sending',
       optional: true,
-      properties: QUICKBOOKS_SALES_TRANSACTION_PROPERTIES,
+      properties: QUICKBOOKS_EMAILABLE_TRANSACTION_PROPERTIES,
     },
     time: {
       type: 'string',

apps/sim/tools/quickbooks/types.ts

@@ -1753,6 +1753,35 @@ export const QUICKBOOKS_PURCHASING_TRANSACTION_PROPERTIES: Record<string, Output
   },
 }
 
+export const QUICKBOOKS_EMAILABLE_TRANSACTION_PROPERTIES: Record<string, OutputProperty> = {
+  ...QUICKBOOKS_SALES_TRANSACTION_PROPERTIES,
+  ...QUICKBOOKS_PURCHASING_TRANSACTION_PROPERTIES,
+  Id: { type: 'string', description: 'QuickBooks transaction ID' },
+  DueDate: { type: 'string', description: 'Transaction due date', optional: true },
+  POStatus: { type: 'string', description: 'Purchase order status', optional: true },
+  Line: {
+    type: 'array',
+    description: 'Native QuickBooks sales or purchasing transaction lines',
+    optional: true,
+    items: {
+      type: 'json',
+      properties: {
+        ...QUICKBOOKS_PURCHASING_LINE_PROPERTIES,
+        SalesItemLineDetail: {
+          type: 'json',
+          description: 'Native QuickBooks sales item line details',
+          optional: true,
+        },
+        DescriptionLineDetail: {
+          type: 'json',
+          description: 'Native QuickBooks description line details',
+          optional: true,
+        },
+      },
+    },
+  },
+}
+
 export const QUICKBOOKS_ACCOUNTING_TRANSACTION_PROPERTIES: Record<string, OutputProperty> = {
   Id: { type: 'string', description: 'QuickBooks accounting transaction ID' },
   SyncToken: { type: 'string', description: 'Current transaction sync token', optional: true },