fix(admin): prevent duplicate user creation

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/settings/components/admin/add-user-modal.test.tsx

@@ -206,12 +206,25 @@ describe('AddUserModal', () => {
         password: 'canary-password',
         emailVerified: true,
       },
-      { onSuccess: expect.any(Function) }
+      { onSuccess: expect.any(Function), onSettled: expect.any(Function) }
     )
     expect(onOpenChange).toHaveBeenCalledWith(false)
     expect(onCreated).toHaveBeenCalledWith(CREATED_USER)
   })
 
+  it('ignores repeated submissions before the pending state renders', async () => {
+    await renderModal()
+    await fillRequiredFields()
+
+    await act(async () => {
+      const addUserButton = buttonLabelled('Add user')
+      addUserButton.dispatchEvent(new MouseEvent('click', { bubbles: true }))
+      addUserButton.dispatchEvent(new MouseEvent('click', { bubbles: true }))
+    })
+
+    expect(mockMutate).toHaveBeenCalledTimes(1)
+  })
+
   it('supports unverified accounts without exposing a platform-role control', async () => {
     mockMutate.mockImplementation(
       (_input: AddUserInput, options: { onSuccess: (user: AdminUser) => void }) => {
@@ -231,6 +244,7 @@ describe('AddUserModal', () => {
     expect(container.querySelector('[aria-label="Platform role"]')).toBeNull()
     expect(mockMutate).toHaveBeenCalledWith(expect.objectContaining({ emailVerified: false }), {
       onSuccess: expect.any(Function),
+      onSettled: expect.any(Function),
     })
   })
 

apps/sim/app/workspace/[workspaceId]/settings/components/admin/add-user-modal.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import { useState } from 'react'
+import { useRef, useState } from 'react'
 import {
   ChipModal,
   ChipModalBody,
@@ -26,6 +26,7 @@ interface AddUserModalProps {
 
 export function AddUserModal({ open, onOpenChange, onCreated }: AddUserModalProps) {
   const addUser = useAddUser()
+  const submissionInFlightRef = useRef(false)
   const [name, setName] = useState('')
   const [email, setEmail] = useState('')
   const [password, setPassword] = useState('')
@@ -55,13 +56,14 @@ export function AddUserModal({ open, onOpenChange, onCreated }: AddUserModalProp
   }
 
   const handleClose = () => {
-    if (addUser.isPending) return
+    if (submissionInFlightRef.current || addUser.isPending) return
     reset()
     onOpenChange(false)
   }
 
   const handleAddUser = () => {
-    if (!canSubmit) return
+    if (!canSubmit || submissionInFlightRef.current) return
+    submissionInFlightRef.current = true
     addUser.reset()
     addUser.mutate(
       {
@@ -76,6 +78,9 @@ export function AddUserModal({ open, onOpenChange, onCreated }: AddUserModalProp
           onOpenChange(false)
           onCreated(user)
         },
+        onSettled: () => {
+          submissionInFlightRef.current = false
+        },
       }
     )
   }