fix(tables): make the retype gate and the write path share one parser

A simplify pass over the registry found two real defects and several places
the abstraction was being worked around.

Silent data loss on conversion. `isCompatibleWith` was hand-written per type
and had already drifted from `coerce`, despite the interface promising they
could not: `boolean` accepted '1'/'0'/0/1 in the gate but only 'true'/'false'
in the write path, so converting a column holding "1" reported zero
incompatible rows and then nulled every one of them. `date` drifted the other
way. `isCompatibleWith` is now optional and defaults to `coerce(...).ok`, so
the two are the same code; only `select` overrides, because its rules are
about the column (cleared-vs-required, cardinality) not the value.

`isColumnType` used `in`, which matches inherited keys — `isColumnType('toString')`
was true and `columnTypeById('toString')` returned `Function.prototype.toString`,
which the validator would then call `.validateDefinition()` on. Now `Object.hasOwn`.

`defaultMetadata` only ran on the currency arm of a retype, so a future type
would get its defaults on create but silently not on conversion. It now runs
for every non-select target, carrying forward only metadata the TARGET type
declares it owns — a currency→text conversion no longer strands a currencyCode.

The index doc claimed the registry is kept out of the `@/lib/table` barrel so
44 server modules don't pull `@sim/emcn/icons`. That was false: `constants.ts`
re-exported `COLUMN_TYPES` from the icon-carrying `registry.ts`, and the barrel
re-exports `constants`. `COLUMN_TYPES` now lives in the icon-free `types.ts`;
verified with an import tracer that both are icon-free again.

Also: 5 no-op `validateDefinition`s and 4 duplicated formatters collapsed into
registry defaults; `CURRENCY_OPTIONS` was an eager module-load IIFE costing
~8ms of ICU work on every table API route for a list only the config sidebar
reads, now built on first call; and the skill's validation grep claimed 'should
return nothing' when it returns 8 legitimate hits — it now explains how to tell
a leak from a genuine special case.

Author: waleedlatif1

.agents/skills/add-column-type/SKILL.md

@@ -129,7 +129,7 @@ Prefer set-based SQL. When the transform genuinely needs JS (`currency`'s separa
 ## Final Validation (Required)
 
 1. **`cd apps/sim && bunx tsc --noEmit -p tsconfig.json`** — must be clean. If any file *outside* `column-types/` errors, that file has a hardcoded type list; fix it to read the registry.
-2. **Grep for leaks** — `grep -rn "=== '{id}'" apps/sim --include='*.ts' --include='*.tsx' | grep -v column-types/` should return nothing but genuine JSX/behavioral dispatch.
+2. **Grep for leaks** — `grep -rn "=== '{id}'" apps/sim --include='*.ts' --include='*.tsx' | grep -v column-types/`. Hits are expected; judge each. A hit is fine when it mounts a specific React component or encodes a genuinely one-off behavior (`json`'s mono textarea, `date`'s timezone-aware parsing). A hit is a **leak** when it restates something the registry could answer — an icon, a label, a colour, an operator set, a cast, a coercion. Leaks get a registry field, not a new branch.
 3. **Run the suite** — `bunx vitest run lib/table 'app/workspace/[workspaceId]/tables' lib/api app/api/table app/api/v1 lib/copilot/tools/server/table`. Existing tests must pass **unchanged**; needing to edit one means you changed behavior for the other types.
 4. **`bun run lint:check`, `bun run check:api-validation`, `bun run check:client-boundary`** from the repo root.
 5. **Exercise it in the running app** on a table with one column of every type: create, edit inline / in the expanded popover / in the row modal, paste from a spreadsheet, filter, sort, convert to and from other types, export CSV, undo a column delete.

.claude/commands/add-column-type.md

@@ -128,7 +128,7 @@ Prefer set-based SQL. When the transform genuinely needs JS (`currency`'s separa
 ## Final Validation (Required)
 
 1. **`cd apps/sim && bunx tsc --noEmit -p tsconfig.json`** — must be clean. If any file *outside* `column-types/` errors, that file has a hardcoded type list; fix it to read the registry.
-2. **Grep for leaks** — `grep -rn "=== '{id}'" apps/sim --include='*.ts' --include='*.tsx' | grep -v column-types/` should return nothing but genuine JSX/behavioral dispatch.
+2. **Grep for leaks** — `grep -rn "=== '{id}'" apps/sim --include='*.ts' --include='*.tsx' | grep -v column-types/`. Hits are expected; judge each. A hit is fine when it mounts a specific React component or encodes a genuinely one-off behavior (`json`'s mono textarea, `date`'s timezone-aware parsing). A hit is a **leak** when it restates something the registry could answer — an icon, a label, a colour, an operator set, a cast, a coercion. Leaks get a registry field, not a new branch.
 3. **Run the suite** — `bunx vitest run lib/table 'app/workspace/[workspaceId]/tables' lib/api app/api/table app/api/v1 lib/copilot/tools/server/table`. Existing tests must pass **unchanged**; needing to edit one means you changed behavior for the other types.
 4. **`bun run lint:check`, `bun run check:api-validation`, `bun run check:client-boundary`** from the repo root.
 5. **Exercise it in the running app** on a table with one column of every type: create, edit inline / in the expanded popover / in the row modal, paste from a spreadsheet, filter, sort, convert to and from other types, export CSV, undo a column delete.

.cursor/commands/add-column-type.md

@@ -123,7 +123,7 @@ Prefer set-based SQL. When the transform genuinely needs JS (`currency`'s separa
 ## Final Validation (Required)
 
 1. **`cd apps/sim && bunx tsc --noEmit -p tsconfig.json`** — must be clean. If any file *outside* `column-types/` errors, that file has a hardcoded type list; fix it to read the registry.
-2. **Grep for leaks** — `grep -rn "=== '{id}'" apps/sim --include='*.ts' --include='*.tsx' | grep -v column-types/` should return nothing but genuine JSX/behavioral dispatch.
+2. **Grep for leaks** — `grep -rn "=== '{id}'" apps/sim --include='*.ts' --include='*.tsx' | grep -v column-types/`. Hits are expected; judge each. A hit is fine when it mounts a specific React component or encodes a genuinely one-off behavior (`json`'s mono textarea, `date`'s timezone-aware parsing). A hit is a **leak** when it restates something the registry could answer — an icon, a label, a colour, an operator set, a cast, a coercion. Leaks get a registry field, not a new branch.
 3. **Run the suite** — `bunx vitest run lib/table 'app/workspace/[workspaceId]/tables' lib/api app/api/table app/api/v1 lib/copilot/tools/server/table`. Existing tests must pass **unchanged**; needing to edit one means you changed behavior for the other types.
 4. **`bun run lint:check`, `bun run check:api-validation`, `bun run check:client-boundary`** from the repo root.
 5. **Exercise it in the running app** on a table with one column of every type: create, edit inline / in the expanded popover / in the row modal, paste from a spreadsheet, filter, sort, convert to and from other types, export CSV, undo a column delete.

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-config-sidebar/column-config-sidebar.tsx

@@ -6,7 +6,11 @@ import { X } from '@sim/emcn/icons'
 import { toError } from '@sim/utils/errors'
 import { findValidationIssue, isValidationError } from '@/lib/api/client/errors'
 import type { ColumnDefinition, SelectOption } from '@/lib/table'
-import { CURRENCY_OPTIONS, DEFAULT_CURRENCY_CODE, resolveCurrencyCode } from '@/lib/table/currency'
+import {
+  DEFAULT_CURRENCY_CODE,
+  getCurrencyOptions,
+  resolveCurrencyCode,
+} from '@/lib/table/currency'
 import {
   FieldError,
   RequiredLabel,
@@ -24,7 +28,7 @@ function isSelectType(type: ColumnDefinition['type']): boolean {
  * Picker entries, built once at module load: the option list is derived from the
  * runtime's currency data and never varies per column.
  */
-const CURRENCY_COMBOBOX_OPTIONS = CURRENCY_OPTIONS.map((c) => ({
+const CURRENCY_COMBOBOX_OPTIONS = getCurrencyOptions().map((c) => ({
   value: c.code,
   label: `${c.code} · ${c.name}`,
 }))

apps/sim/lib/table/__tests__/currency.test.ts

@@ -7,10 +7,10 @@
  */
 import { describe, expect, it } from 'vitest'
 import {
-  CURRENCY_OPTIONS,
   DEFAULT_CURRENCY_CODE,
   formatCurrencyDisplay,
   formatCurrencyForInput,
+  getCurrencyOptions,
   isSupportedCurrencyCode,
   parseCurrencyInput,
   resolveCurrencyCode,
@@ -163,8 +163,9 @@ describe('currency codes', () => {
   })
 
   it('offers the pinned codes first and no duplicates', () => {
-    expect(CURRENCY_OPTIONS[0].code).toBe('USD')
-    const codes = CURRENCY_OPTIONS.map((c) => c.code)
+    const options = getCurrencyOptions()
+    expect(options[0].code).toBe('USD')
+    const codes = options.map((c) => c.code)
     expect(new Set(codes).size).toBe(codes.length)
     expect(codes).toContain('JPY')
   })

apps/sim/lib/table/column-types/boolean.ts

@@ -31,17 +31,6 @@ export const booleanColumnType: ColumnTypeDefinition = {
     return typeof value === 'boolean' ? null : `${column.name} must be boolean`
   },
 
-  validateDefinition() {
-    return []
-  },
-
-  isCompatibleWith(value) {
-    if (typeof value === 'boolean') return true
-    if (typeof value === 'string') return ['true', 'false', '1', '0'].includes(value.toLowerCase())
-    if (typeof value === 'number') return value === 0 || value === 1
-    return false
-  },
-
   formatForDisplay(value) {
     return String(value)
   },

apps/sim/lib/table/column-types/currency.ts

@@ -52,13 +52,6 @@ export const currencyColumnType: ColumnTypeDefinition = {
     return []
   },
 
-  isCompatibleWith(value) {
-    // Read the value exactly as the write-path coercion will: a formatted
-    // amount left in a text column (`$1,234.56`) converts, arbitrary prose
-    // does not.
-    return parseCurrencyInput(value) !== null
-  },
-
   formatForDisplay(value, column) {
     return formatCurrencyDisplay(value, column.currencyCode)
   },

apps/sim/lib/table/column-types/date.ts

@@ -42,16 +42,6 @@ export const dateColumnType: ColumnTypeDefinition = {
     return valid ? null : `${column.name} must be valid date`
   },
 
-  validateDefinition() {
-    return []
-  },
-
-  isCompatibleWith(value) {
-    if (value instanceof Date) return !Number.isNaN(value.getTime())
-    if (typeof value === 'string') return !Number.isNaN(Date.parse(value))
-    return false
-  },
-
   formatForDisplay(value) {
     return formatDateCellDisplay(String(value), { seconds: true })
   },

apps/sim/lib/table/column-types/json.ts

@@ -29,14 +29,6 @@ export const jsonColumnType: ColumnTypeDefinition = {
     }
   },
 
-  validateDefinition() {
-    return []
-  },
-
-  isCompatibleWith() {
-    return true
-  },
-
   formatForDisplay(value) {
     return JSON.stringify(value)
   },

apps/sim/lib/table/column-types/number.ts

@@ -35,19 +35,6 @@ export const numberColumnType: ColumnTypeDefinition = {
       : `${column.name} must be number`
   },
 
-  validateDefinition() {
-    return []
-  },
-
-  isCompatibleWith(value) {
-    if (typeof value === 'number') return Number.isFinite(value)
-    if (typeof value === 'string') {
-      const num = Number(value)
-      return Number.isFinite(num) && value.trim() !== ''
-    }
-    return false
-  },
-
   formatForDisplay(value) {
     return String(value)
   },