Commit 4e66399
committed
feat(tables): give the table view source/grants/host and delete the module fork
`TableView({ source, grants, host })` joins `FileView` and `InterfaceView` as a
canonical resource view, registered in `CANONICAL_UNITS` so R1a/R2/R4/R6 now
police it. `table` moves from "no canonical view yet" to a real one.
The interfaces table module stops re-implementing a table. It had grown its own
451-line renderer — cell resolver, favicon-link builder, offset pagination — and
that fork is now three files lighter: mint a table source from the surrounding
interface source, mount the view. 163 lines become 74.
What the module gains by not being a fork: every cell kind the grid draws.
Booleans, dates, JSON, links, pinned columns, select pills, and workflow-output
state now render identically in a module and in the grid, because they are the
same component rather than an approximation of it.
The share arm is addressed by `(token, grantId)` and carries no table id at all
— the server derives it from the stored layout per request. `workspaceId` is
threaded from the source and is `undefined` there, which is what keeps the
`sim-resource` chip (and the four workspace-authenticated queries its renderer
mounts) off a public page. `cells/cell-render.test.ts` is what holds that.
Two things this deliberately does NOT do:
- It does not touch the tables page or the mothership panel. Both still mount
the full editing shell. Making the panel read-only is a product decision about
whether you can edit a table from chat, not a refactor, and it does not belong
in a change whose value is deleting a fork.
- It does not unify the row page size. The page drains 1000 for client-side sort
and filter; this view takes 100. `pageSize` is in the query key, so they do not
share row cache — which the code now says plainly instead of claiming
otherwise. Fixing it changes behaviour on one surface or the other.
Caught while doing it: `CellRender` returns `null` for an empty cell because the
grid's virtualizer owns row height. A panel has nothing holding the row open, so
an all-empty row collapsed. The floor lives on a wrapper in this view rather than
in `CellRender`, so the grid is untouched. A pre-existing test caught it.1 parent 10d661a commit 4e66399
9 files changed
Lines changed: 312 additions & 333 deletions
File tree
- apps/sim
- components/resources
- interface-view/components/module-renderer/components/table-module
- components/table-cell-value
- table-view
- hooks
- resources
- scripts
Lines changed: 0 additions & 2 deletions
This file was deleted.
Lines changed: 0 additions & 157 deletions
This file was deleted.
Lines changed: 34 additions & 123 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
| 6 | + | |
8 | 7 | | |
9 | 8 | | |
| 9 | + | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
| 11 | + | |
18 | 12 | | |
19 | 13 | | |
20 | 14 | | |
| |||
28 | 22 | | |
29 | 23 | | |
30 | 24 | | |
31 | | - | |
| 25 | + | |
32 | 26 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
38 | 32 | | |
39 | | - | |
40 | | - | |
41 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
42 | 36 | | |
43 | 37 | | |
44 | 38 | | |
45 | 39 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | 40 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 41 | + | |
| 42 | + | |
69 | 43 | | |
70 | | - | |
71 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
72 | 62 | | |
73 | 63 | | |
74 | 64 | | |
| |||
80 | 70 | | |
81 | 71 | | |
82 | 72 | | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
| 73 | + | |
163 | 74 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
9 | 8 | | |
10 | | - | |
11 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
| |||
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
21 | | - | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
56 | 58 | | |
57 | 59 | | |
58 | 60 | | |
59 | | - | |
60 | | - | |
| 61 | + | |
| 62 | + | |
61 | 63 | | |
62 | 64 | | |
63 | 65 | | |
| |||
0 commit comments