fix(mship): fix image handling (#6357)

Author: Sg312

apps/sim/lib/copilot/chat/payload.test.ts

@@ -374,19 +374,46 @@ describe('buildCopilotRequestPayload', () => {
       ])
     })
 
-    it('fails the request when an authorized attachment cannot be prepared', async () => {
+    it('isolates a failed attachment and still prepares valid siblings', async () => {
       const cause = new Error('provenance sidecar unavailable')
-      mockTrackChatUpload.mockRejectedValueOnce(cause)
-
-      await expect(
-        buildCopilotRequestPayload(
-          { ...attachmentParams, userPermission: 'write' },
-          { selectedModel: 'claude-opus-4-8' }
-        )
-      ).rejects.toMatchObject({
-        message: 'Failed to prepare attached file "payroll.xlsx" for Copilot. Please try again.',
-        cause,
-      })
+      mockTrackChatUpload
+        .mockRejectedValueOnce(cause)
+        .mockResolvedValueOnce({ displayName: 'photo.png' })
+
+      const payload = await buildCopilotRequestPayload(
+        {
+          ...attachmentParams,
+          userPermission: 'write',
+          fileAttachments: [
+            ...attachmentParams.fileAttachments,
+            {
+              id: 'a2',
+              key: 'workspace/ws-1/1731000000001-ab12cd35-photo.png',
+              filename: 'photo.png',
+              media_type: 'image/png',
+              size: 10,
+            },
+          ],
+        },
+        { selectedModel: 'claude-opus-4-8' }
+      )
+
+      expect(mockTrackChatUpload).toHaveBeenCalledTimes(2)
+      expect(payload.context).toEqual([
+        {
+          type: 'uploaded_file',
+          content:
+            'File "payroll.xlsx" could not be prepared for Copilot and was omitted. Other attached files remain available.',
+        },
+        {
+          type: 'uploaded_file',
+          content: [
+            'File "photo.png" (image/png, 10 bytes) uploaded.',
+            'Read with: read("uploads/photo.png")',
+            'To save permanently: materialize_file(fileName: "photo.png")',
+          ].join('\n'),
+        },
+      ])
     })
   })
 

apps/sim/lib/copilot/chat/payload.ts

@@ -401,10 +401,14 @@ export async function buildCopilotRequestPayload(
           chatId,
           error: cause.message,
         })
-        throw new Error(
-          `Failed to prepare attached file "${filename}" for Copilot. Please try again.`,
-          { cause }
-        )
+        // Isolate failures by entry. Aborting here discarded every valid
+        // sibling attachment in the request, even ones already tracked. Give
+        // the model a local marker for this file and continue preparing the
+        // rest of the batch.
+        uploadContexts.push({
+          type: 'uploaded_file',
+          content: `File "${filename}" could not be prepared for Copilot and was omitted. Other attached files remain available.`,
+        })
       }
     }
   }