fix(cli): review round 4 — repeated flags encode per field kind

`coerce` comma-joined every `list` flag, but that is only correct for the three
fields whose wire type is a `string` the route splits (`workflowIds`,
`folderIds`, `triggers`). The others genuinely want an array:

- `rowIds` and `selectedOutputs` are `array`, so joining sent a string where the
  schema expects a list — `sim tables rows batch-delete --row a b` failed
  validation, and so did a single `--row a`
- `knowledgeBaseIds` is a string-or-array union whose array branch is the right
  one; joining made `kb_1,kb_2` a single bogus id, so multi-`--kb` search
  silently searched nothing

`list` now means only "accept the flag more than once" — the encoding follows
the field's kind, which the generator already records. The two questions were
conflated under one contract field and the `FlagSpec` doc now says so.

Four tests, three of which fail against the previous code.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EsThUPqZXjwuuyRjBbmVkj

Author: TheodoreSpeaks

packages/sim-cli/src/contract/types.ts

@@ -30,9 +30,16 @@ export interface FlagSpec {
   /** Short alias, e.g. `w` for `--workspace`. */
   short?: string
   /**
-   * Accept a repeated flag and send it comma-joined. For fields the schema
-   * types as `string` but the route splits — invisible to any type-driven
-   * generator, so it has to be stated.
+   * Accept the flag more than once.
+   *
+   * Only says that several values are allowed — how they reach the wire is
+   * decided by the field's kind, not here. A `string` field is one the route
+   * splits on commas (`workflowIds`), so the values are joined; anything else
+   * genuinely wants an array (`rowIds`, `knowledgeBaseIds`). Conflating the two
+   * turned multi-value `--kb` and `--row` into a single bogus value.
+   *
+   * Still needed on the string case because "this string is really a list" is
+   * invisible to any type-driven generator.
    */
   list?: boolean
   /** Take a JSON string. Implied for object/array/unknown fields. */

packages/sim-cli/src/runtime/request.test.ts

@@ -110,3 +110,33 @@ describe('deriveCommandPath', () => {
     expect(deriveCommandPath('searchKnowledge')).toEqual(['knowledge', 'search'])
   })
 })
+
+describe('repeated flags encode per the field kind, not uniformly', () => {
+  it('joins a string field the route splits', () => {
+    const built = buildRequest('listLogs', [], { workflow: ['wf_1', 'wf_2'] }, WORKSPACE)
+    expect(built.query.workflowIds).toBe('wf_1,wf_2')
+  })
+
+  it('keeps an array field as an array', () => {
+    // Joining these produced a string where the wire wants an array, so
+    // `--row a b` failed validation — and so did a single `--row a`.
+    const built = buildRequest('deleteTableRows', ['tbl_1'], { row: ['r1', 'r2'] }, WORKSPACE)
+    expect(built.body?.rowIds).toEqual(['r1', 'r2'])
+  })
+
+  it('keeps a single repeated value as a one-element array, not a bare string', () => {
+    const built = buildRequest('deleteTableRows', ['tbl_1'], { row: ['r1'] }, WORKSPACE)
+    expect(built.body?.rowIds).toEqual(['r1'])
+  })
+
+  it('sends the array branch of a string-or-array union', () => {
+    // `knowledgeBaseIds` accepts either; joining made "kb_1,kb_2" a single id.
+    const built = buildRequest(
+      'searchKnowledge',
+      [],
+      { kb: ['kb_1', 'kb_2'], query: 'refunds' },
+      WORKSPACE
+    )
+    expect(built.body?.knowledgeBaseIds).toEqual(['kb_1', 'kb_2'])
+  })
+})

packages/sim-cli/src/runtime/request.ts

@@ -47,11 +47,21 @@ export function takesJson(field: FieldSpec, flag: FlagSpec): boolean {
 export function coerce(raw: unknown, field: FieldSpec, flag: FlagSpec, flagName: string): unknown {
   if (raw === undefined) return undefined
 
-  // A repeated flag whose wire form is one comma-joined string. The schema
-  // types these as `string`, so only the contract knows.
+  /**
+   * A repeated flag. `list` says the CLI accepts several values; the *wire*
+   * encoding follows the field's own kind, because the two are not the same
+   * question:
+   *
+   * - `string` — the route splits on commas (`workflowIds`, `folderIds`,
+   *   `triggers`), so the values are joined.
+   * - anything else — the wire genuinely wants an array (`rowIds`,
+   *   `selectedOutputs`) or a string-or-array union whose array branch is the
+   *   right one (`knowledgeBaseIds`). Joining those produced a single bogus id
+   *   or failed validation outright.
+   */
   if (flag.list) {
     const values = Array.isArray(raw) ? raw : [raw]
-    return values.join(',')
+    return field.kind === 'string' ? values.join(',') : values
   }
 
   if (takesJson(field, flag)) {