fix(api): make table import completion retries idempotent

Author: TheodoreSpeaks

apps/sim/app/api/table/imports/[importId]/complete/route.ts

@@ -4,6 +4,7 @@ import { parseRequest } from '@/lib/api/server'
 import { checkSessionOrInternalAuth } from '@/lib/auth/hybrid'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
 import {
+  findOwnedTableImport,
   getOwnedTableImportUpload,
   startUploadedTableImport,
   toV2TableImport,
@@ -29,6 +30,12 @@ export const POST = withRouteHandler(async (request: NextRequest, context: Impor
       userId: auth.userId,
       uploadToken: parsed.data.headers['upload-token'],
     })
+    const existing = await findOwnedTableImport({
+      importId: upload.id,
+      workspaceId: upload.workspaceId,
+      userId: upload.userId,
+    })
+    if (existing) return NextResponse.json({ data: toV2TableImport(existing) })
     const completed = await completeUploadSession({
       session: upload,
       parts: parsed.data.body.parts,

apps/sim/app/api/v2/tables/imports/[importId]/complete/route.test.ts

@@ -0,0 +1,115 @@
+/**
+ * @vitest-environment node
+ */
+import { NextRequest } from 'next/server'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+const {
+  mockCheckRateLimit,
+  mockResolveWorkspaceScope,
+  mockGetOwnedTableImportUpload,
+  mockFindOwnedTableImport,
+  mockStartUploadedTableImport,
+  mockToV2TableImport,
+  mockCompleteUploadSession,
+} = vi.hoisted(() => ({
+  mockCheckRateLimit: vi.fn(),
+  mockResolveWorkspaceScope: vi.fn(),
+  mockGetOwnedTableImportUpload: vi.fn(),
+  mockFindOwnedTableImport: vi.fn(),
+  mockStartUploadedTableImport: vi.fn(),
+  mockToV2TableImport: vi.fn(),
+  mockCompleteUploadSession: vi.fn(),
+}))
+
+vi.mock('@/app/api/v1/middleware', () => ({
+  checkRateLimit: mockCheckRateLimit,
+  resolveWorkspaceScope: mockResolveWorkspaceScope,
+}))
+
+vi.mock('@/app/api/v2/lib/gate', () => ({
+  v2ApiGateError: vi.fn().mockResolvedValue(null),
+}))
+
+vi.mock('@/app/api/v2/tables/utils', () => ({
+  v2TableLockError: vi.fn().mockReturnValue(null),
+}))
+
+vi.mock('@/lib/table/orchestration/import-resource', () => ({
+  findOwnedTableImport: mockFindOwnedTableImport,
+  getOwnedTableImportUpload: mockGetOwnedTableImportUpload,
+  startUploadedTableImport: mockStartUploadedTableImport,
+  toV2TableImport: mockToV2TableImport,
+}))
+
+vi.mock('@/lib/uploads/multipart-session/service', () => ({
+  completeUploadSession: mockCompleteUploadSession,
+}))
+
+import { POST } from '@/app/api/v2/tables/imports/[importId]/complete/route'
+
+const WORKSPACE_ID = '6fc7631d-88cd-46f8-9f0a-d4764daef7f8'
+const RATE_LIMIT = {
+  allowed: true,
+  userId: 'user-1',
+  keyType: 'workspace',
+  limit: 100,
+  remaining: 99,
+  resetAt: new Date('2026-08-03T22:00:00.000Z'),
+}
+const UPLOAD = {
+  id: 'import-1',
+  workspaceId: WORKSPACE_ID,
+  userId: 'user-1',
+}
+
+function request() {
+  return POST(
+    new NextRequest(
+      `http://localhost:3000/api/v2/tables/imports/import-1/complete?workspaceId=${WORKSPACE_ID}`,
+      {
+        method: 'POST',
+        headers: {
+          'Content-Type': 'application/json',
+          'upload-token': 'signed-upload-token',
+        },
+        body: JSON.stringify({ parts: [{ partNumber: 1, etag: 'etag-1' }] }),
+      }
+    ),
+    { params: Promise.resolve({ importId: 'import-1' }) }
+  )
+}
+
+describe('POST /api/v2/tables/imports/[importId]/complete', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    mockCheckRateLimit.mockResolvedValue(RATE_LIMIT)
+    mockResolveWorkspaceScope.mockResolvedValue(null)
+    mockGetOwnedTableImportUpload.mockReturnValue(UPLOAD)
+  })
+
+  it('returns the existing table job when completion is retried', async () => {
+    const existing = { id: 'import-1', tableId: 'table-1', status: 'ready' }
+    const responseBody = { id: 'import-1', tableId: 'table-1', status: 'completed' }
+    mockFindOwnedTableImport.mockResolvedValue(existing)
+    mockToV2TableImport.mockReturnValue(responseBody)
+
+    const response = await request()
+
+    expect(response.status).toBe(200)
+    expect(await response.json()).toEqual({ data: responseBody })
+    expect(mockGetOwnedTableImportUpload).toHaveBeenCalledWith({
+      importId: 'import-1',
+      workspaceId: WORKSPACE_ID,
+      userId: 'user-1',
+      uploadToken: 'signed-upload-token',
+    })
+    expect(mockFindOwnedTableImport).toHaveBeenCalledWith({
+      importId: 'import-1',
+      workspaceId: WORKSPACE_ID,
+      userId: 'user-1',
+    })
+    expect(mockCompleteUploadSession).not.toHaveBeenCalled()
+    expect(mockStartUploadedTableImport).not.toHaveBeenCalled()
+  })
+})

apps/sim/app/api/v2/tables/imports/[importId]/complete/route.ts

@@ -5,6 +5,7 @@ import { v2CompleteTableImportContract } from '@/lib/api/contracts/v2/tables'
 import { parseRequest } from '@/lib/api/server'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
 import {
+  findOwnedTableImport,
   getOwnedTableImportUpload,
   startUploadedTableImport,
   toV2TableImport,
@@ -49,6 +50,12 @@ export const POST = withRouteHandler(
         userId,
         uploadToken: parsed.data.headers['upload-token'],
       })
+      const existing = await findOwnedTableImport({
+        importId: upload.id,
+        workspaceId: upload.workspaceId,
+        userId: upload.userId,
+      })
+      if (existing) return v2Data(toV2TableImport(existing), { rateLimit })
       const completed = await completeUploadSession({
         session: upload,
         parts: parsed.data.body.parts,

apps/sim/lib/table/orchestration/import-resource.ts

@@ -161,7 +161,7 @@ export async function getOwnedTableImport(params: {
   return record
 }
 
-async function findOwnedTableImport(params: {
+export async function findOwnedTableImport(params: {
   importId: string
   workspaceId: string
   userId: string