Skip to content

Commit 785d372

Browse files
committed
docs(pi): stop describing Babysit's digest check in the present tense
Three comments still read as statements of current behavior: the Create PR push test's note beside the assertion that proves no verification happens, github-pr's module doc naming a second consumer that does not exist yet, and the timeout floor claiming a short-lifetime run was doomed regardless when the reserved ceilings are pessimistic enough that it may well finish.
1 parent 1147eaf commit 785d372

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

apps/sim/executor/handlers/pi/cloud-backend.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,9 @@ describe('runCloudPi', () => {
153153
expect(lines.at(-1)).toContain('__GIT_CONFIG_DIGEST__=')
154154
expect(lines.at(-2)).toContain('git remote set-url origin')
155155

156-
// Emitting the marker is additive for every mode; only Babysit verifies it,
157-
// because verification would fail any run that legitimately writes
158-
// repository-local git config.
156+
// Emitting the marker is additive for every mode. No mode verifies it yet;
157+
// Babysit will, and deliberately alone, because verification would fail any
158+
// run that legitimately writes repository-local git config.
159159
expect(pushCmd).not.toContain('__GIT_CONFIG_DIGEST__=')
160160
})
161161

apps/sim/executor/handlers/pi/cloud-shared.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ export const PUSH_ERROR_MAX = 1000
2121

2222
/**
2323
* Floor for {@link PI_TIMEOUT_MS}. Only reachable by configuring a sandbox
24-
* lifetime too short to hold the commands around the turn, in which case the run
25-
* was going to be reaped either way; the floor keeps the turn non-zero rather
26-
* than making it useful.
24+
* lifetime too short to reserve every surrounding command's worst-case ceiling.
25+
* Such a run can still finish, since those ceilings are pessimistic, so the floor
26+
* leaves a short turn rather than refusing one.
2727
*/
2828
const MIN_PI_TIMEOUT_MS = 60 * 1000
2929

apps/sim/executor/handlers/pi/github-pr.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/**
2-
* Shared pull-request reads for the Pi cloud modes. Review Code pins a snapshot
3-
* before cloning and re-validates it before submitting; Babysit pins one per
4-
* round. Keeping the coordinate validation, fetch, and parse here stops the two
5-
* from drifting on checks that decide which repository a credential is pointed
6-
* at and which commit a write lands on.
2+
* Shared pull-request reads for the Pi cloud modes. Review Code, the only
3+
* consumer today, pins a snapshot before cloning and re-validates it before
4+
* submitting; Babysit will pin one per round. Keeping the coordinate validation,
5+
* fetch, and parse here stops the two from drifting on checks that decide which
6+
* repository a credential is pointed at and which commit a write lands on.
77
*/
88

99
import { executeTool } from '@/tools'

0 commit comments

Comments
 (0)