improvement(search): make overlap dedupe linear in match count (#6640)

* perf(search): make overlap dedupe linear in match count

Typing in workflow Cmd+F froze the editor for over a second on a large
workflow, with the typed characters landing late in one burst.

`dedupeOverlappingWorkflowSearchMatches` ran `deduped.findIndex(...)` over
the whole accumulated list for every match, recomputing each candidate's
scope key inside the predicate - O(n^2) string builds. The memo re-runs on
every keystroke (the query is not debounced), and a single character is the
worst case because it matches the most.

Reproduced on an 81-block workflow (4530 subblocks, real knowledge-base and
OAuth references). Stage timing during one typing burst:

  searchBlocks merge      13ms
  index                   35ms
  hydration               10ms
  filter + dedupe       1458ms   <-
  resource options         6ms

Overlap is only ever resolved within one value of one subblock, so bucket
candidate indices by scope key and scan the bucket. A bucket holds exactly
the entries the old predicate could match (scope key and range both
present), buckets keep insertion order, and the scan stops at the first
overlap, so the same candidate wins. A per-bucket `maxEnd` skips the scan
entirely when a match starts at or after every kept range's end, which
keeps a single long field full of disjoint hits linear too.

Measured on that workflow, dedupe alone, by query:

  query    matches    before     after
  email        558     6.4ms    0.56ms
  r           1698    53.3ms    0.71ms
  e           3373   232.9ms    1.10ms

End to end in the browser the longest task while typing went from 1534ms
to 247ms, with the same 521 matches either way.

Two traps `maxEnd` sets, both found by adversarial review and both now
pinned by tests:

- `shouldPreferOverlappingMatch` prefers the SHORTER range, and a shorter
  range can end further right than the one it evicts. `maxEnd` has to be
  refreshed on the replacement path, not only on append, or the
  short-circuit skips real overlaps and leaks duplicates into replace-all.
- Widening with a non-finite end would pin `maxEnd` at NaN, and since every
  comparison against NaN is false that silently switches dedupe off for the
  rest of the scope. Only finite ends widen it, which matches how the
  unbucketed scan treated such a range.

`resolvers.test.ts` gains a reference implementation - a transcription of
the original linear scan - checked against the bucketed one over 400
sequential seeds whose generator also emits inverted, empty and non-finite
ranges, plus the two concrete replacement shapes above and a 20k-element
single-scope case that pins the asymptotics. An earlier revision of this
test pinned 8 hand-picked seeds and passed while 7.7% of the seed space
diverged, so the sweep width is the point.

* docs(search): describe maxEnd as a bound, not the exact maximum

Review pointed out the comment claimed `maxEnd` is "the largest range.end
currently kept in the bucket", which stops being true the moment a
replacement swaps in a range that ends earlier - it is only ever widened.

Only the upper bound is load-bearing, so say that. A bound left too high
costs a scan that would have been skipped, never a wrong answer, and the
staleness is capped at one token length because every range spans a matched
token rather than the field.

Also records why the exact maximum is deliberately not recomputed: on the
realistic overlap shape at 10k matches, recomputing measures 45ms against
23ms as written, and 1010ms for the scan this replaced.

* fix(search): preserve infinite range overlap semantics

* test(search): group dedupe equivalence coverage

---------

Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>

Author: mzxchandra

apps/sim/lib/workflows/search-replace/resources/resolvers.test.ts

@@ -4,9 +4,13 @@
 import { describe, expect, it } from 'vitest'
 import {
   dedupeOverlappingWorkflowSearchMatches,
+  OVERLAPPING_MATCH_KIND_PRIORITY,
   workflowSearchMatchMatchesQuery,
 } from '@/lib/workflows/search-replace/resources/resolvers'
-import type { WorkflowSearchMatch } from '@/lib/workflows/search-replace/types'
+import type {
+  WorkflowSearchMatch,
+  WorkflowSearchMatchKind,
+} from '@/lib/workflows/search-replace/types'
 
 function createMatch(overrides: Partial<WorkflowSearchMatch>): WorkflowSearchMatch {
   return {
@@ -115,6 +119,259 @@ describe('dedupeOverlappingWorkflowSearchMatches', () => {
       secondMatch,
     ])
   })
+
+  /**
+   * The bucketed dedupe replaced an O(n^2) linear rescan. This pins it to a
+   * transcription of the original algorithm over randomized inputs, so any
+   * divergence in which overlapping match wins shows up as a diff rather than
+   * as a subtly wrong result the fixed examples above would miss.
+   */
+  describe('bucketed dedupe matches the original linear scan', () => {
+    function scopeKey(match: WorkflowSearchMatch): string | null {
+      if (!match.range) return null
+      if (match.target.kind !== 'subblock') return null
+      const path = match.valuePath.map((s) => `${typeof s}:${String(s)}`).join('/')
+      return [match.blockId, match.subBlockId, path].join(':')
+    }
+
+    function rangeLength(match: WorkflowSearchMatch): number {
+      return match.range ? match.range.end - match.range.start : Number.POSITIVE_INFINITY
+    }
+
+    function prefers(candidate: WorkflowSearchMatch, current: WorkflowSearchMatch): boolean {
+      const a = rangeLength(candidate)
+      const b = rangeLength(current)
+      if (a !== b) return a < b
+      const pa = OVERLAPPING_MATCH_KIND_PRIORITY[candidate.kind]
+      const pb = OVERLAPPING_MATCH_KIND_PRIORITY[current.kind]
+      if (pa !== pb) return pa > pb
+      return false
+    }
+
+    /** Straight transcription of the pre-optimization implementation. */
+    function referenceDedupe(matches: WorkflowSearchMatch[]): WorkflowSearchMatch[] {
+      const deduped: WorkflowSearchMatch[] = []
+      for (const match of matches) {
+        const key = scopeKey(match)
+        const range = match.range
+        const existingIndex =
+          key && range
+            ? deduped.findIndex(
+                (candidate) =>
+                  scopeKey(candidate) === key &&
+                  candidate.range &&
+                  candidate.range.start < range.end &&
+                  range.start < candidate.range.end
+              )
+            : -1
+        if (existingIndex === -1) {
+          deduped.push(match)
+          continue
+        }
+        if (prefers(match, deduped[existingIndex])) deduped[existingIndex] = match
+      }
+      return deduped
+    }
+
+    /** Deterministic PRNG so a failure is reproducible from the seed alone. */
+    function makeRandom(seed: number) {
+      let state = seed
+      return () => {
+        state = (state * 1103515245 + 12345) & 0x7fffffff
+        return state / 0x7fffffff
+      }
+    }
+
+    const KINDS = Object.keys(OVERLAPPING_MATCH_KIND_PRIORITY) as WorkflowSearchMatchKind[]
+
+    function randomMatches(seed: number, count: number): WorkflowSearchMatch[] {
+      const random = makeRandom(seed)
+      const pick = <T>(xs: T[]) => xs[Math.floor(random() * xs.length)]
+      return Array.from({ length: count }, (_, index) => {
+        const start = Math.floor(random() * 30)
+        const hasRange = random() > 0.15
+        // Degenerate spans too: the bucketed scan keys off range arithmetic, so
+        // the oracle has to defend inverted, empty and non-finite ends as well.
+        const degenerate = random()
+        const end =
+          degenerate > 0.98
+            ? Number.NaN
+            : degenerate > 0.96
+              ? Number.POSITIVE_INFINITY
+              : degenerate > 0.94
+                ? Number.NEGATIVE_INFINITY
+                : degenerate > 0.91
+                  ? start - 1 - Math.floor(random() * 3)
+                  : degenerate > 0.88
+                    ? start
+                    : start + 1 + Math.floor(random() * 8)
+        const isSubBlockTarget = random() > 0.15
+        return createMatch({
+          id: `m-${index}`,
+          blockId: pick(['b1', 'b2', 'b3']),
+          subBlockId: pick(['s1', 's2']),
+          valuePath: pick([[], ['content'], [0], ['rows', 1]]),
+          kind: pick(KINDS),
+          target: isSubBlockTarget ? { kind: 'subblock' } : { kind: 'block-name' },
+          range: hasRange ? { start, end } : undefined,
+        })
+      })
+    }
+
+    /**
+     * A sequential sweep, not a handful of hand-picked seeds. An earlier version
+     * pinned 8 seeds that happened to be clean while 7.7% of the space diverged,
+     * so the count is what gives this test its power - keep it wide.
+     */
+    it('agrees with the original scan across 400 seeded inputs', () => {
+      const diverged: number[] = []
+
+      for (let seed = 1; seed <= 400; seed++) {
+        const matches = randomMatches(seed, 120)
+        const actual = dedupeOverlappingWorkflowSearchMatches(matches).map((m) => m.id)
+        const expected = referenceDedupe(matches).map((m) => m.id)
+        if (actual.join('|') !== expected.join('|')) diverged.push(seed)
+      }
+
+      expect(diverged).toEqual([])
+    })
+
+    /**
+     * The exact shape that broke the `maxEnd` short-circuit: a shorter range
+     * evicts a longer one but ends further right, so a stale `maxEnd` let the
+     * next match skip the overlap scan and leak through as a duplicate.
+     */
+    it.each([
+      {
+        name: 'shorter replacement ends further right',
+        spans: [
+          { kind: 'workflow-reference' as const, start: 0, end: 13 },
+          { kind: 'environment' as const, start: 10, end: 17 },
+          { kind: 'text' as const, start: 13, end: 16 },
+        ],
+      },
+      {
+        name: 'replacement extends past the evicted range',
+        spans: [
+          { kind: 'text' as const, start: 0, end: 10 },
+          { kind: 'environment' as const, start: 5, end: 15 },
+          { kind: 'text' as const, start: 10, end: 14 },
+        ],
+      },
+    ])('collapses overlaps when a $name', ({ spans }) => {
+      const matches = spans.map((span, index) =>
+        createMatch({
+          id: `span-${index}`,
+          blockId: 'b1',
+          subBlockId: 's1',
+          valuePath: [],
+          kind: span.kind,
+          range: { start: span.start, end: span.end },
+        })
+      )
+
+      expect(dedupeOverlappingWorkflowSearchMatches(matches).map((m) => m.id)).toEqual(
+        referenceDedupe(matches).map((m) => m.id)
+      )
+      expect(dedupeOverlappingWorkflowSearchMatches(matches)).toHaveLength(1)
+    })
+
+    it('agrees when a positive-infinity range contains a later range', () => {
+      const matches = [
+        createMatch({
+          id: 'unbounded',
+          kind: 'workflow-reference',
+          range: { start: 0, end: Number.POSITIVE_INFINITY },
+        }),
+        createMatch({
+          id: 'inside',
+          kind: 'text',
+          range: { start: 1, end: 2 },
+        }),
+      ]
+
+      expect(dedupeOverlappingWorkflowSearchMatches(matches).map((match) => match.id)).toEqual(
+        referenceDedupe(matches).map((match) => match.id)
+      )
+      expect(dedupeOverlappingWorkflowSearchMatches(matches).map((match) => match.id)).toEqual([
+        'inside',
+      ])
+    })
+
+    it.each([0, 1])('agrees on a %i-element input', (count) => {
+      const matches = randomMatches(5, count)
+
+      expect(dedupeOverlappingWorkflowSearchMatches(matches).map((m) => m.id)).toEqual(
+        referenceDedupe(matches).map((m) => m.id)
+      )
+    })
+
+    /**
+     * The bucketed scan is still linear *within* one scope, so a single field
+     * holding many non-overlapping hits is the residual worst case. It stays
+     * cheap because the inner loop is two integer comparisons - the old code
+     * rebuilt a scope-key string per candidate, which is where the 100x went.
+     */
+    it('agrees when one scope holds many non-overlapping ranges', () => {
+      const matches = Array.from({ length: 300 }, (_, index) =>
+        createMatch({
+          id: `disjoint-${index}`,
+          blockId: 'b1',
+          subBlockId: 'code',
+          valuePath: [],
+          kind: 'text',
+          range: { start: index * 4, end: index * 4 + 1 },
+        })
+      )
+
+      expect(dedupeOverlappingWorkflowSearchMatches(matches)).toHaveLength(300)
+      expect(dedupeOverlappingWorkflowSearchMatches(matches).map((m) => m.id)).toEqual(
+        referenceDedupe(matches).map((m) => m.id)
+      )
+    })
+
+    /**
+     * Pins the asymptotics, not a stopwatch. 20k disjoint hits in one scope run
+     * in single-digit ms bucketed; the O(n^2) rescan this replaced took ~30s on
+     * the same input, so the bound has roughly three orders of magnitude of
+     * headroom and only trips on a genuine complexity regression.
+     */
+    it('stays sub-quadratic on a single scope full of disjoint ranges', () => {
+      const matches = Array.from({ length: 20_000 }, (_, index) =>
+        createMatch({
+          id: `wide-${index}`,
+          blockId: 'b1',
+          subBlockId: 'code',
+          valuePath: [],
+          kind: 'text',
+          range: { start: index * 4, end: index * 4 + 1 },
+        })
+      )
+
+      const startedAt = performance.now()
+      const deduped = dedupeOverlappingWorkflowSearchMatches(matches)
+
+      expect(deduped).toHaveLength(20_000)
+      expect(performance.now() - startedAt).toBeLessThan(2_000)
+    })
+
+    it('agrees when every match shares one scope and range', () => {
+      const matches = Array.from({ length: 40 }, (_, index) =>
+        createMatch({
+          id: `same-${index}`,
+          blockId: 'b1',
+          subBlockId: 's1',
+          valuePath: [],
+          kind: index % 2 === 0 ? 'text' : 'table',
+          range: { start: 0, end: 5 },
+        })
+      )
+
+      expect(dedupeOverlappingWorkflowSearchMatches(matches).map((m) => m.id)).toEqual(
+        referenceDedupe(matches).map((m) => m.id)
+      )
+    })
+  })
 })
 
 describe('workflowSearchMatchMatchesQuery', () => {

apps/sim/lib/workflows/search-replace/resources/resolvers.ts

@@ -7,7 +7,12 @@ import type {
 } from '@/lib/workflows/search-replace/types'
 import type { SelectorContext } from '@/hooks/selectors/types'
 
-const OVERLAPPING_MATCH_KIND_PRIORITY: Record<WorkflowSearchMatchKind, number> = {
+/**
+ * Which kind wins when two matches cover the same span. Exported so the
+ * equivalence tests can share it instead of hand-copying the values, which
+ * silently drifted once already.
+ */
+export const OVERLAPPING_MATCH_KIND_PRIORITY: Record<WorkflowSearchMatchKind, number> = {
   text: 0,
   environment: 1,
   'workflow-reference': 2,
@@ -141,31 +146,97 @@ function shouldPreferOverlappingMatch(
   return false
 }
 
+/** Kept indices for one overlap scope, plus an upper bound on their `range.end`. */
+interface RangeMatchScopeBucket {
+  indices: number[]
+  maxEnd: number
+}
+
+function widenScopeBucket(bucket: RangeMatchScopeBucket, end: number): void {
+  if (!Number.isNaN(end)) bucket.maxEnd = Math.max(bucket.maxEnd, end)
+}
+
+/**
+ * Overlap resolution is scoped to one value inside one subblock, so candidates
+ * are bucketed by that scope rather than rescanned. The previous `findIndex`
+ * over the whole accumulated list recomputed every candidate's scope key on
+ * every iteration - O(n^2) string builds, which cost ~1.4s on a workflow
+ * producing ~500 matches and froze the search field while typing.
+ *
+ * A bucket only ever holds entries that have both a scope key and a range, and
+ * those are exactly the entries the old predicate could match. Buckets keep
+ * insertion order and the scan stops at the first overlap, so this picks the
+ * same candidate the linear scan did.
+ *
+ * `maxEnd` is a monotonic high-water mark, not the exact current maximum: a
+ * replacement can swap in a range that ends earlier without lowering it. Only
+ * the upper bound is load-bearing. A match starting at or after it cannot
+ * overlap anything in the bucket, so the scan is skipped; a bound left too high
+ * only costs a scan that would have been skipped, never a wrong answer.
+ *
+ * Recomputing the exact maximum on every shrinking replacement is a net loss -
+ * it walks the bucket, which is the cost this is here to avoid, and staleness
+ * is capped at one token length because every range spans a matched token
+ * (`query.length`, or a reference's `rawValue.length`) rather than the field.
+ * Measured on the realistic overlap shape at 10k matches: 23ms as written,
+ * 45ms with the recompute, against 1010ms for the scan this replaced.
+ *
+ * The bound keeps a field full of disjoint hits linear instead of quadratic
+ * within its own bucket, to the extent its matches arrive in ascending offset
+ * order; out-of-order producers just fall back to scanning.
+ *
+ * It must be refreshed on the replacement path too, not only on append:
+ * `shouldPreferOverlappingMatch` prefers the SHORTER range, and a shorter range
+ * can still end further right than the one it evicts. Leaving `maxEnd` stale
+ * there let the short-circuit skip genuine overlaps and leak duplicates.
+ *
+ * Only `NaN` ends are ignored. `Math.max` with `NaN` would pin `maxEnd` at
+ * `NaN`, and since every comparison against `NaN` is false that would silently
+ * switch dedupe off for the rest of the scope. A `NaN`-ended range cannot
+ * overlap anything anyway, while positive infinity is an unbounded end that
+ * can overlap later ranges and therefore must widen the high-water mark.
+ */
 export function dedupeOverlappingWorkflowSearchMatches<T extends WorkflowSearchMatch>(
   matches: T[]
 ): T[] {
   const deduped: T[] = []
+  const bucketsByScopeKey = new Map<string, RangeMatchScopeBucket>()
 
   for (const match of matches) {
     const scopeKey = getRangeMatchScopeKey(match)
     const matchRange = match.range
-    const existingIndex =
-      scopeKey && matchRange
-        ? deduped.findIndex(
-            (candidate) =>
-              getRangeMatchScopeKey(candidate) === scopeKey &&
-              candidate.range &&
-              rangesOverlap(candidate.range, matchRange)
-          )
-        : -1
+    const bucket = scopeKey && matchRange ? bucketsByScopeKey.get(scopeKey) : undefined
+
+    let existingIndex = -1
+    if (bucket && matchRange && matchRange.start < bucket.maxEnd) {
+      for (const index of bucket.indices) {
+        const candidate = deduped[index]
+        if (candidate.range && rangesOverlap(candidate.range, matchRange)) {
+          existingIndex = index
+          break
+        }
+      }
+    }
 
     if (existingIndex === -1) {
+      if (scopeKey && matchRange) {
+        if (bucket) {
+          bucket.indices.push(deduped.length)
+          widenScopeBucket(bucket, matchRange.end)
+        } else {
+          bucketsByScopeKey.set(scopeKey, {
+            indices: [deduped.length],
+            maxEnd: Number.isNaN(matchRange.end) ? Number.NEGATIVE_INFINITY : matchRange.end,
+          })
+        }
+      }
       deduped.push(match)
       continue
     }
 
     if (shouldPreferOverlappingMatch(match, deduped[existingIndex])) {
       deduped[existingIndex] = match
+      if (bucket && matchRange) widenScopeBucket(bucket, matchRange.end)
     }
   }