Commit 89d7544
committed
fix(merge): repair three regressions the staging merge surfaced
- cloud-review-tools.test.ts: the merge kept the branch's import line (which
had dropped `symlink` along with the test that used it) while taking
staging's reinstated test body, so the symlink-escape assertion would have
thrown ReferenceError on CI. tsconfig excludes *.test.ts, so type-check
could not catch it. Restored the import and the workflow's ripgrep install
step, which the branch removed alongside the same test.
- createByteRangeResponse defaulted to `public, max-age=31536000` while its
sibling createFileResponse defaults to `private, no-cache` and says in a
comment why. resolveServeCacheControl returns undefined for any unversioned
non-`workspace` context, so those access-verified media responses landed on
the public default — storable by a shared cache and re-servable cross-user,
where staging sent `private, no-cache`. Defaults now match.
- ReadOnlyTextPreview: restored staging's `flex … flex-col` on the rich
preview wrapper. Every PreviewPanel renderer sizes itself as a flex item, so
in a block parent HtmlPreview measures a zero-height box, never mounts its
iframe, and nothing ever grows the container to un-wedge it — shared .html
and .svg rendered blank.1 parent a4984be commit 89d7544
7 files changed
Lines changed: 123 additions & 110 deletions
File tree
- .github/workflows
- apps/sim
- app/api/files
- components/resources/file-view
- executor/handlers/pi
- lib/execution/sandbox/bundles
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
145 | 150 | | |
146 | 151 | | |
147 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
309 | | - | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
310 | 314 | | |
311 | 315 | | |
312 | 316 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
394 | 394 | | |
395 | 395 | | |
396 | 396 | | |
397 | | - | |
| 397 | + | |
| 398 | + | |
398 | 399 | | |
399 | 400 | | |
400 | 401 | | |
401 | | - | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
402 | 407 | | |
403 | 408 | | |
404 | 409 | | |
| |||
411 | 416 | | |
412 | 417 | | |
413 | 418 | | |
414 | | - | |
| 419 | + | |
415 | 420 | | |
416 | 421 | | |
417 | 422 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
0 commit comments