Skip to content

Commit 93b78fb

Browse files
icecrasher321claude
andcommitted
docs(tools): correct and widen the registry-only note
The previous note contrasted these five with "the user-facing tools added alongside them", implying this branch added both. It did not: the branch never touches blocks/blocks/github.ts, and github_create_pr_review came from #5471, which predates staging. The real contrast is with every user-facing GitHub tool in the registry. Also records the governance consequence, which was the part actually worth writing down: the permission-group deny list is built from tools.access, so an admin cannot deny these from the UI, and the allowedIntegrations gate keys on block type while Babysit calls them with a tool id alone. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent e768176 commit 93b78fb

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

apps/sim/tools/registry.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6289,10 +6289,20 @@ export const tools: Record<string, ToolConfig> = {
62896289
/**
62906290
* Internal to the Pi Babysit handler, which calls them through `executeTool`.
62916291
* Deliberately registry-only: no `_v2` variant and no entry in the GitHub
6292-
* block's `tools.access`, unlike the user-facing tools added alongside them.
6292+
* block's `tools.access`, unlike every user-facing GitHub tool above.
6293+
*
6294+
* Two consequences, neither encoded in CI:
6295+
*
62936296
* `GitHubV2Block` derives its access list by appending `_v2` to every entry,
6294-
* so adding one of these there without first adding a v2 would point the block
6295-
* at an id that does not exist. Nothing in CI encodes that, hence this note.
6297+
* so adding one of these to `tools.access` without first adding a v2 would
6298+
* point the block at an id that does not exist. `check-block-registry.ts`
6299+
* skips ids it cannot resolve rather than failing, so that ships silently.
6300+
*
6301+
* The permission-group deny list is also built from `tools.access`, so an
6302+
* enterprise admin cannot deny these five from the UI. Enforcement itself is
6303+
* id-based and would apply if they were denied; only discoverability is
6304+
* missing. Denying the GitHub integration does not stop them either, because
6305+
* that gate keys on block type and Babysit calls them with a tool id alone.
62966306
*/
62976307
github_list_review_threads: githubListReviewThreadsTool,
62986308
github_reply_review_thread: githubReplyReviewThreadTool,

0 commit comments

Comments
 (0)