fix(tables): address view review feedback

Author: Bill Leoutsakos

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

@@ -264,17 +264,35 @@ export function Table({
    *  panel's Columns section edits it and the active view persists it. */
   const [hiddenColumns, setHiddenColumns] = useState<string[]>([])
 
-  const [{ sort: sortColumn, dir: sortDirection, view: activeViewId }, setTableParams] =
+  const [{ sort: sortColumn, dir: sortDirection, view: urlActiveViewId }, setTableParams] =
     useQueryStates(tableDetailParsers, tableDetailUrlKeys)
 
-  /** A chat View resource owns its initial selection. After seeding, normal
-   * selector and URL behavior take over so users can switch Views as usual. */
-  const seededPropViewRef = useRef<string | undefined>(undefined)
+  /**
+   * An embedded View must own the first render synchronously. Seeding only the
+   * host URL in an effect races the view resolver: it can adopt Default view
+   * before the URL write lands and clear the requested chat resource.
+   *
+   * Keep a local selection only for View-resource embeds; page Tables and plain
+   * Table resources continue to use the URL as their sole source of truth.
+   */
+  const [embeddedActiveViewId, setEmbeddedActiveViewId] = useState<string | null>(
+    () => propViewId ?? null
+  )
+  const activeViewId = propViewId ? embeddedActiveViewId : urlActiveViewId
+  const syncedPropViewRef = useRef<string | undefined>(undefined)
   useEffect(() => {
-    if (!propViewId || seededPropViewRef.current === propViewId) return
-    seededPropViewRef.current = propViewId
+    if (!propViewId || syncedPropViewRef.current === propViewId) return
+    syncedPropViewRef.current = propViewId
+    setEmbeddedActiveViewId(propViewId)
     void setTableParams({ view: propViewId })
   }, [propViewId, setTableParams])
+  const setActiveViewId = useCallback(
+    (viewId: string) => {
+      if (propViewId) setEmbeddedActiveViewId(viewId)
+      void setTableParams({ view: viewId })
+    },
+    [propViewId, setTableParams]
+  )
 
   // Read-only mirrors for the resolve effect: it must know whether the user has
   // already applied a filter / hidden columns without re-running when they change.
@@ -552,7 +570,7 @@ export function Table({
         const keep = inheritedParams ? { ...localWork(), sort: false } : localWork()
         if (defaultView) {
           seededViewIdRef.current = defaultView.id
-          setTableParams({ view: defaultView.id })
+          setActiveViewId(defaultView.id)
           applyViewConfig(defaultView.config, keep)
           resolvePendingLayout(true)
           return
@@ -561,7 +579,10 @@ export function Table({
         // would clear a deep-linked `?sort=` on mount. Inherited params are the
         // exception: nothing about them refers to this table, so they're cleared.
         seededViewIdRef.current = null
-        if (inheritedParams) setTableParams({ view: ALL_VIEW_PARAM, sort: null, dir: null })
+        if (inheritedParams) {
+          setActiveViewId(ALL_VIEW_PARAM)
+          setTableParams({ sort: null, dir: null })
+        }
         resolvePendingLayout(false)
         return
       }
@@ -581,7 +602,7 @@ export function Table({
         // Nothing to apply, but the URL still names a view that no longer exists.
         // Rewrite it so a stale bookmark can't be copied on, and so the param
         // matches the All the UI is already showing.
-        setTableParams({ view: ALL_VIEW_PARAM })
+        setActiveViewId(ALL_VIEW_PARAM)
       }
       return
     }
@@ -599,7 +620,7 @@ export function Table({
     if (activeViewId !== null && activeViewId !== ALL_VIEW_PARAM && !activeView) {
       if (pendingCreatedViewIdRef.current === activeViewId) return
       seededViewIdRef.current = null
-      setTableParams({ view: ALL_VIEW_PARAM })
+      setActiveViewId(ALL_VIEW_PARAM)
       applyViewConfig(null)
       return
     }
@@ -623,7 +644,7 @@ export function Table({
     embedded,
     sortColumn,
     applyViewConfig,
-    setTableParams,
+    setActiveViewId,
     resolvePendingLayout,
   ])
 
@@ -707,9 +728,9 @@ export function Table({
 
   const handleSelectView = useCallback(
     (viewId: string | null) => {
-      setTableParams({ view: viewId ?? ALL_VIEW_PARAM })
+      setActiveViewId(viewId ?? ALL_VIEW_PARAM)
     },
-    [setTableParams]
+    [setActiveViewId]
   )
 
   const handleRenameView = useCallback((viewId: string) => {
@@ -816,7 +837,7 @@ export function Table({
           // seeded — it can't tell a just-created view from a dead id otherwise.
           seededViewIdRef.current = view.id
           pendingCreatedViewIdRef.current = view.id
-          setTableParams({ view: view.id })
+          setActiveViewId(view.id)
           // Which means the blank config must be applied here; nuqs batches this
           // sort write with the `view` write above into one URL update.
           if (blank) applyViewConfig(view.config)
@@ -830,12 +851,12 @@ export function Table({
     (viewId: string) => {
       deleteViewMutation.mutate(viewId, {
         onSuccess: () => {
-          if (viewId === activeViewId) setTableParams({ view: ALL_VIEW_PARAM })
+          if (viewId === activeViewId) setActiveViewId(ALL_VIEW_PARAM)
         },
         onError: (error) => toast.error(getErrorMessage(error, 'Failed to delete view')),
       })
     },
-    [activeViewId, setTableParams]
+    [activeViewId, setActiveViewId]
   )
 
   const runColumnMutation = useRunColumn({ workspaceId, tableId })

apps/sim/lib/copilot/resources/extraction.test.ts

@@ -5,6 +5,44 @@ import { describe, expect, it } from 'vitest'
 import { extractDeletedResourcesFromToolResult, extractResourcesFromToolResult } from './extraction'
 
 describe('extractResourcesFromToolResult', () => {
+  it('auto-opens the created View instead of its source Table', () => {
+    const resources = extractResourcesFromToolResult(
+      'user_table',
+      {
+        operation: 'create_view',
+        args: { tableId: 'tbl_123' },
+      },
+      {
+        success: true,
+        message: 'Created View "Qualified leads"',
+        data: {
+          view: {
+            id: 'view_456',
+            tableId: 'tbl_123',
+            name: 'Qualified leads',
+          },
+        },
+        // Server tools are wrapped in ToolExecutionResult.output, so this
+        // nested descriptor is not available as result.resources.
+        resources: [
+          {
+            type: 'view',
+            id: 'tbl_123:view_456',
+            title: 'Qualified leads',
+          },
+        ],
+      }
+    )
+
+    expect(resources).toEqual([
+      {
+        type: 'view',
+        id: 'tbl_123:view_456',
+        title: 'Qualified leads',
+      },
+    ])
+  })
+
   it('extracts file resources from create_file results', () => {
     const resources = extractResourcesFromToolResult(
       'create_file',

apps/sim/lib/copilot/resources/extraction.ts

@@ -15,7 +15,7 @@ import {
   UserTable,
   WorkspaceFile,
 } from '@/lib/copilot/generated/tool-catalog-v1'
-import type { MothershipResource, MothershipResourceType } from './types'
+import { type MothershipResource, type MothershipResourceType, tableViewResourceId } from './types'
 
 type ChatResource = MothershipResource
 type ResourceType = MothershipResourceType
@@ -79,6 +79,22 @@ export function extractResourcesFromToolResult(
     case UserTable.id: {
       if (READ_ONLY_TABLE_OPS.has(getOperation(params) ?? '')) return []
 
+      const args = asRecord(params?.args)
+      if (getOperation(params) === 'create_view') {
+        const view = asRecord(data.view)
+        const tableId = (view.tableId as string | undefined) ?? (args.tableId as string | undefined)
+        if (tableId && view.id) {
+          return [
+            {
+              type: 'view',
+              id: tableViewResourceId(tableId, view.id as string),
+              title: (view.name as string) || 'View',
+            },
+          ]
+        }
+        return []
+      }
+
       if (result.tableId) {
         return [
           {
@@ -101,7 +117,6 @@ export function extractResourcesFromToolResult(
       if (table.id) {
         return [{ type: 'table', id: table.id as string, title: (table.name as string) || 'Table' }]
       }
-      const args = asRecord(params?.args)
       const tableId =
         (data.tableId as string) ?? (args.tableId as string) ?? (params?.tableId as string)
       if (tableId) {

apps/sim/lib/copilot/tools/handlers/resources.test.ts

@@ -133,6 +133,51 @@ describe('executeOpenResource', () => {
     })
   })
 
+  it('reopens a View from its persisted composite resource id', async () => {
+    getTableViewMock.mockResolvedValue({
+      id: 'view_1',
+      tableId: 'tbl_1',
+      name: 'Qualified leads',
+    })
+    getTableByIdMock.mockResolvedValue({
+      id: 'tbl_1',
+      workspaceId: 'workspace-1',
+      name: 'Leads',
+    })
+
+    const result = await executeOpenResource(
+      { resources: [{ type: 'view', id: 'tbl_1:view_1' }] },
+      { userId: 'user-1', workflowId: 'workflow-1', workspaceId: 'workspace-1' }
+    )
+
+    expect(getTableViewMock).toHaveBeenCalledWith('view_1')
+    expect(result).toMatchObject({
+      success: true,
+      output: { opened: 1, errors: [] },
+      resources: [{ type: 'view', id: 'tbl_1:view_1', title: 'Qualified leads' }],
+    })
+  })
+
+  it('refuses a composite View id with the wrong source Table', async () => {
+    getTableViewMock.mockResolvedValue({
+      id: 'view_1',
+      tableId: 'tbl_actual',
+      name: 'Qualified leads',
+    })
+
+    const result = await executeOpenResource(
+      { resources: [{ type: 'view', id: 'tbl_claimed:view_1' }] },
+      { userId: 'user-1', workflowId: 'workflow-1', workspaceId: 'workspace-1' }
+    )
+
+    expect(getTableByIdMock).not.toHaveBeenCalled()
+    expect(result).toMatchObject({
+      success: false,
+      output: { opened: 0, errors: ['View does not belong to the specified Table.'] },
+      resources: [],
+    })
+  })
+
   it('refuses a View whose source Table belongs to another workspace', async () => {
     getTableViewMock.mockResolvedValue({
       id: 'view_1',

apps/sim/lib/copilot/tools/handlers/resources.ts

@@ -5,6 +5,7 @@ import type { ExecutionContext, ToolCallResult } from '@/lib/copilot/request/typ
 import {
   type MothershipResource,
   MothershipResourceType,
+  parseTableViewResourceId,
   tableViewResourceId,
 } from '@/lib/copilot/resources/types'
 import { canonicalWorkspaceFilePath } from '@/lib/copilot/vfs/path-utils'
@@ -68,8 +69,12 @@ async function resolveResource(
   }
   if (resourceType === 'view') {
     if (!item.id) return { error: 'view resources require `id`.' }
-    const view = await getTableView(item.id)
+    const parsedId = parseTableViewResourceId(item.id)
+    const view = await getTableView(parsedId?.viewId ?? item.id)
     if (!view) return { error: `No View with id "${item.id}".` }
+    if (parsedId && parsedId.tableId !== view.tableId) {
+      return { error: 'View does not belong to the specified Table.' }
+    }
     const table = await getTableById(view.tableId)
     if (!table || (context.workspaceId && table.workspaceId !== context.workspaceId)) {
       return { error: 'View not found in the current workspace.' }