fix(tables): handle stale chat views

Author: Bill Leoutsakos

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/embedded-view-table/embedded-view-table.test.tsx

@@ -66,12 +66,7 @@ describe('EmbeddedViewTable', () => {
       root.render(<EmbeddedViewTable workspaceId='workspace_1' resourceId='tbl_1:view_1' />)
     })
 
-    expect(tableMock).toHaveBeenCalledWith({
-      workspaceId: 'workspace_1',
-      tableId: 'tbl_1',
-      viewId: 'view_1',
-      embedded: true,
-      viewsEnabled: false,
-    })
+    expect(container.innerHTML).toBe('')
+    expect(tableMock).not.toHaveBeenCalled()
   })
 })

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/embedded-view-table/embedded-view-table.tsx

@@ -16,7 +16,7 @@ export function EmbeddedViewTable({
   viewsEnabled = false,
 }: EmbeddedViewTableProps) {
   const parsed = parseTableViewResourceId(resourceId)
-  if (!parsed) return null
+  if (!parsed || !viewsEnabled) return null
   return (
     <Table
       workspaceId={workspaceId}

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

@@ -562,6 +562,7 @@ export function Table({
       // switching resources away and back, not leakage.
       const inheritedParams =
         embedded &&
+        !propViewId &&
         activeViewId !== null &&
         activeViewId !== ALL_VIEW_PARAM &&
         !views.some((view) => view.id === activeViewId)

apps/sim/lib/copilot/tools/server/table/user-table.test.ts

@@ -900,6 +900,17 @@ describe('userTableServerTool.create_view', () => {
     )
   })
 
+  it('normalizes an empty model-authored filter to no filter', async () => {
+    await userTableServerTool.execute(
+      { operation: 'create_view', args: { tableId: 'tbl_1', filter: {} } },
+      { userId: 'user-1', workspaceId: 'workspace-1' }
+    )
+
+    expect(mockCreateTableView).toHaveBeenCalledWith(
+      expect.objectContaining({ config: { filter: null, sort: null } })
+    )
+  })
+
   it('rejects a Table from another workspace without creating a View', async () => {
     mockGetTableById.mockResolvedValue(buildTable({ workspaceId: 'other-workspace' }))
 

apps/sim/lib/copilot/tools/server/table/user-table.ts

@@ -49,6 +49,7 @@ import { markTableDeleteFailed, runTableDelete } from '@/lib/table/delete-runner
 import { runTableImport, type TableImportPayload } from '@/lib/table/import-runner'
 import { markTableJobRunning, releaseJobClaim } from '@/lib/table/jobs/service'
 import { assertRowDelete, assertRowUpdate, patchColumnIds } from '@/lib/table/mutation-locks'
+import { pruneViewFilterForColumns } from '@/lib/table/query-builder/converters'
 import {
   batchInsertRows,
   batchUpdateRows,
@@ -778,7 +779,10 @@ export const userTableServerTool: BaseServerTool<UserTableArgs, UserTableResult>
           }
 
           const filter = args.filter
-            ? canonicalViewFilter(args.filter as Filter, table.schema.columns)
+            ? pruneViewFilterForColumns(
+                canonicalViewFilter(args.filter as Filter, table.schema.columns),
+                table.schema.columns
+              )
             : null
           const sort = args.sort
             ? canonicalViewSort(args.sort as Record<string, 'asc' | 'desc'>, table.schema.columns)