feat(desktop): polish browser and terminal resources

Author: Sg312

apps/desktop/src/main/browser-agent/cdp.test.ts

@@ -3,7 +3,21 @@ import { describe, expect, it, vi } from 'vitest'
 vi.mock('electron', () => import('@/test/electron-mock'))
 
 import { WebContentsView } from 'electron'
-import { setColorScheme } from '@/main/browser-agent/cdp'
+import { ensureInstrumented, setColorScheme } from '@/main/browser-agent/cdp'
+
+describe('browser-agent CDP instrumentation', () => {
+  it('leaves file chooser dialogs native so users can upload files', async () => {
+    const contents = new WebContentsView().webContents
+
+    await ensureInstrumented(contents, { onDialog: vi.fn() })
+
+    expect(contents.debugger.sendCommand).toHaveBeenCalledWith('Page.enable', undefined)
+    expect(contents.debugger.sendCommand).not.toHaveBeenCalledWith(
+      'Page.setInterceptFileChooserDialog',
+      expect.anything()
+    )
+  })
+})
 
 describe('browser-agent CDP theme', () => {
   it('emulates explicit light and dark preferences', async () => {

apps/desktop/src/main/browser-agent/cdp.ts

@@ -1,7 +1,7 @@
 /**
  * CDP instrumentation for agent tabs via `webContents.debugger`: auto-handles
- * the page states that would otherwise wedge automation (JS dialogs, file
- * choosers), captures screenshots that work even while the view is hidden,
+ * the page states that would otherwise wedge automation (JS dialogs),
+ * captures screenshots that work even while the view is hidden,
  * and dispatches TRUSTED input (key events, text insertion). Trusted input
  * goes through Blink's real input pipeline — unlike synthetic DOM
  * `KeyboardEvent`s, it triggers default actions (select-all, deletion, caret
@@ -24,8 +24,6 @@ export interface PageDialog {
 export interface CdpCallbacks {
   /** A JS dialog was auto-handled; the driver surfaces it to the model. */
   onDialog: (dialog: PageDialog) => void
-  /** A file chooser was suppressed; the driver surfaces it to the model. */
-  onFileChooser: () => void
 }
 
 /** Per-tab callbacks, so a background tab's events reach ITS driver, not the
@@ -58,9 +56,6 @@ export async function ensureInstrumented(contents: WebContents, cb: CdpCallbacks
   }
 
   await send(contents, 'Page.enable')
-  // Suppress native file choosers: nothing can drive them from the panel,
-  // and an open chooser blocks the page. Recorded and surfaced instead.
-  await send(contents, 'Page.setInterceptFileChooserDialog', { enabled: true }).catch(() => {})
 }
 
 /**
@@ -92,10 +87,6 @@ function handleDebuggerEvent(
     callbacks?.onDialog({ type, message })
     return
   }
-  if (method === 'Page.fileChooserOpened') {
-    logger.info('Suppressed file chooser in agent browser')
-    callbacks?.onFileChooser()
-  }
 }
 
 /**

apps/desktop/src/main/browser-agent/context-menu.test.ts

@@ -33,7 +33,13 @@ function params(overrides: Partial<Params> = {}): Params {
 
 function page(overrides: Partial<Page> = {}): Page {
   // A fresh tab sits at the panel's baseline, which the menu reports as 100%.
-  return { canGoBack: true, canGoForward: true, zoomFactor: BASE_ZOOM_FACTOR, ...overrides }
+  return {
+    canGoBack: true,
+    canGoForward: true,
+    zoomFactor: BASE_ZOOM_FACTOR,
+    defaultZoomFactor: BASE_ZOOM_FACTOR,
+    ...overrides,
+  }
 }
 
 function handlers(): Handlers {
@@ -67,7 +73,7 @@ describe('buildAgentContextMenuTemplate', () => {
       'Reload',
       'Zoom In',
       'Zoom Out',
-      'Actual Size (100%)',
+      'Reset Zoom (100%)',
     ])
   })
 
@@ -137,7 +143,7 @@ describe('buildAgentContextMenuTemplate', () => {
     // against Chromium's native scale (where this factor would read 110%).
     const twoUp = steppedZoomFactor(steppedZoomFactor(BASE_ZOOM_FACTOR, 1), 1)
     const stepped = buildAgentContextMenuTemplate(params(), page({ zoomFactor: twoUp }), handlers())
-    expect(item(stepped, 'Actual Size (121%)')?.enabled).toBe(true)
+    expect(item(stepped, 'Reset Zoom (121%)')?.enabled).toBe(true)
 
     const atMax = buildAgentContextMenuTemplate(params(), page({ zoomFactor: 3 }), handlers())
     expect(item(atMax, 'Zoom In')?.enabled).toBe(false)
@@ -148,21 +154,26 @@ describe('buildAgentContextMenuTemplate', () => {
 
     // Nothing to reset to at 100%.
     expect(
-      item(buildAgentContextMenuTemplate(params(), page(), handlers()), 'Actual Size (100%)')
+      item(buildAgentContextMenuTemplate(params(), page(), handlers()), 'Reset Zoom (100%)')
         ?.enabled
     ).toBe(false)
   })
 
-  it('resets to exactly the baseline, undoing accumulated drift', () => {
+  it('resets to the configured default, undoing accumulated drift', () => {
     const handled = handlers()
     // Three rungs of float multiplication up, so the factor no longer sits on a
     // clean value — reset has to restore the baseline exactly, not step back.
     const drifted = [1, 1, 1].reduce((factor) => steppedZoomFactor(factor, 1), BASE_ZOOM_FACTOR)
-    const template = buildAgentContextMenuTemplate(params(), page({ zoomFactor: drifted }), handled)
+    const configuredDefault = BASE_ZOOM_FACTOR * 1.25
+    const template = buildAgentContextMenuTemplate(
+      params(),
+      page({ zoomFactor: drifted, defaultZoomFactor: configuredDefault }),
+      handled
+    )
 
-    item(template, 'Actual Size (133%)')?.click?.({} as never, undefined as never, {} as never)
+    item(template, 'Reset Zoom (133%)')?.click?.({} as never, undefined as never, {} as never)
 
-    expect(handled.setZoomFactor).toHaveBeenCalledWith(BASE_ZOOM_FACTOR)
+    expect(handled.setZoomFactor).toHaveBeenCalledWith(configuredDefault)
   })
 
   it('never leaves a separator with nothing above it', () => {
@@ -190,7 +201,10 @@ describe('attachAgentContextMenu', () => {
   it('pops a menu built from the page that was right-clicked', () => {
     const contents = new WebContentsView().webContents
     vi.mocked(contents.navigationHistory.canGoBack).mockReturnValue(true)
-    attachAgentContextMenu(contents, { openTab: vi.fn() })
+    attachAgentContextMenu(contents, {
+      openTab: vi.fn(),
+      defaultZoomFactor: () => BASE_ZOOM_FACTOR,
+    })
 
     const listeners = vi.mocked(contents.on).mock.calls as unknown as [
       string,

apps/desktop/src/main/browser-agent/context-menu.ts

@@ -32,9 +32,9 @@ const MAX_ZOOM_FACTOR = 3
  * The browser lives in a panel that is only ever a fraction of the window, so
  * it renders a rung below Chromium's native scale and treats THAT as its
  * baseline: the menu reads 100% there, and every other rung is reported
- * relative to it. Users get a zoom control that behaves the way one should —
- * starts at 100%, resets to 100% — over a page that is genuinely rendering at
- * ~91% of native.
+ * relative to it. New installs start there; when a user chooses a different
+ * default, Reset Zoom returns to that configured percentage. The initial 100%
+ * is genuinely rendering at ~91% of native.
  *
  * Defined as one rung below native rather than as a round number so the ladder
  * still lands exactly on Chromium's 1.0 (the crispest rasterization, one step
@@ -76,6 +76,7 @@ interface AgentPageContext {
   canGoBack: boolean
   canGoForward: boolean
   zoomFactor: number
+  defaultZoomFactor: number
 }
 
 interface AgentContextMenuHandlers {
@@ -92,6 +93,8 @@ interface AgentContextMenuHandlers {
 export interface AgentContextMenuHost {
   /** Opens a link from the page in another tab of the same browser. */
   openTab(url: string): void
+  /** Returns the device's current default page zoom factor. */
+  defaultZoomFactor(): number
 }
 
 /**
@@ -150,9 +153,9 @@ export function buildAgentContextMenuTemplate(
       click: () => handlers.setZoomFactor(zoomOut),
     },
     {
-      label: `Actual Size (${zoomPercent}%)`,
-      enabled: zoomPercent !== 100,
-      click: () => handlers.setZoomFactor(BASE_ZOOM_FACTOR),
+      label: `Reset Zoom (${zoomPercent}%)`,
+      enabled: page.zoomFactor !== page.defaultZoomFactor,
+      click: () => handlers.setZoomFactor(page.defaultZoomFactor),
     }
   )
 
@@ -168,6 +171,7 @@ export function attachAgentContextMenu(contents: WebContents, host: AgentContext
         canGoBack: contents.navigationHistory.canGoBack(),
         canGoForward: contents.navigationHistory.canGoForward(),
         zoomFactor: contents.getZoomFactor(),
+        defaultZoomFactor: host.defaultZoomFactor(),
       },
       {
         copy: () => contents.copy(),

apps/desktop/src/main/browser-agent/driver.test.ts

@@ -1,8 +1,9 @@
+import type { MenuItemConstructorOptions } from 'electron'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 vi.mock('electron', () => import('@/test/electron-mock'))
 
-import { BrowserWindow } from 'electron'
+import { BrowserWindow, Menu } from 'electron'
 import * as driverModule from '@/main/browser-agent/driver'
 import * as session from '@/main/browser-agent/session'
 
@@ -65,6 +66,28 @@ describe('executeTool', () => {
     expect(second.result).toMatchObject({ tabs: [] })
   })
 
+  it('builds the native toolbar menu and routes renderer-owned actions back to its chat', async () => {
+    await driver.executeTool('browser_open_tab', {})
+    const win = new BrowserWindow()
+    vi.mocked(Menu.buildFromTemplate).mockClear()
+
+    expect(driver.showToolbarMenu('legacy', win, { x: 20, y: 30 })).toBe(true)
+    const template = vi.mocked(Menu.buildFromTemplate).mock.calls[0]?.[0] as
+      | MenuItemConstructorOptions[]
+      | undefined
+    const labels = template?.filter((item) => item.type !== 'separator').map((item) => item.label)
+    expect(labels).toEqual(['Find in Page', 'Zoom (110%)', 'Import Passwords', 'Browser Settings'])
+
+    const settings = template?.find((item) => item.label === 'Browser Settings')
+    const openSettings = settings?.click as (() => void) | undefined
+    openSettings?.()
+    expect(win.webContents.send).toHaveBeenCalledWith(
+      'browser-agent:toolbar-command',
+      'browser-settings',
+      'legacy'
+    )
+  })
+
   it('keeps tool queues and tab state isolated by chat scope', async () => {
     await driver.executeTool('chat-a', 'browser_open_tab', {})
     await driver.executeTool('chat-a', 'browser_open_tab', {})