Skip to content

Commit bae8c9c

Browse files
committed
chore(knowledge): drop the dead pre-redesign knowledge base sort
`sortKnowledgeBases` was a second, complete ordering for knowledge bases (name/createdAt/updatedAt/docCount) left over from the old sort dropdown, with no consumers since the shared Resource sort menu replaced it — the kind of duplicate that silently diverges from the page it shadows. Its `SortOption`/`SortOrder` types and the `SORT_OPTIONS` list that fed it were dead with it. `utils/sort.ts` now holds only a filter, so it is renamed to `utils/filter.ts`.
1 parent 9c102f2 commit bae8c9c

4 files changed

Lines changed: 19 additions & 69 deletions

File tree

apps/sim/app/workspace/[workspaceId]/knowledge/components/constants.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,3 @@ export const dropdownContentClass =
55
'w-[220px] rounded-lg border-[var(--surface-6)] bg-[var(--white)] p-0 shadow-xs dark:border-[var(--border-muted)] dark:bg-[var(--surface-2)]'
66

77
export const commandListClass = 'overflow-y-auto overflow-x-hidden'
8-
9-
export type SortOption = 'name' | 'createdAt' | 'updatedAt' | 'docCount'
10-
export type SortOrder = 'asc' | 'desc'
11-
12-
export const SORT_OPTIONS = [
13-
{ value: 'updatedAt-desc', label: 'Last Updated' },
14-
{ value: 'createdAt-desc', label: 'Newest First' },
15-
{ value: 'createdAt-asc', label: 'Oldest First' },
16-
{ value: 'name-asc', label: 'Name (A-Z)' },
17-
{ value: 'name-desc', label: 'Name (Z-A)' },
18-
{ value: 'docCount-desc', label: 'Most Documents' },
19-
{ value: 'docCount-asc', label: 'Least Documents' },
20-
] as const

apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ import {
5757
knowledgeSortParams,
5858
knowledgeUrlKeys,
5959
} from '@/app/workspace/[workspaceId]/knowledge/search-params'
60-
import { filterKnowledgeBases } from '@/app/workspace/[workspaceId]/knowledge/utils/sort'
60+
import { filterKnowledgeBases } from '@/app/workspace/[workspaceId]/knowledge/utils/filter'
6161
import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider'
6262
import { useContextMenu } from '@/app/workspace/[workspaceId]/w/components/sidebar/hooks'
6363
import { CONNECTOR_META_REGISTRY } from '@/connectors/registry'
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import type { KnowledgeBaseData } from '@/lib/knowledge/types'
2+
3+
/**
4+
* Filter knowledge bases by search query
5+
*/
6+
export function filterKnowledgeBases(
7+
knowledgeBases: KnowledgeBaseData[],
8+
searchQuery: string
9+
): KnowledgeBaseData[] {
10+
if (!searchQuery.trim()) {
11+
return knowledgeBases
12+
}
13+
14+
const query = searchQuery.trim().toLowerCase()
15+
return knowledgeBases.filter(
16+
(kb) => kb.name.toLowerCase().includes(query) || kb.description?.toLowerCase().includes(query)
17+
)
18+
}

apps/sim/app/workspace/[workspaceId]/knowledge/utils/sort.ts

Lines changed: 0 additions & 55 deletions
This file was deleted.

0 commit comments

Comments
 (0)