fix(pi): wait on required checks before optional failures

Author: Bill Leoutsakos

apps/sim/executor/handlers/pi/babysit-backend.test.ts

@@ -401,17 +401,23 @@ describe('runBabysitPiWithOptions', () => {
     expect(runCalls.some(({ command }) => command.includes('CURRENT_DIGEST='))).toBe(false)
   })
 
-  it('waits for pending checks without consuming an agent round', async () => {
+  it('waits for pending required checks despite optional failures without consuming a round', async () => {
     const pendingCheck = {
       ...failingCheck,
       disposition: 'pending' as const,
       status: 'IN_PROGRESS',
       conclusion: null,
     }
+    const optionalFailure = {
+      ...failingCheck,
+      key: 'check:optional-lint',
+      name: 'optional-lint',
+      required: false,
+    }
     const pendingChecks = {
       ...failingChecks,
-      checks: [pendingCheck],
-      failing: [],
+      checks: [pendingCheck, optionalFailure],
+      failing: [optionalFailure],
       pending: [pendingCheck],
       blockingFailing: [],
       blockingPending: [pendingCheck],

apps/sim/executor/handlers/pi/babysit-backend.ts

@@ -650,7 +650,8 @@ export async function runBabysitPiWithOptions(
           return resultFor(totals, 'startup_failure', progress, threadsClean, false)
         }
 
-        const needsAgent = latestThreads!.actionable.length > 0 || latestChecks!.failing.length > 0
+        const needsAgent =
+          latestThreads!.actionable.length > 0 || latestChecks!.blockingFailing.length > 0
         if (!needsAgent) {
           const remaining = lifetime - (Date.now() - startedAt)
           if (remaining <= options.roundWaitMs + MIN_ROUND_BUDGET_MS) {