refactor(testing): share the drizzle condition-tree helpers

Asserting on WHERE clauses is the only way to pin a filter the row-queue mocks
cannot enforce — a mock returns whatever was queued regardless of the predicate
— so this pattern spreads to every test that guards a query's scoping. It had
reached five local copies of the same flatten/has pair, four of them added by
the tests in this branch.

Moved to @sim/testing beside createMockSqlOperators, whose output shape they
parse, so the helper and the node types it depends on live together.

Author: waleedlatif1

apps/sim/app/api/v1/admin/workspaces/[id]/folders/route.test.ts

@@ -4,6 +4,7 @@
 import {
   createMockRequest,
   dbChainMockFns,
+  flattenMockConditions,
   queueTableRows,
   resetDbChainMock,
   schemaMock,
@@ -32,16 +33,6 @@ function listRequest() {
   )
 }
 
-/** Flattens the nested `and(...)` objects the drizzle operator mocks produce. */
-function flattenConditions(condition: unknown): Array<Record<string, unknown>> {
-  if (!condition || typeof condition !== 'object') return []
-  const node = condition as Record<string, unknown>
-  if (node.type === 'and' && Array.isArray(node.conditions)) {
-    return node.conditions.flatMap(flattenConditions)
-  }
-  return [node]
-}
-
 describe('admin workspace folders GET', () => {
   beforeEach(() => {
     vi.clearAllMocks()
@@ -67,7 +58,7 @@ describe('admin workspace folders GET', () => {
       // Asserted on the COLUMN: `resourceType`/`workspaceId` are eq nodes, so a bare
       // "some isNull exists" check could pass on an unrelated clause.
       expect(
-        flattenConditions(where).some(
+        flattenMockConditions(where).some(
           (node) => node.type === 'isNull' && node.column === schemaMock.folder.deletedAt
         )
       ).toBe(true)
@@ -82,7 +73,7 @@ describe('admin workspace folders GET', () => {
     await GET(listRequest(), routeContext)
 
     const where = dbChainMockFns.where.mock.calls[1]?.[0]
-    const nodes = flattenConditions(where)
+    const nodes = flattenMockConditions(where)
     expect(nodes.some((n) => n.type === 'eq' && n.right === WORKSPACE_ID)).toBe(true)
     expect(nodes.some((n) => n.type === 'eq' && n.right === 'workflow')).toBe(true)
   })

apps/sim/lib/folders/cascade.test.ts

@@ -1,6 +1,7 @@
 /**
  * @vitest-environment node
  */
+import { flattenMockConditions, hasMockCondition } from '@sim/testing'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import {
   archiveFolderCascade,
@@ -81,23 +82,6 @@ function makeConfig(overrides: Partial<FolderResourceConfig> = {}): FolderResour
   }
 }
 
-/** Flattens the nested `and(...)` objects the drizzle operator mocks produce. */
-function flattenConditions(condition: unknown): Array<Record<string, unknown>> {
-  if (!condition || typeof condition !== 'object') return []
-  const node = condition as Record<string, unknown>
-  if (node.type === 'and' && Array.isArray(node.conditions)) {
-    return node.conditions.flatMap(flattenConditions)
-  }
-  return [node]
-}
-
-function hasCondition(
-  condition: unknown,
-  predicate: (node: Record<string, unknown>) => boolean
-): boolean {
-  return flattenConditions(condition).some(predicate)
-}
-
 const TIMESTAMP = new Date('2026-01-01T00:00:00.000Z')
 const NOW = new Date('2026-02-02T00:00:00.000Z')
 
@@ -138,7 +122,7 @@ describe('collectCascadeSubtreeIds', () => {
 
     expect(ids).toEqual(['root', 'child', 'grandchild'])
     // Either still active, or carrying this cascade's own stamp — never another snapshot's.
-    const clause = flattenConditions(selectCalls[0].where).find((node) => node.type === 'or')
+    const clause = flattenMockConditions(selectCalls[0].where).find((node) => node.type === 'or')
     expect(clause).toBeDefined()
     const branches = (clause?.conditions ?? []) as Array<Record<string, unknown>>
     expect(branches.some((node) => node.type === 'isNull')).toBe(true)
@@ -150,8 +134,10 @@ describe('collectCascadeSubtreeIds', () => {
 
     await collectCascadeSubtreeIds(tx, 'ws-1', 'knowledge_base', 'root', TIMESTAMP)
 
-    expect(hasCondition(selectCalls[0].where, (node) => node.right === 'knowledge_base')).toBe(true)
-    expect(hasCondition(selectCalls[0].where, (node) => node.right === 'ws-1')).toBe(true)
+    expect(hasMockCondition(selectCalls[0].where, (node) => node.right === 'knowledge_base')).toBe(
+      true
+    )
+    expect(hasMockCondition(selectCalls[0].where, (node) => node.right === 'ws-1')).toBe(true)
   })
 })
 
@@ -169,7 +155,7 @@ describe('collectArchivedSubtreeIds', () => {
     const ids = await collectArchivedSubtreeIds(tx, 'ws-1', 'table', 'root', TIMESTAMP)
 
     expect(ids).toEqual(['root', 'child'])
-    expect(hasCondition(selectCalls[0].where, (node) => node.right === TIMESTAMP)).toBe(true)
+    expect(hasMockCondition(selectCalls[0].where, (node) => node.right === TIMESTAMP)).toBe(true)
   })
 
   it('terminates on a parent cycle instead of recursing forever', async () => {
@@ -230,7 +216,7 @@ describe('archiveFolderCascade', () => {
     await archiveFolderCascade(tx, makeConfig(), 'ws-1', ['root'], TIMESTAMP)
 
     for (const call of updateCalls) {
-      expect(hasCondition(call.where, (node) => node.type === 'isNull')).toBe(true)
+      expect(hasMockCondition(call.where, (node) => node.type === 'isNull')).toBe(true)
     }
   })
 
@@ -299,7 +285,7 @@ describe('restoreFolderCascade', () => {
     expect(updateCalls[1].set).toEqual({ archivedAt: null, updatedAt: NOW })
     expect(updateCalls[2].table).toBe(DEPENDENT_TABLE)
     expect(
-      hasCondition(updateCalls[2].where, (node) => {
+      hasMockCondition(updateCalls[2].where, (node) => {
         return node.type === 'inArray' && Array.isArray(node.values) && node.values.length === 2
       })
     ).toBe(true)
@@ -353,7 +339,7 @@ describe('restoreFolderCascade', () => {
     )
 
     for (const call of updateCalls) {
-      expect(hasCondition(call.where, (node) => node.right === TIMESTAMP)).toBe(true)
+      expect(hasMockCondition(call.where, (node) => node.right === TIMESTAMP)).toBe(true)
     }
   })
 })
@@ -373,7 +359,7 @@ describe('restoreFolderRows', () => {
 
     expect(folders).toBe(2)
     expect(updateCalls).toHaveLength(1)
-    expect(hasCondition(updateCalls[0].where, (node) => node.right === TIMESTAMP)).toBe(true)
+    expect(hasMockCondition(updateCalls[0].where, (node) => node.right === TIMESTAMP)).toBe(true)
   })
 })
 

apps/sim/lib/folders/lifecycle.test.ts

@@ -5,6 +5,7 @@ import {
   auditMock,
   dbChainMock,
   dbChainMockFns,
+  flattenMockConditions,
   queueTableRows,
   resetDbChainMock,
   schemaMock,
@@ -67,16 +68,6 @@ import { createFolder, deleteFolder, restoreFolder, updateFolder } from '@/lib/f
 
 const CHILD_TABLE = { name: 'child_table' }
 
-/** Flattens the nested `and(...)` objects the drizzle operator mocks produce. */
-function flattenConditions(condition: unknown): Array<Record<string, unknown>> {
-  if (!condition || typeof condition !== 'object') return []
-  const node = condition as Record<string, unknown>
-  if (node.type === 'and' && Array.isArray(node.conditions)) {
-    return node.conditions.flatMap(flattenConditions)
-  }
-  return [node]
-}
-
 /** Stand-in for the per-resource config; each test declares only the deltas it exercises. */
 function setConfig(overrides: Record<string, unknown> = {}) {
   resourceConfig.current = {
@@ -266,12 +257,12 @@ describe('createFolder', () => {
     // parent condition is itself `isNull(parentId)`, so a presence-only check passes with the
     // soft-delete filter deleted. That made the first version of this test vacuous.
     expect(
-      flattenConditions(folderWhere).some(
+      flattenMockConditions(folderWhere).some(
         (node) => node.type === 'isNull' && node.column === schemaMock.folder.deletedAt
       )
     ).toBe(true)
     expect(
-      flattenConditions(childWhere).some(
+      flattenMockConditions(childWhere).some(
         (node) => node.type === 'isNull' && node.column === 'child.archivedAt'
       )
     ).toBe(true)

apps/sim/lib/folders/naming.test.ts

@@ -1,6 +1,7 @@
 /**
  * @vitest-environment node
  */
+import { flattenMockConditions, hasMockCondition } from '@sim/testing'
 import { describe, expect, it } from 'vitest'
 import { deduplicateFolderName } from '@/lib/folders/naming'
 
@@ -27,23 +28,6 @@ function makeTx(siblingNames: string[]) {
   return { tx: tx as never, selectCalls }
 }
 
-/** Flattens the nested `and(...)` objects the drizzle operator mocks produce. */
-function flattenConditions(condition: unknown): Array<Record<string, unknown>> {
-  if (!condition || typeof condition !== 'object') return []
-  const node = condition as Record<string, unknown>
-  if (node.type === 'and' && Array.isArray(node.conditions)) {
-    return node.conditions.flatMap(flattenConditions)
-  }
-  return [node]
-}
-
-function hasCondition(
-  condition: unknown,
-  predicate: (node: Record<string, unknown>) => boolean
-): boolean {
-  return flattenConditions(condition).some(predicate)
-}
-
 /**
  * The suffix shape is a cross-surface contract: the client's `nextUntitledFolderName` and
  * migration 0272's backfill both produce `"<name> (N)"` starting at (1). A server-side drift
@@ -101,11 +85,13 @@ describe('deduplicateFolderName', () => {
 
       expect(selectCalls).toHaveLength(1)
       const { where } = selectCalls[0]
-      expect(hasCondition(where, (n) => n.type === 'eq' && n.right === 'ws-1')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'eq' && n.right === 'ws-1')).toBe(true)
       // Without this a knowledge-base folder would count table folders as siblings.
-      expect(hasCondition(where, (n) => n.type === 'eq' && n.right === 'knowledge_base')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'eq' && n.right === 'knowledge_base')).toBe(
+        true
+      )
       // Root scope must be IS NULL, not eq(null), which matches nothing in SQL.
-      expect(hasCondition(where, (n) => n.type === 'isNull')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'isNull')).toBe(true)
     })
 
     it('scopes to the given parent when nested', async () => {
@@ -114,7 +100,7 @@ describe('deduplicateFolderName', () => {
       await deduplicateFolderName(tx, 'ws-1', 'parent-1', 'Reports', 'workflow')
 
       expect(
-        hasCondition(selectCalls[0].where, (n) => n.type === 'eq' && n.right === 'parent-1')
+        hasMockCondition(selectCalls[0].where, (n) => n.type === 'eq' && n.right === 'parent-1')
       ).toBe(true)
     })
 
@@ -126,7 +112,7 @@ describe('deduplicateFolderName', () => {
       await deduplicateFolderName(tx, 'ws-1', null, 'Reports', 'workflow')
 
       expect(
-        flattenConditions(selectCalls[0].where).filter((n) => n.type === 'isNull')
+        flattenMockConditions(selectCalls[0].where).filter((n) => n.type === 'isNull')
       ).toHaveLength(2)
     })
   })

apps/sim/lib/folders/queries.test.ts

@@ -1,7 +1,13 @@
 /**
  * @vitest-environment node
  */
-import { dbChainMockFns, queueTableRows, resetDbChainMock, schemaMock } from '@sim/testing'
+import {
+  dbChainMockFns,
+  hasMockCondition,
+  queueTableRows,
+  resetDbChainMock,
+  schemaMock,
+} from '@sim/testing'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import {
   findActiveFolder,
@@ -11,23 +17,6 @@ import {
   wouldCreateFolderCycle,
 } from '@/lib/folders/queries'
 
-/** Flattens the nested `and(...)` objects the drizzle operator mocks produce. */
-function flattenConditions(condition: unknown): Array<Record<string, unknown>> {
-  if (!condition || typeof condition !== 'object') return []
-  const node = condition as Record<string, unknown>
-  if (node.type === 'and' && Array.isArray(node.conditions)) {
-    return node.conditions.flatMap(flattenConditions)
-  }
-  return [node]
-}
-
-function hasCondition(
-  condition: unknown,
-  predicate: (node: Record<string, unknown>) => boolean
-): boolean {
-  return flattenConditions(condition).some(predicate)
-}
-
 /** The condition passed to the Nth `.where()` of this test. */
 function whereAt(index: number): unknown {
   return dbChainMockFns.where.mock.calls[index]?.[0]
@@ -68,11 +57,13 @@ describe('folder queries', () => {
       await findActiveFolder('f-1', 'ws-1', 'knowledge_base')
 
       const where = whereAt(0)
-      expect(hasCondition(where, (n) => n.type === 'eq' && n.right === 'f-1')).toBe(true)
-      expect(hasCondition(where, (n) => n.type === 'eq' && n.right === 'ws-1')).toBe(true)
-      expect(hasCondition(where, (n) => n.type === 'eq' && n.right === 'knowledge_base')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'eq' && n.right === 'f-1')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'eq' && n.right === 'ws-1')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'eq' && n.right === 'knowledge_base')).toBe(
+        true
+      )
       // Archived folders are not valid destinations — a row filed under one is unreachable.
-      expect(hasCondition(where, (n) => n.type === 'isNull')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'isNull')).toBe(true)
     })
 
     it('returns null when no row matches', async () => {
@@ -98,7 +89,7 @@ describe('folder queries', () => {
 
       expect(dbChainMockFns.where.mock.calls.length).toBeGreaterThanOrEqual(2)
       for (const [where] of dbChainMockFns.where.mock.calls) {
-        expect(hasCondition(where, (n) => n.type === 'eq' && n.right === 'table')).toBe(true)
+        expect(hasMockCondition(where, (n) => n.type === 'eq' && n.right === 'table')).toBe(true)
       }
     })
 
@@ -162,10 +153,10 @@ describe('folder queries', () => {
       await listFoldersForWorkspace('ws-1', 'active', 'table')
 
       const where = whereAt(0)
-      expect(hasCondition(where, (n) => n.type === 'eq' && n.right === 'ws-1')).toBe(true)
-      expect(hasCondition(where, (n) => n.type === 'eq' && n.right === 'table')).toBe(true)
-      expect(hasCondition(where, (n) => n.type === 'isNull')).toBe(true)
-      expect(hasCondition(where, (n) => n.type === 'isNotNull')).toBe(false)
+      expect(hasMockCondition(where, (n) => n.type === 'eq' && n.right === 'ws-1')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'eq' && n.right === 'table')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'isNull')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'isNotNull')).toBe(false)
     })
 
     it('inverts the soft-delete filter for the archived scope', async () => {
@@ -174,8 +165,8 @@ describe('folder queries', () => {
       await listFoldersForWorkspace('ws-1', 'archived', 'workflow')
 
       const where = whereAt(0)
-      expect(hasCondition(where, (n) => n.type === 'isNotNull')).toBe(true)
-      expect(hasCondition(where, (n) => n.type === 'isNull')).toBe(false)
+      expect(hasMockCondition(where, (n) => n.type === 'isNotNull')).toBe(true)
+      expect(hasMockCondition(where, (n) => n.type === 'isNull')).toBe(false)
     })
   })
 

packages/testing/src/mocks/database.mock.ts

@@ -421,3 +421,33 @@ export const drizzleOrmMock = {
   getTableColumns: vi.fn((table: Record<string, unknown>) => ({ ...table })),
   ...createMockSqlOperators(),
 }
+
+/**
+ * Condition nodes produced by `createMockSqlOperators` — `{ type: 'eq', left, right }`,
+ * `{ type: 'isNull', column }`, and so on.
+ */
+export type MockCondition = Record<string, unknown>
+
+/**
+ * Flattens the nested `and(...)` trees `createMockSqlOperators` builds into a flat node list.
+ *
+ * Tests assert on WHERE clauses to pin filters the row-queue mocks cannot enforce — a mock
+ * returns whatever was queued regardless of the predicate, so "the query filters on X" is only
+ * testable by inspecting the condition tree. `and()` nests arbitrarily, hence the flatten.
+ */
+export function flattenMockConditions(condition: unknown): MockCondition[] {
+  if (!condition || typeof condition !== 'object') return []
+  const node = condition as MockCondition
+  if (node.type === 'and' && Array.isArray(node.conditions)) {
+    return node.conditions.flatMap(flattenMockConditions)
+  }
+  return [node]
+}
+
+/** True when any node in `condition` satisfies `predicate`. */
+export function hasMockCondition(
+  condition: unknown,
+  predicate: (node: MockCondition) => boolean
+): boolean {
+  return flattenMockConditions(condition).some(predicate)
+}

packages/testing/src/mocks/index.ts

@@ -45,6 +45,9 @@ export {
   dbChainMock,
   dbChainMockFns,
   drizzleOrmMock,
+  flattenMockConditions,
+  hasMockCondition,
+  type MockCondition,
   queueTableRows,
   resetDbChainMock,
 } from './database.mock'