refactor(knowledge): sever the shell's route context, in place

Same ordering that made the table move safe: the behavioural edits land first,
as a diff against files that have not moved.

- `useParams` -> `knowledgeWorkspaceId(source)`. The shell took `workspaceId?`
  optionally and fell back to route params, which the page relied on — so the
  fallback was load-bearing, and it is what stopped this surface existing more
  than once per page.
- `useRouter` -> `onNavigate`. Three pushes: the document detail route, the
  post-delete redirect, and the breadcrumb root. The latter two already went
  through `hrefFor({ to: 'list' })`; the first now goes through a new
  `knowledgeDocumentHref`, which lives in a per-kind module because a document
  is not a `ResourceKind` — it has no view, no grants and no share surface, so
  it cannot be spelled through `hrefFor({ to: 'resource' })`.
- `useUserPermissionsContext` -> `grants`. 13 reads, including two of the form
  `canEdit || isLoading` that gate whether a breadcrumb dropdown renders at all.
  Those become `grants.write || !grants.settled` — the exact pattern `settled`
  was added for, and without it the caret would have popped in after load
  instead of rendering disabled.

Three supporting relocations, all pure moves:
- `knowledge/components/icons` deleted — byte-identical to
  `@/components/icons/document-icons`, confirmed with `diff`.
- `use-knowledge-upload` -> `@/hooks/kb/`.
- `useContextMenu` -> `components/anchored-context-menu/`, beside the component
  every one of its 13 consumers pairs it with.

Also makes table-view's internal imports absolute. They arrived relative with
the move and I did not rewrite them; log-view and knowledge-view have zero
relative imports, so table-view was the outlier against the rule this PR
documents. (file-view has 83 and is left alone — pre-existing, and not worth
83 files of churn here.)

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/files/files.tsx

@@ -24,6 +24,7 @@ import { getErrorMessage, toError } from '@sim/utils/errors'
 import { useParams, useRouter } from 'next/navigation'
 import { useQueryStates } from 'nuqs'
 import { usePostHog } from 'posthog-js/react'
+import { useContextMenu } from '@/components/anchored-context-menu'
 import { getDocumentIcon } from '@/components/icons/document-icons'
 import type { PreviewMode } from '@/components/resources/file-view'
 import {
@@ -106,7 +107,6 @@ import {
   filesUrlKeys,
 } from '@/app/workspace/[workspaceId]/files/search-params'
 import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider'
-import { useContextMenu } from '@/app/workspace/[workspaceId]/w/components/sidebar/hooks'
 import { usePinItem, usePinnedIds, useUnpinItem } from '@/hooks/queries/pinned-items'
 import { useWorkspaceMembersQuery, type WorkspaceMember } from '@/hooks/queries/workspace'
 import {

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/terminal-session/terminal-session.tsx

@@ -39,6 +39,7 @@ import { type IBufferRange, Terminal } from '@xterm/xterm'
 import { useTheme } from 'next-themes'
 import '@xterm/xterm/css/xterm.css'
 import type { TerminalTabState, TerminalTabsState } from '@sim/terminal-protocol'
+import { useContextMenu } from '@/components/anchored-context-menu'
 import { SIM_RESOURCE_DRAG_TYPE } from '@/lib/copilot/resource-types'
 import { TERMINAL_SESSION_RESOURCE_ID } from '@/lib/copilot/resources/types'
 import { getDesktopBridge } from '@/lib/desktop'
@@ -68,7 +69,6 @@ import {
 import { useMothershipResources } from '@/app/workspace/[workspaceId]/home/components/mothership-resources-context'
 import { TerminalContextMenu } from '@/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/terminal-session/terminal-context-menu'
 import { ContextMenu } from '@/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/context-menu/context-menu'
-import { useContextMenu } from '@/app/workspace/[workspaceId]/w/components/sidebar/hooks'
 import { useDesktopPreferenceMutation } from '@/hooks/use-desktop-preference-mutation'
 import { useCopilotTerminalStore } from '@/stores/copilot-terminal/store'
 import type { ChatContext, TerminalTextSelection } from '@/stores/panel'

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/resource-content.tsx

@@ -270,6 +270,11 @@ export const ResourceContent = memo(function ResourceContent({
     error: logError,
   } = useLogDetail(resource.id, workspaceId, { enabled: isLogResource })
 
+  const knowledgeSource = useMemo(
+    () => workspaceSource({ kind: 'knowledge' as const, workspaceId, resourceId: resource.id }),
+    [workspaceId, resource.id]
+  )
+
   const tableSource = useMemo(
     () => workspaceSource({ kind: 'table' as const, workspaceId, resourceId: resource.id }),
     [workspaceId, resource.id]
@@ -380,7 +385,9 @@ export const ResourceContent = memo(function ResourceContent({
           key={resource.id}
           id={resource.id}
           knowledgeBaseName={resource.title}
-          workspaceId={workspaceId}
+          source={knowledgeSource}
+          grants={grants}
+          onNavigate={navigate}
           host='panel'
         />
       )

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx

@@ -7,6 +7,8 @@ import { createLogger } from '@sim/logger'
 import { truncate } from '@sim/utils/string'
 import { useParams, useRouter } from 'next/navigation'
 import { useQueryStates } from 'nuqs'
+import { useContextMenu } from '@/components/anchored-context-menu'
+import { getDocumentIcon } from '@/components/icons/document-icons'
 import { SearchHighlight } from '@/components/resources/knowledge-view'
 import type { ChunkData } from '@/lib/knowledge/types'
 import { formatTokenCount } from '@/lib/tokenization'
@@ -34,9 +36,7 @@ import {
   documentUrlKeys,
 } from '@/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/search-params'
 import { ActionBar } from '@/app/workspace/[workspaceId]/knowledge/[id]/components'
-import { getDocumentIcon } from '@/app/workspace/[workspaceId]/knowledge/components'
 import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider'
-import { useContextMenu } from '@/app/workspace/[workspaceId]/w/components/sidebar/hooks'
 import { CONNECTOR_META_REGISTRY } from '@/connectors/registry'
 import { useDocument, useDocumentChunks, useKnowledgeBase } from '@/hooks/kb/use-knowledge'
 import {

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/add-documents-modal/add-documents-modal.tsx

@@ -17,7 +17,7 @@ import { createLogger } from '@sim/logger'
 import { useParams } from 'next/navigation'
 import { formatFileSize, validateKnowledgeBaseFile } from '@/lib/uploads/utils/file-utils'
 import { ACCEPT_ATTRIBUTE } from '@/lib/uploads/utils/validation'
-import { useKnowledgeUpload } from '@/app/workspace/[workspaceId]/knowledge/hooks/use-knowledge-upload'
+import { useKnowledgeUpload } from '@/hooks/kb/use-knowledge-upload'
 
 const logger = createLogger('AddDocumentsModal')
 

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/base-tags-modal/base-tags-modal.tsx

@@ -16,9 +16,9 @@ import {
   Trash,
 } from '@sim/emcn'
 import { createLogger } from '@sim/logger'
+import { getDocumentIcon } from '@/components/icons/document-icons'
 import type { TagUsageData } from '@/lib/api/contracts/knowledge'
 import { SUPPORTED_FIELD_TYPES, TAG_SLOT_CONFIG } from '@/lib/knowledge/constants'
-import { getDocumentIcon } from '@/app/workspace/[workspaceId]/knowledge/components'
 import {
   type TagDefinition,
   useKnowledgeBaseTagDefinitions,

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/knowledge-base.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
+import { useCallback, useEffect, useRef, useState } from 'react'
 import {
   ChipConfirmModal,
   type ChipConfirmTextSegment,
@@ -11,8 +11,8 @@ import {
 } from '@sim/emcn'
 import { Database, Pencil, Plus, TagIcon } from '@sim/emcn/icons'
 import { createLogger } from '@sim/logger'
-import { useParams, useRouter } from 'next/navigation'
 import { usePostHog } from 'posthog-js/react'
+import { useContextMenu } from '@/components/anchored-context-menu'
 import { Resource } from '@/components/resource'
 import {
   type KnowledgeDocumentList,
@@ -35,8 +35,6 @@ import {
   RenameDocumentModal,
 } from '@/app/workspace/[workspaceId]/knowledge/[id]/components'
 import { useKnowledgeListState } from '@/app/workspace/[workspaceId]/knowledge/[id]/hooks/use-knowledge-list-state'
-import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider'
-import { useContextMenu } from '@/app/workspace/[workspaceId]/w/components/sidebar/hooks'
 import {
   useKnowledgeBase,
   useKnowledgeBaseDocuments,
@@ -53,7 +51,13 @@ import {
 } from '@/hooks/queries/kb/knowledge'
 import { useInlineRename } from '@/hooks/use-inline-rename'
 import { useOAuthReturnForKBConnectors } from '@/hooks/use-oauth-return'
-import { grantsFromPermissions, type ResourceHost, workspaceSource } from '@/resources'
+import {
+  knowledgeDocumentHref,
+  knowledgeWorkspaceId,
+  type ResourceGrants,
+  type ResourceHost,
+  type ResourceSource,
+} from '@/resources'
 
 const logger = createLogger('KnowledgeBase')
 
@@ -62,7 +66,15 @@ const DOCUMENTS_PER_PAGE = 50
 interface KnowledgeBaseProps {
   id: string
   knowledgeBaseName?: string
-  workspaceId?: string
+  /**
+   * Where the knowledge base comes from and by what address. Built by the host's
+   * client shell; a source carries closures and cannot cross the RSC boundary.
+   */
+  source: ResourceSource<'knowledge'>
+  /** What this viewer may do. `write` is `canEdit`; `settled` says whether it is final. */
+  grants: ResourceGrants
+  /** The router half of `host`; targets come from `source.hrefFor`. */
+  onNavigate?: (path: string) => void
   /**
    * Who owns the URL around this surface. The knowledge page owns it; the
    * mothership panel does not, and its document-list view-state stays local so
@@ -81,12 +93,12 @@ interface KnowledgeBaseProps {
 export function KnowledgeBase({
   id,
   knowledgeBaseName: passedKnowledgeBaseName,
-  workspaceId: propWorkspaceId,
+  source,
+  grants,
+  onNavigate,
   host,
 }: KnowledgeBaseProps) {
-  const params = useParams()
-  const workspaceId = propWorkspaceId || (params.workspaceId as string)
-  const router = useRouter()
+  const workspaceId = knowledgeWorkspaceId(source) ?? ''
   const posthog = usePostHog()
 
   useEffect(() => {
@@ -98,7 +110,6 @@ export function KnowledgeBase({
 
   useOAuthReturnForKBConnectors(id)
   const { removeKnowledgeBase } = useKnowledgeBasesList(workspaceId, { enabled: false })
-  const userPermissions = useUserPermissionsContext()
 
   const { mutate: updateDocumentMutation, mutateAsync: updateDocumentAsync } = useUpdateDocument()
   const { mutate: deleteDocumentMutation } = useDeleteDocument()
@@ -225,12 +236,6 @@ export function KnowledgeBase({
 
   const totalPages = Math.ceil(pagination.total / pagination.limit)
 
-  const source = useMemo(
-    () => workspaceSource({ kind: 'knowledge', workspaceId, resourceId: id }),
-    [workspaceId, id]
-  )
-  const grants = useMemo(() => grantsFromPermissions(userPermissions), [userPermissions])
-
   /**
    * Checks for documents with stale processing states and marks them as failed
    */
@@ -408,7 +413,8 @@ export function KnowledgeBase({
       kbName: knowledgeBaseName,
       docName: document?.filename || 'Document',
     })
-    router.push(`/workspace/${workspaceId}/knowledge/${id}/${docId}?${urlParams.toString()}`)
+    const documentHref = knowledgeDocumentHref(source, docId)
+    if (documentHref) onNavigate?.(`${documentHref}?${urlParams.toString()}`)
   }
 
   /**
@@ -423,7 +429,7 @@ export function KnowledgeBase({
         onSuccess: () => {
           removeKnowledgeBase(id)
           const list = source.hrefFor({ to: 'list' })
-          if (list) router.push(list)
+          if (list) onNavigate?.(list)
         },
       }
     )
@@ -625,7 +631,7 @@ export function KnowledgeBase({
       icon: Database,
       onClick: () => {
         const list = source.hrefFor({ to: 'list' })
-        if (list) router.push(list)
+        if (list) onNavigate?.(list)
       },
     },
     {
@@ -642,24 +648,24 @@ export function KnowledgeBase({
           }
         : undefined,
       dropdownItems: [
-        ...(userPermissions.canEdit || userPermissions.isLoading
+        ...(grants.write || !grants.settled
           ? [
               {
                 label: 'Rename',
                 icon: Pencil,
-                disabled: !userPermissions.canEdit,
+                disabled: !grants.write,
                 onClick: () => kbRename.startRename(id, knowledgeBaseName),
               },
               {
                 label: 'Tags',
                 icon: TagIcon,
-                disabled: !userPermissions.canEdit,
+                disabled: !grants.write,
                 onClick: () => setShowTagsModal(true),
               },
               {
                 label: 'Delete',
                 icon: Trash,
-                disabled: !userPermissions.canEdit,
+                disabled: !grants.write,
                 onClick: () => setShowDeleteDialog(true),
               },
             ]
@@ -669,12 +675,12 @@ export function KnowledgeBase({
   ]
 
   const headerActions: ResourceAction[] = [
-    ...(userPermissions.canEdit || userPermissions.isLoading
+    ...(grants.write || !grants.settled
       ? [
           {
             text: 'New connector',
             icon: Plus,
-            disabled: !userPermissions.canEdit,
+            disabled: !grants.write,
             onSelect: () => setShowAddConnectorModal(true),
           },
         ]
@@ -741,7 +747,7 @@ export function KnowledgeBase({
               text: 'New documents',
               icon: Plus,
               onSelect: handleAddDocuments,
-              disabled: userPermissions.canEdit !== true,
+              disabled: !grants.write,
               variant: 'primary',
             },
           ]}
@@ -915,7 +921,7 @@ export function KnowledgeBase({
             knowledgeBaseId={id}
             connectors={connectors}
             isLoading={isLoadingConnectors}
-            canEdit={userPermissions.canEdit}
+            canEdit={grants.write}
             className='mt-0'
           />
         </ChipModalBody>
@@ -964,7 +970,7 @@ export function KnowledgeBase({
             : undefined
         }
         onViewTags={
-          contextMenuDocument && selectedDocuments.size === 1 && userPermissions.canEdit
+          contextMenuDocument && selectedDocuments.size === 1 && grants.write
             ? () => handleViewDocumentTags(contextMenuDocument)
             : undefined
         }
@@ -976,16 +982,14 @@ export function KnowledgeBase({
             : undefined
         }
         onAddDocument={handleAddDocuments}
-        disableRename={!userPermissions.canEdit}
+        disableRename={!grants.write}
         disableToggleEnabled={
-          !userPermissions.canEdit ||
+          !grants.write ||
           contextMenuDocument?.processingStatus === 'processing' ||
           contextMenuDocument?.processingStatus === 'pending'
         }
-        disableDelete={
-          !userPermissions.canEdit || contextMenuDocument?.processingStatus === 'processing'
-        }
-        disableAddDocument={!userPermissions.canEdit}
+        disableDelete={!grants.write || contextMenuDocument?.processingStatus === 'processing'}
+        disableAddDocument={!grants.write}
       />
     </>
   )

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/knowledge-route.tsx

@@ -0,0 +1,50 @@
+'use client'
+
+import { useCallback, useMemo } from 'react'
+import { useParams, useRouter } from 'next/navigation'
+import { KnowledgeBase } from '@/app/workspace/[workspaceId]/knowledge/[id]/knowledge-base'
+import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider'
+import { grantsFromPermissions, workspaceSource } from '@/resources'
+
+interface KnowledgeRouteProps {
+  id: string
+  knowledgeBaseName?: string
+}
+
+/**
+ * The knowledge page's client shell: it resolves the axes the route can supply
+ * and mounts the surface.
+ *
+ * Exists because `page.tsx` is a Server Component and both `grants` and a
+ * `ResourceSource` are client-only — grants comes from a React context, and a
+ * source carries closures that cannot cross the RSC boundary.
+ *
+ * Reading `useParams()` here is legitimate where it was not inside the surface
+ * itself: a route shell exists exactly once per page by definition, whereas the
+ * knowledge base is also mounted in the chat panel beside it. Mirrors
+ * `tables/[tableId]/table-route.tsx` and `files/[fileId]/view/fullscreen-file-view.tsx`.
+ */
+export function KnowledgeRoute({ id, knowledgeBaseName }: KnowledgeRouteProps) {
+  const params = useParams()
+  const workspaceId = typeof params?.workspaceId === 'string' ? params.workspaceId : ''
+  const permissions = useUserPermissionsContext()
+  const router = useRouter()
+
+  const source = useMemo(
+    () => workspaceSource({ kind: 'knowledge' as const, workspaceId, resourceId: id }),
+    [workspaceId, id]
+  )
+  const grants = useMemo(() => grantsFromPermissions(permissions), [permissions])
+  const navigate = useCallback((path: string) => router.push(path), [router])
+
+  return (
+    <KnowledgeBase
+      id={id}
+      knowledgeBaseName={knowledgeBaseName}
+      source={source}
+      grants={grants}
+      onNavigate={navigate}
+      host='page'
+    />
+  )
+}

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/page.tsx

@@ -1,6 +1,6 @@
 import { Suspense } from 'react'
 import type { Metadata } from 'next'
-import { KnowledgeBase } from '@/app/workspace/[workspaceId]/knowledge/[id]/knowledge-base'
+import { KnowledgeRoute } from '@/app/workspace/[workspaceId]/knowledge/[id]/knowledge-route'
 
 interface PageProps {
   params: Promise<{
@@ -21,7 +21,7 @@ export default async function KnowledgeBasePage({ params, searchParams }: PagePr
 
   return (
     <Suspense fallback={null}>
-      <KnowledgeBase id={id} knowledgeBaseName={kbName || 'Knowledge Base'} host='page' />
+      <KnowledgeRoute id={id} knowledgeBaseName={kbName || 'Knowledge Base'} />
     </Suspense>
   )
 }

apps/sim/app/workspace/[workspaceId]/knowledge/components/create-base-modal/create-base-modal.tsx

@@ -29,7 +29,7 @@ import type { StrategyOptions } from '@/lib/chunkers/types'
 import { KNOWLEDGE_BASE_DESCRIPTION_MAX_LENGTH } from '@/lib/knowledge/constants'
 import { formatFileSize, validateKnowledgeBaseFile } from '@/lib/uploads/utils/file-utils'
 import { ACCEPT_ATTRIBUTE } from '@/lib/uploads/utils/validation'
-import { useKnowledgeUpload } from '@/app/workspace/[workspaceId]/knowledge/hooks/use-knowledge-upload'
+import { useKnowledgeUpload } from '@/hooks/kb/use-knowledge-upload'
 import { useCreateKnowledgeBase, useDeleteKnowledgeBase } from '@/hooks/queries/kb/knowledge'
 
 const logger = createLogger('CreateBaseModal')