Skip to content

Commit de1c694

Browse files
committed
fix(header): give every breadcrumb menu item an icon
The resource crumb's menu (table, knowledge base, document, file) rendered Rename/Tags/Share/Download/Delete with icons, but the folder crumb's menu rendered bare labels. The two open from adjacent segments of the same breadcrumb, so the inconsistency was visible side by side. Add the matching icons to the three folder-crumb menus.
1 parent 35fd4ef commit de1c694

3 files changed

Lines changed: 7 additions & 2 deletions

File tree

apps/sim/app/workspace/[workspaceId]/files/files.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1796,6 +1796,7 @@ export function Files() {
17961796
? [
17971797
{
17981798
label: 'Rename',
1799+
icon: Pencil,
17991800
disabled: !canEdit,
18001801
onClick: () => breadcrumbRenameRef.current.startRename(folder.id, folder.name),
18011802
},

apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
44
import type { ChipDropdownOption } from '@sim/emcn'
55
import { Button, ChipConfirmModal, ChipDropdown, Plus, Tooltip, toast } from '@sim/emcn'
6-
import { Database, FolderPlus } from '@sim/emcn/icons'
6+
import { Database, FolderPlus, Pencil, Trash } from '@sim/emcn/icons'
77
import { createLogger } from '@sim/logger'
88
import { getErrorMessage } from '@sim/utils/errors'
99
import { useParams, useRouter } from 'next/navigation'
@@ -925,13 +925,15 @@ export function Knowledge() {
925925
? [
926926
{
927927
label: 'Rename',
928+
icon: Pencil,
928929
onClick: () => {
929930
const folder = breadcrumbs[breadcrumbs.length - 1]
930931
breadcrumbRenameRef.current.startRename(folder.id, folder.name)
931932
},
932933
},
933934
{
934935
label: 'Delete',
936+
icon: Trash,
935937
onClick: () => setFolderPendingDelete(breadcrumbs[breadcrumbs.length - 1]),
936938
},
937939
]

apps/sim/app/workspace/[workspaceId]/tables/tables.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
44
import type { ComboboxOption } from '@sim/emcn'
55
import { ChipCombobox, ChipConfirmModal, Plus, toast, Upload } from '@sim/emcn'
6-
import { Columns3, FolderPlus, Rows3, Table as TableIcon } from '@sim/emcn/icons'
6+
import { Columns3, FolderPlus, Pencil, Rows3, Table as TableIcon, Trash } from '@sim/emcn/icons'
77
import { createLogger } from '@sim/logger'
88
import { getErrorMessage } from '@sim/utils/errors'
99
import { generateId } from '@sim/utils/id'
@@ -467,11 +467,13 @@ export function Tables() {
467467
return [
468468
{
469469
label: 'Rename',
470+
icon: Pencil,
470471
disabled: !canEdit,
471472
onClick: () => breadcrumbRename.startRename(folder.id, folder.name),
472473
},
473474
{
474475
label: 'Delete',
476+
icon: Trash,
475477
disabled: !canEdit,
476478
/**
477479
* The only way to delete the folder you are inside — its own row is not in the list.

0 commit comments

Comments
 (0)