refactor(quickbooks): use standard error payload handling

Bill Leoutsakos · Bill Leoutsakos · commit edec60b7ffcc · 2026-08-05T17:28:54.000-07:00
diff --git a/apps/sim/tools/index.test.ts b/apps/sim/tools/index.test.ts
@@ -2047,50 +2047,6 @@ describe('OAuth provider context propagation', () => {
     })
     expect(fetchMock).toHaveBeenCalledTimes(2)
   })
-
-  it('does not expose a non-JSON QuickBooks failure body in tool output', async () => {
-    mockGenerateInternalToken.mockResolvedValue('internal-token')
-    const fetchMock = vi.fn().mockImplementation(async (url: string) => {
-      if (url.includes('/api/auth/oauth/token')) {
-        return new Response(
-          JSON.stringify({
-            accessToken: 'fresh-access-token',
-            realmId: '123456789',
-          }),
-          { headers: { 'Content-Type': 'application/json' } }
-        )
-      }
-
-      return new Response('<html>sensitive gateway body</html>', {
-        status: 502,
-        statusText: 'Bad Gateway',
-        headers: { 'Content-Type': 'text/html' },
-      })
-    })
-    global.fetch = Object.assign(fetchMock, { preconnect: vi.fn() }) as typeof fetch
-
-    const result = await executeTool(
-      'test_quickbooks_context',
-      { credential: 'quickbooks-credential' },
-      {
-        executionContext: createToolExecutionContext({
-          userId: 'user-123',
-          workflowId: 'workflow-123',
-        }),
-      }
-    )
-
-    expect(result).toMatchObject({
-      success: false,
-      error: 'QuickBooks request failed with HTTP 502.',
-      output: {
-        status: 502,
-        statusText: 'Bad Gateway',
-        data: null,
-      },
-    })
-    expect(JSON.stringify(result)).not.toContain('sensitive gateway body')
-  })
 })
 
 describe('Copilot Env Variable Reference Resolution', () => {
diff --git a/apps/sim/tools/index.ts b/apps/sim/tools/index.ts
@@ -49,9 +49,8 @@ import type { ExecutionContext, UserFile } from '@/executor/types'
 import { resolveEnvVarReferences } from '@/executor/utils/reference-validation'
 import type { ResolvedSecretTraceRegistry } from '@/executor/utils/resolved-secret-trace-registry'
 import type { ErrorInfo } from '@/tools/error-extractors'
-import { ErrorExtractorId, extractErrorMessage } from '@/tools/error-extractors'
+import { extractErrorMessage } from '@/tools/error-extractors'
 import { HostedKeyRateLimitedError, HostedKeyUnavailableError } from '@/tools/errors'
-import { sanitizeQuickBooksFaultData } from '@/tools/quickbooks/fault'
 import type {
   BYOKProviderId,
   OAuthTokenPayload,
@@ -981,16 +980,12 @@ const MCP_SYSTEM_PARAMETERS = new Set([
  * Uses the error extractor registry to find the best error message
  */
 function createTransformedErrorFromErrorInfo(errorInfo?: ErrorInfo, extractorId?: string): Error {
-  const safeErrorInfo =
-    extractorId === ErrorExtractorId.QUICKBOOKS_FAULT && errorInfo
-      ? { ...errorInfo, data: sanitizeQuickBooksFaultData(errorInfo.data) }
-      : errorInfo
-  const message = extractErrorMessage(safeErrorInfo, extractorId)
+  const message = extractErrorMessage(errorInfo, extractorId)
   const transformed = new Error(message)
   Object.assign(transformed, {
-    status: safeErrorInfo?.status,
-    statusText: safeErrorInfo?.statusText,
-    data: safeErrorInfo?.data,
+    status: errorInfo?.status,
+    statusText: errorInfo?.statusText,
+    data: errorInfo?.data,
   })
   return transformed
 }
