From d15cf1d867a500c2fb4d2ea86ed4212f13f2c316 Mon Sep 17 00:00:00 2001
From: Waleed Latif <walif6@gmail.com>
Date: Thu, 6 Aug 2026 17:13:27 -0700
Subject: [PATCH] fix(scripts): make the specifier audit path-separator
 agnostic
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Review round: isGeneratedPath split the repo-relative path on '/', but
path.relative returns backslashes on Windows, so '.source' and 'node_modules'
never matched a segment and generated output was treated as source. The repo
does support Windows dev — scripts/setup branches on win32.

The finding named one site; there were three. isCompiledSource compared against
'apps/sim/scripts/' with the same assumption, and workspaceFor matched
`${w.dir}/`, which on Windows never matches an absolute path and would have
dropped every file out of its own workspace — silently disabling tsconfig paths
resolution rather than erroring.

Normalized behind a repoPath() helper, with workspaceFor using path.sep against
absolute paths. Reported paths now go through it too, so output is identical on
either platform. spec.split('/') is left alone: import specifiers are always
'/'-separated regardless of host.

Verified by simulating win32 separators through the same predicates, and posix
behaviour is unchanged at 37,437 specifiers.
---
 scripts/check-import-specifiers.ts | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/scripts/check-import-specifiers.ts b/scripts/check-import-specifiers.ts
index 79f9abdf506..b8ad37a3b51 100644
--- a/scripts/check-import-specifiers.ts
+++ b/scripts/check-import-specifiers.ts
@@ -18,7 +18,7 @@
  * Usage: `bun run scripts/check-import-specifiers.ts [--verbose]`
  */
 import { readdirSync, readFileSync, statSync } from 'node:fs'
-import { dirname, join, relative, resolve } from 'node:path'
+import { dirname, join, relative, resolve, sep } from 'node:path'
 import { fileURLToPath } from 'node:url'
 
 const SCRIPT_DIR = dirname(fileURLToPath(import.meta.url))
@@ -46,11 +46,16 @@ const REQUIRE_RE = /\brequire\s*\(\s*['"]([^'"]+)['"]\s*\)/g
  */
 const SUBPATH_REQUIRED = new Set(['@sim/utils'])
 
+/** Repo-relative path, always `/`-separated — `relative()` yields `\` on Windows. */
+function repoPath(absolute: string): string {
+  return relative(ROOT, absolute).replaceAll('\\', '/')
+}
+
 /** Only source a bundler compiles — see the "Deliberately NOT checked" note above. */
 function isCompiledSource(full: string, name: string): boolean {
   if (!/\.(ts|tsx)$/.test(name) || name.endsWith('.d.ts')) return false
   if (/\.(test|spec)\.tsx?$/.test(name)) return false
-  const rel = relative(ROOT, full)
+  const rel = repoPath(full)
   return !rel.startsWith('apps/sim/scripts/') && !rel.startsWith('apps/realtime/scripts/')
 }
 
@@ -78,7 +83,7 @@ function walk(dir: string, acc: string[] = []): string[] {
  * would otherwise make every specifier in the repo look generated.
  */
 function isGeneratedPath(absolute: string): boolean {
-  const rel = relative(ROOT, absolute)
+  const rel = repoPath(absolute)
   if (rel.startsWith('..')) return true
   return rel.split('/').some((segment) => segment.startsWith('.') || SKIP_DIRS.has(segment))
 }
@@ -160,7 +165,7 @@ for (const group of ['apps', 'packages']) {
 workspaces.sort((a, b) => b.dir.length - a.dir.length)
 
 function workspaceFor(file: string): Workspace | undefined {
-  return workspaces.find((w) => file.startsWith(`${w.dir}/`))
+  return workspaces.find((w) => file.startsWith(w.dir + sep))
 }
 
 /** Matched a tsconfig path, but every target is generated — distinct from missing (`null`). */
@@ -328,7 +333,7 @@ for (const file of files) {
         checked++
         if (!outcome.ok) {
           violations.push({
-            file: relative(ROOT, file),
+            file: repoPath(file),
             line: lineAt(at),
             specifier: spec,
             kind: 'unresolved',
@@ -340,7 +345,7 @@ for (const file of files) {
         const subs = packageExports(spec)
         const example = subs ? [...subs.keys()].find((k) => k !== '.') : undefined
         violations.push({
-          file: relative(ROOT, file),
+          file: repoPath(file),
           line: lineAt(at),
           specifier: spec,
           kind: 'bare-barrel',