improve typing

Author: WilliamBergamin

slack_sdk/models/blocks/basic_components.py

@@ -166,7 +166,7 @@ class Option(JsonObject):
     different required formats in different situations
     """
 
-    attributes = {}  # type: ignore[assignment] # no attributes because to_dict has unique implementations
+    attributes: Set[str] = set()
     logger = logging.getLogger(__name__)
 
     label_max_length = 75
@@ -313,7 +313,7 @@ class OptionGroup(JsonObject):
     different required formats in different situations
     """
 
-    attributes = {}  # type: ignore[assignment] # no attributes because to_dict has unique implementations
+    attributes: Set[str] = {}  # type: ignore[assignment] # no attributes because to_dict has unique implementations
     label_max_length = 75
     options_max_length = 100
     logger = logging.getLogger(__name__)
@@ -395,7 +395,7 @@ def to_dict(self, option_type: str = "block") -> Dict[str, Any]:
 
 
 class ConfirmObject(JsonObject):
-    attributes = {}  # type: ignore[assignment] # no attributes because to_dict has unique implementations
+    attributes: Set[str] = set()
 
     title_max_length = 100
     text_max_length = 300

slack_sdk/models/dialogs/__init__.py

@@ -421,7 +421,7 @@ def __init__(
 
 
 class DialogBuilder(JsonObject):
-    attributes = {}  # type: ignore[assignment] # no attributes because to_dict has unique implementation
+    attributes: Set[str] = set()
 
     _callback_id: Optional[str]
     _elements: List[Union[DialogTextComponent, AbstractDialogSelector]]

slack_sdk/oauth/installation_store/async_cacheable_installation_store.py

@@ -26,7 +26,7 @@ def __init__(self, installation_store: AsyncInstallationStore):
     def logger(self) -> Logger:
         return self.underlying.logger
 
-    async def async_save(self, installation: Installation):  # type: ignore[explicit-override]
+    async def async_save(self, installation: Installation):
         # Invalidate cache data for update operations
         key = f"{installation.enterprise_id or ''}-{installation.team_id or ''}"
         if key in self.cached_bots:
@@ -36,14 +36,14 @@ async def async_save(self, installation: Installation):  # type: ignore[explicit
             self.cached_installations.pop(key)
         return await self.underlying.async_save(installation)
 
-    async def async_save_bot(self, bot: Bot):  # type: ignore[explicit-override]
+    async def async_save_bot(self, bot: Bot):
         # Invalidate cache data for update operations
         key = f"{bot.enterprise_id or ''}-{bot.team_id or ''}"
         if key in self.cached_bots:
             self.cached_bots.pop(key)
         return await self.underlying.async_save_bot(bot)
 
-    async def async_find_bot(  # type: ignore[explicit-override]
+    async def async_find_bot(
         self,
         *,
         enterprise_id: Optional[str],
@@ -64,7 +64,7 @@ async def async_find_bot(  # type: ignore[explicit-override]
             self.cached_bots[key] = bot
         return bot
 
-    async def async_find_installation(  # type: ignore[explicit-override]
+    async def async_find_installation(
         self,
         *,
         enterprise_id: Optional[str],

slack_sdk/oauth/installation_store/cacheable_installation_store.py

@@ -24,7 +24,7 @@ def __init__(self, installation_store: InstallationStore):
     def logger(self) -> Logger:
         return self.underlying.logger
 
-    def save(self, installation: Installation):  # type: ignore[explicit-override]
+    def save(self, installation: Installation):
         # Invalidate cache data for update operations
         key = f"{installation.enterprise_id or ''}-{installation.team_id or ''}"
         if key in self.cached_bots:
@@ -35,14 +35,14 @@ def save(self, installation: Installation):  # type: ignore[explicit-override]
 
         return self.underlying.save(installation)
 
-    def save_bot(self, bot: Bot):  # type: ignore[explicit-override]
+    def save_bot(self, bot: Bot):
         # Invalidate cache data for update operations
         key = f"{bot.enterprise_id or ''}-{bot.team_id or ''}"
         if key in self.cached_bots:
             self.cached_bots.pop(key)
         return self.underlying.save_bot(bot)
 
-    def find_bot(  # type: ignore[explicit-override]
+    def find_bot(
         self,
         *,
         enterprise_id: Optional[str],
@@ -63,7 +63,7 @@ def find_bot(  # type: ignore[explicit-override]
             self.cached_bots[key] = bot
         return bot
 
-    def find_installation(  # type: ignore[explicit-override]
+    def find_installation(
         self,
         *,
         enterprise_id: Optional[str],

slack_sdk/socket_mode/builtin/internals.py

@@ -88,7 +88,7 @@ def _establish_new_socket_connection(
         if status != 200:
             raise Exception(f"Failed to connect to the proxy (proxy: {proxy}, connect status code: {status})")
 
-        sock = ssl_context.wrap_socket(  # type: ignore[union-attr]
+        sock = ssl_context.wrap_socket(
             sock,
             do_handshake_on_connect=True,
             suppress_ragged_eofs=True,
@@ -103,7 +103,7 @@ def _establish_new_socket_connection(
         return sock
 
     sock = socket.create_connection((server_hostname, server_port), receive_timeout)
-    sock = ssl_context.wrap_socket(  # type: ignore[union-attr]
+    sock = ssl_context.wrap_socket(
         sock,
         do_handshake_on_connect=True,
         suppress_ragged_eofs=True,

slack_sdk/socket_mode/client.py

@@ -131,7 +131,7 @@ def run_message_listeners(self, message: dict, raw_message: str) -> None:
 
             for listener in self.message_listeners:
                 try:
-                    listener(self, message, raw_message)  # type: ignore[call-arg, arg-type]
+                    listener(self, message, raw_message)  # type: ignore[call-arg, arg-type, misc]
                 except Exception as e:
                     self.logger.exception(f"Failed to run a message listener: {e}")
 

slack_sdk/socket_mode/websocket_client/__init__.py

@@ -58,7 +58,7 @@ class SocketModeClient(BaseSocketModeClient):
     auto_reconnect_enabled: bool
     default_auto_reconnect_enabled: bool
 
-    close: bool  # type: ignore[assignment]
+    closed: bool
     connect_operation_lock: Lock
 
     on_open_listeners: List[Callable[[WebSocketApp], None]]
@@ -225,7 +225,7 @@ def send_message(self, message: str) -> None:
                     )
                     raise e
 
-    def close(self) -> None:  # type: ignore[explicit-override, no-redef]
+    def close(self) -> None:
         self.closed = True
         self.auto_reconnect_enabled = False
         self.disconnect()

slack_sdk/web/internal_utils.py

@@ -394,19 +394,19 @@ def _upload_file_via_v2_url(
     else:
         resp = urlopen(req, context=ssl, timeout=timeout)
 
-    charset = resp.headers.get_content_charset() or "utf-8"  # type: ignore[union-attr]
+    charset = resp.headers.get_content_charset() or "utf-8"
     # read the response body here
-    body: str = resp.read().decode(charset)  # type: ignore[union-attr]
+    body: str = resp.read().decode(charset)
     if logger.level <= logging.DEBUG:
         message = (
             "Received the following response - "
-            f"status: {resp.status}, "  # type: ignore[union-attr]
-            f"headers: {dict(resp.headers)}, "  # type: ignore[union-attr]
+            f"status: {resp.status}, "
+            f"headers: {dict(resp.headers)}, "
             f"body: {body}"
         )
         logger.debug(message)
 
-    return {"status": resp.status, "headers": resp.headers, "body": body}  # type: ignore[union-attr]
+    return {"status": resp.status, "headers": resp.headers, "body": body}
 
 
 def _validate_for_legacy_client(

slack_sdk/webhook/client.py

@@ -267,13 +267,13 @@ def _perform_http_request_internal(self, url: str, req: Request):
             http_resp = opener.open(req, timeout=self.timeout)
         else:
             http_resp = urlopen(req, context=self.ssl, timeout=self.timeout)
-        charset: str = http_resp.headers.get_content_charset() or "utf-8"  # type: ignore[union-attr]
-        response_body: str = http_resp.read().decode(charset)  # type: ignore[union-attr]
+        charset: str = http_resp.headers.get_content_charset() or "utf-8"
+        response_body: str = http_resp.read().decode(charset)
         resp = WebhookResponse(
             url=url,
-            status_code=http_resp.status,  # type: ignore[union-attr]
+            status_code=http_resp.status,
             body=response_body,
-            headers=http_resp.headers,  # type: ignore[arg-type, union-attr]
+            headers=http_resp.headers,  # type: ignore[arg-type]
         )
         _debug_log_response(self.logger, resp)
         return resp