Simplify Camera.beforePasses to a plain FramePass array (playcanvas#8582)

Remove unused requiresDepth metadata from Camera.beforePasses entries
introduced in playcanvas#8579, reverting the type to FramePass[]. The field was
never consumed by the scheduling logic.

Made-with: Cursor

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>

Author: mvaligursky

src/scene/camera.js

@@ -69,11 +69,10 @@ class Camera {
     framePasses = [];
 
     /**
-     * Frame passes that execute before this camera's main scene rendering. Each entry contains
-     * a pass and metadata controlling scheduling. Entries are picked up by the RenderPassForward
-     * that renders this camera's layers.
+     * Frame passes that execute before this camera's main scene rendering. Entries are picked up
+     * by the RenderPassForward that renders this camera's layers.
      *
-     * @type {{ pass: FramePass, requiresDepth: boolean }[]}
+     * @type {FramePass[]}
      */
     beforePasses = [];
 

src/scene/gsplat-unified/gsplat-compute-local-renderer.js

@@ -275,12 +275,9 @@ class GSplatComputeLocalRenderer extends GSplatRenderer {
     _registerFramePass() {
         const camera = this.cameraNode.camera?.camera;
         if (camera) {
-            const exists = camera.beforePasses.some(e => e.pass === this.framePass);
-            if (!exists) {
-                // Schedule the compute splat pass before this camera's scene rendering.
-                // requiresDepth hints that a depth prepass should run first, so the
-                // rasterize shader can skip splats behind opaque geometry.
-                camera.beforePasses.push({ pass: this.framePass, requiresDepth: true });
+            // Schedule the compute splat pass before this camera's scene rendering.
+            if (!camera.beforePasses.includes(this.framePass)) {
+                camera.beforePasses.push(this.framePass);
             }
             this._needsFramePassRegister = false;
         } else {
@@ -293,7 +290,7 @@ class GSplatComputeLocalRenderer extends GSplatRenderer {
         this._needsFramePassRegister = false;
         const camera = this.cameraNode.camera?.camera;
         if (camera) {
-            const idx = camera.beforePasses.findIndex(e => e.pass === this.framePass);
+            const idx = camera.beforePasses.indexOf(this.framePass);
             if (idx !== -1) {
                 camera.beforePasses.splice(idx, 1);
             }

src/scene/renderer/render-pass-forward.js

@@ -183,7 +183,7 @@ class RenderPassForward extends RenderPass {
                 if (camera) {
                     const { beforePasses } = camera;
                     for (let j = 0; j < beforePasses.length; j++) {
-                        this.beforePasses.push(beforePasses[j].pass);
+                        this.beforePasses.push(beforePasses[j]);
                     }
                 }
             }