Why some properties are hard coded?

[angelozerr]

Hi,

I am working on vscode-quarkus and Quarkus Tools for IntelliJ, and some user reported issues because they cannot retrieve some smallrye JWT properties in application.properties (completion, validation, navigation etc)

All properties that you have defined with @ConfigProperty are retrieved like smallrye.jwt.always-check-authorization

smallrye-jwt/implementation/jwt-auth/src/main/java/io/smallrye/jwt/config/JWTAuthContextInfoProvider.java

Line 352 in 927824c

@ConfigProperty(name = "smallrye.jwt.always-check-authorization", defaultValue = "false")

But some properties like smallrye.jwt.sign.key.location ar enot retrieved because it seems you have hard coded that without using ConfigProperty.

Is it a reason to do that? If yes I will hard code thos properties in our tooling.

Thanks for your answer.

[radcortez]

Probably, just an oversight. It should be ok to include this with the other properties.

[angelozerr]

You mean that you will do a fix on your side? Or do I need to hard code those properties?

[radcortez]

We can fix it from this side.

[angelozerr]

We can fix it from this side.

I think it is the better solution since property could be renamed, added or deleted.

Thanks!

[sberyozkin]

Hi @angelozerr @radcortez, apologies for a delay,
FYI, smallrye.jwt.sign.*, smallrye.jwt.encrypt.* belong to the JWT bulding space, see https://smallrye.io/docs/smallrye-jwt/generate-jwt.html#_configuration.

They are not part of the MP JWT spec, play no role in verifyng tokens. smallrye-jwt-build can also be used autonomously, without smallrye-jwt where the generated tokens are sent to non SmallRye JWT server that expects tokens.

Does it clarify it ?

[sberyozkin]

Hi again, @angelozerr @radcortez, I guess I can close this issue (please see my previous comment) or do you still see some scope for improvements ?

[angelozerr]

It means that those properties must be hard coded in our tooling?

I think (but not sure) that @gsmet would like to improve Quarkus properties websitte https://quarkus.io/guides/all-config to show other properties than Quarkus. If we need to hard code those properties in our tooling, https://quarkus.io/guides/all-config will have in the future the same problem than me.

[sberyozkin]

Thanks @angelozerr, so, having @ConfigProperty is what can help...

I have to admit, I'm not exactly sure yet how to fix it, as smallrye-jwt-build might work even without Quarkus/CDI