From ffc9c959072de086ec9400d98441b0cb7f5261ea Mon Sep 17 00:00:00 2001 From: Nikolay Tretyak Date: Tue, 17 Jun 2025 17:10:23 +0200 Subject: [PATCH] Don't use select * --- mysql/mysql.go | 2 +- postgresql/postgresql.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mysql/mysql.go b/mysql/mysql.go index 0273491..75b9e1d 100644 --- a/mysql/mysql.go +++ b/mysql/mysql.go @@ -117,7 +117,7 @@ func (db *DB) Del(bucket, key []byte) error { // List returns the full list of entries in a column. func (db *DB) List(bucket []byte) ([]*database.Entry, error) { - rows, err := db.db.Query(fmt.Sprintf("SELECT * FROM `%s`", bucket)) + rows, err := db.db.Query(fmt.Sprintf("SELECT nkey, nvalue FROM `%s`", bucket)) if err != nil { estr := err.Error() if strings.HasPrefix(estr, "Error 1146") { diff --git a/postgresql/postgresql.go b/postgresql/postgresql.go index 67716c5..0ed71f9 100644 --- a/postgresql/postgresql.go +++ b/postgresql/postgresql.go @@ -104,7 +104,7 @@ func (db *DB) Close() error { } func getAllQry(bucket []byte) string { - return fmt.Sprintf("SELECT * FROM %s", quoteIdentifier(string(bucket))) + return fmt.Sprintf("SELECT nkey, nvalue FROM %s", quoteIdentifier(string(bucket))) } func getQry(bucket []byte) string {