From 1a423fd2bd8107fe0845b4b0bcbd413513b55dbe Mon Sep 17 00:00:00 2001 From: Mariano Cano Date: Tue, 17 Mar 2026 11:20:34 -0700 Subject: [PATCH 1/2] Don't use SELECT * This commit selects only the columns used by the nosql package, nkey and nvalue Fixes #70 --- mysql/mysql.go | 2 +- postgresql/postgresql.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mysql/mysql.go b/mysql/mysql.go index 6d1339c..dc668db 100644 --- a/mysql/mysql.go +++ b/mysql/mysql.go @@ -116,7 +116,7 @@ func (db *DB) Del(bucket, key []byte) error { // List returns the full list of entries in a column. func (db *DB) List(bucket []byte) ([]*database.Entry, error) { - rows, err := db.db.Query(fmt.Sprintf("SELECT * FROM `%s`", bucket)) + rows, err := db.db.Query(fmt.Sprintf("SELECT nkey, nvalue FROM `%s`", bucket)) if err != nil { estr := err.Error() if strings.HasPrefix(estr, "Error 1146") { diff --git a/postgresql/postgresql.go b/postgresql/postgresql.go index 8770d04..cb0dc54 100644 --- a/postgresql/postgresql.go +++ b/postgresql/postgresql.go @@ -103,7 +103,7 @@ func (db *DB) Close() error { } func getAllQry(bucket []byte) string { - return fmt.Sprintf("SELECT * FROM %s", quoteIdentifier(string(bucket))) + return fmt.Sprintf("SELECT nkey, nvalue FROM %s", quoteIdentifier(string(bucket))) } func getQry(bucket []byte) string { From b9bf59c159214aa7024882de81c3234acff9f1a0 Mon Sep 17 00:00:00 2001 From: Mariano Cano Date: Tue, 17 Mar 2026 11:26:34 -0700 Subject: [PATCH 2/2] Fix CI labels --- .github/ISSUE_TEMPLATE/bug-report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md index 35c2346..3eb4f87 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.md +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -2,7 +2,7 @@ name: Bug Report about: Create a report to help us improve title: '' -labels: bug, needs triage +labels: ["bug", "needs triage"] assignees: '' ---