From abfa5aecc3a31afb11bb9a8a69a10d676b9d7866 Mon Sep 17 00:00:00 2001 From: ramdoys Date: Thu, 12 Feb 2026 18:05:17 -0500 Subject: [PATCH 1/2] convert to querydescendants --- .../Dependencies/Debug/ImOverlay/CeiveImOverlay.luau | 2 +- src-build/init.luau | 10 ++++------ src/init.luau | 10 ++++------ 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/src-build/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau b/src-build/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau index 730a4e3..6e88432 100644 --- a/src-build/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau +++ b/src-build/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau @@ -122,7 +122,7 @@ end function ImOverlay:m_Pool() -for _, Obj in self.BackFrame:GetChildren() do +for _, Obj in self.BackFrame:QueryDescendants("> :not(UIListLayout, [Visible = false])") do if Obj:IsA("UIListLayout") or not Obj.Visible then continue end diff --git a/src-build/init.luau b/src-build/init.luau index e22169f..b904386 100644 --- a/src-build/init.luau +++ b/src-build/init.luau @@ -141,16 +141,14 @@ function Class:m_CreateBoneTree(RootPart: BasePart, RootBone: Bone) local function AddChildren(Bone, ParentIndex, HeirarchyLength) SB_VERBOSE_LOG(`Adding bone: {Bone.Name}; {ParentIndex}; {HeirarchyLength}`) SB_INDENT_LOG() - local Children = Bone:GetChildren() + local Children = Bone:QueryDescendants("> Bone") local HasBoneChild = false for _, Child in Children do - if Child:IsA("Bone") then - self:m_AppendBone(BoneTree, Child, ParentIndex, HeirarchyLength) + self:m_AppendBone(BoneTree, Child, ParentIndex, HeirarchyLength) - AddChildren(Child, #BoneTree.Bones, HeirarchyLength + 1) - HasBoneChild = true - end + AddChildren(Child, #BoneTree.Bones, HeirarchyLength + 1) + HasBoneChild = true end if string.sub(Bone.Name, #Bone.Name - 3, #Bone.Name) == "_end" or string.sub(Bone.Name, #Bone.Name - 4, #Bone.Name) == "_Tail" then diff --git a/src/init.luau b/src/init.luau index a08de23..5eb432f 100644 --- a/src/init.luau +++ b/src/init.luau @@ -141,16 +141,14 @@ function Class:m_CreateBoneTree(RootPart: BasePart, RootBone: Bone) local function AddChildren(Bone, ParentIndex, HeirarchyLength) SB_VERBOSE_LOG(`Adding bone: {Bone.Name}; {ParentIndex}; {HeirarchyLength}`) SB_INDENT_LOG() - local Children = Bone:GetChildren() + local Children = Bone:QueryDescendants("> Bone") local HasBoneChild = false for _, Child in Children do - if Child:IsA("Bone") then - self:m_AppendBone(BoneTree, Child, ParentIndex, HeirarchyLength) + self:m_AppendBone(BoneTree, Child, ParentIndex, HeirarchyLength) - AddChildren(Child, #BoneTree.Bones, HeirarchyLength + 1) - HasBoneChild = true - end + AddChildren(Child, #BoneTree.Bones, HeirarchyLength + 1) + HasBoneChild = true end if string.sub(Bone.Name, #Bone.Name - 3, #Bone.Name) == "_end" or string.sub(Bone.Name, #Bone.Name - 4, #Bone.Name) == "_Tail" then From 4d1711110123b0fc8074b3e7a829b9940b77b614 Mon Sep 17 00:00:00 2001 From: ramdoys Date: Thu, 12 Feb 2026 20:56:34 -0500 Subject: [PATCH 2/2] fix error --- src-build/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau | 5 ----- src/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau | 6 +----- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src-build/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau b/src-build/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau index 6e88432..a7d4286 100644 --- a/src-build/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau +++ b/src-build/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau @@ -123,15 +123,10 @@ function ImOverlay:m_Pool() for _, Obj in self.BackFrame:QueryDescendants("> :not(UIListLayout, [Visible = false])") do - if Obj:IsA("UIListLayout") or not Obj.Visible then - continue - end - -- Quicker to change visibility than to re-parent Obj.Visible = false table.insert(self.m_ItemPool, Obj) end - end function ImOverlay:m_Cleanup() diff --git a/src/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau b/src/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau index dd72459..871cddc 100644 --- a/src/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau +++ b/src/Dependencies/Debug/ImOverlay/CeiveImOverlay.luau @@ -122,11 +122,7 @@ end function ImOverlay:m_Pool() debug.profilebegin("ImOverlay::m_Pool") - for _, Obj in self.BackFrame:GetChildren() do - if Obj:IsA("UIListLayout") or not Obj.Visible then - continue - end - + for _, Obj in self.BackFrame:QueryDescendants("> :not(UIListLayout, [Visible = false])") do -- Quicker to change visibility than to re-parent Obj.Visible = false table.insert(self.m_ItemPool, Obj)