Update code with rector

Author: javihgil

rector.php

@@ -19,6 +19,7 @@
         SetList::DEAD_CODE,
         SetList::TYPE_DECLARATION,
     ])
+    ->withImportNames()
     ->withPhpVersion(PhpVersion::PHP_84)
     ->withComposerBased(symfony: true)
     ->withSkip([

src/Form/DataTransformer/NodeDataTransformer.php

@@ -54,7 +54,7 @@ public function transform(mixed $value): mixed
 
             return $data;
         } catch (ReflectionException $e) {
-            throw new TransformationFailedException(sprintf('The "%s" class not exists', is_object($value) ? get_class($value) : $value));
+            throw new TransformationFailedException(sprintf('The "%s" class not exists', is_object($value) ? get_class($value) : $value), $e->getCode(), $e);
         }
     }
 
@@ -95,11 +95,11 @@ public function reverseTransform($value): mixed
 
             return $element;
         } catch (ReflectionException $e) {
-            throw new TransformationFailedException(sprintf('The "%s" class not exists', is_object($value) ? get_class($value) : $value));
+            throw new TransformationFailedException(sprintf('The "%s" class not exists', is_object($value) ? get_class($value) : $value), $e->getCode(), $e);
         }
     }
 
-    protected function reverseTransformInitialValue($value): mixed
+    protected function reverseTransformInitialValue(array $value): mixed
     {
         $className = $this->nodeDiscriminator->getClassNameForDiscriminator($value[$this->discriminatorField]);
 
@@ -111,7 +111,7 @@ protected function reverseTransformInitialValue($value): mixed
             }
 
             return $element;
-        } elseif ('array' == $className) {
+        } elseif ('array' === $className) {
             return [];
         }
 

src/Form/Discriminator/DoctrineNodeDiscriminator.php

@@ -28,17 +28,15 @@ public function getClassNameForDiscriminator($discriminator): string
         return $this->em->getClassMetadata($this->abstractClass)->discriminatorMap[$discriminator];
     }
 
-    public function getIdFieldForObject($object)
+    public function getIdFieldForObject($object): null
     {
         $classMetadata = $this->em->getClassMetadata(get_class($object));
 
-        if (sizeof($classMetadata->identifier) > 1) {
+        if (count($classMetadata->identifier) > 1) {
             throw new RuntimeException('DoctrinePolymorphicCollection only supports entities with one identity field');
         }
 
-        $idField = $classMetadata->identifier[0];
-
-        return $idField;
+        return $classMetadata->identifier[0];
     }
 
     public function findObjectById($className, $id): ?object

src/Form/Discriminator/NodeDiscriminator.php

@@ -55,7 +55,7 @@ public function getDiscriminatorForObject($object): string
         return $discr;
     }
 
-    public function getIdFieldForObject($object)
+    public function getIdFieldForObject($object): null
     {
         return null;
     }

src/Form/EventListener/NodesResizeFormListener.php

@@ -39,7 +39,7 @@ public static function getSubscribedEvents(): array
     /**
      * Before data is set, add the existing collection subforms.
      */
-    public function preSetData(FormEvent $event)
+    public function preSetData(FormEvent $event): void
     {
         $nodes = $event->getData() ?? [];
         $form = $event->getForm();
@@ -55,7 +55,7 @@ public function preSetData(FormEvent $event)
     /**
      * After submitted data is set (and before validation), add the new collection subforms.
      */
-    public function preSubmit(FormEvent $event)
+    public function preSubmit(FormEvent $event): void
     {
         $nodes = $event->getData();
         $form = $event->getForm();
@@ -73,11 +73,11 @@ public function preSubmit(FormEvent $event)
         }
     }
 
-    protected function addSubform($name, string $discr, FormInterface $form)
+    protected function addSubform(self|string $name, string $discr, FormInterface $form)
     {
         $formClass = $this->nodeDiscriminator->getFormTypeFromDiscriminator($discr);
 
-        if (empty($formClass)) {
+        if ('' === $formClass || '0' === $formClass) {
             throw new RuntimeException(sprintf('No form type was found for %s discriminator value', $discr));
         }
 

src/Form/Type/DoctrinePolymorphicCollectionType.php

@@ -59,7 +59,7 @@ protected function getEntityManager(array $options): EntityManagerInterface
             }
 
             return $options['entity_manager'];
-        } elseif ($this->em) {
+        } elseif ($this->em instanceof EntityManagerInterface) {
             return $this->em;
         }
 

src/Form/Type/PolymorphicCollectionType.php

@@ -5,7 +5,6 @@
 use Softspring\Component\PolymorphicFormType\Form\DataTransformer\NodeDataTransformer;
 use Softspring\Component\PolymorphicFormType\Form\Discriminator\NodeDiscriminator;
 use Softspring\Component\PolymorphicFormType\Form\EventListener\NodesResizeFormListener;
-use Softspring\Component\PolymorphicFormType\Form\Type\Node\AbstractNodeType;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Exception\RuntimeException;
 use Symfony\Component\Form\Extension\Core\Type\CollectionType;
@@ -71,14 +70,7 @@ public function buildView(FormView $view, FormInterface $form, array $options):
         $prototypes = [];
 
         foreach ($options['types_map'] as $discr => $formClass) {
-            /* @var AbstractNodeType $formType */
-            if (is_object($formClass)) {
-                $formType = $formClass;
-            } elseif (class_exists($formClass)) {
-                $formType = $formClass;
-            } else {
-                $formType = $formClass;
-            }
+            $formType = $formClass;
 
             $formOptions = $options['types_options'][$discr] ?? [];
             $formOptions['discriminator_field'] = $options['discriminator_field'];
@@ -103,7 +95,7 @@ protected function getFormFactory(array $options): FormFactory
             }
 
             return $options['form_factory'];
-        } elseif ($this->formFactory) {
+        } elseif ($this->formFactory instanceof FormFactory) {
             return $this->formFactory;
         }